Emily Brown

This commit introduces a **new capability** to **suppress LogBox messages** during **CDP performance tracing** to ensure more accurate performance measurements. It establishes a **native observer infrastructure** within the **JavaScript Inspector Runtime** (`RuntimeTarget`) to detect tracing state changes and communicate them to JavaScript. The **LogBox module** (`LogBoxData.js`) then integrates with a new `TracingStateObserver` to **clear existing LogBox messages and prevent new ones from being displayed** while tracing is active. This **enhancement** significantly improves the reliability of performance profiles by preventing LogBox UI updates from skewing results, leading to more precise performance analysis.

This commit **refactors** the **JS Inspector modern** and **DevSupport** subsystems by extracting a common global state observation pattern into reusable components. It introduces a new generic **`GlobalStateObserver`** class in JavaScript and C++ helper functions (`installGlobalStateObserver`, `emitGlobalStateObserverChange`) to encapsulate shared logic. Existing observers, specifically **`FuseboxSessionObserver`** and **`RuntimeTargetDebuggerSessionObserver`**, are updated to delegate to these new shared implementations. This **preparatory work** improves code reusability and maintainability, paving the way for future features like `PerformanceTracerObserver` to leverage the standardized pattern, with **no behavioral changes** to current functionality.

This commit performs a **refactoring** of the project's **GitHub Actions CI/CD workflows** to align with established naming conventions. It specifically renames workflow job IDs from `kebab-case` to `snake_case` within `.github/workflows/analyze-pr.yml` and `.github/workflows/api-changes.yml`. Additionally, the workflow name in `api-changes.yml` was updated from 'Validate API snapshot changes' to 'Analyze API Changes'. This **maintenance** task enhances the consistency and readability of the automated analysis and validation configurations, improving overall maintainability without introducing any functional changes to the core project.

This commit introduces a **new capability** to the **CI/CD workflow** by implementing a **branch targeting validation** for pull requests, replacing a previous Danger.js check. The updated `analyze-pr.yml` workflow now utilizes a new script, `.github/workflow-scripts/checkBranchTarget.js`, to ensure PRs target either `main` or a `-stable` branch. This enhancement **automates the addition of the "Pick Request" label** for stable branch targets, improving PR management and streamlining the release process by enforcing correct branch hygiene.

This commit **removes the deprecated Danger.js infrastructure** from the project's **CI pipeline**, including the `danger-pr.yml` workflow and the `dangerfile.js` from the `react-native-bots` package. This **maintenance and refactoring** effort migrates all PR annotation and validation checks, such as API diff detection and PR body validation, to native GitHub Actions within the `annotate-pr.yml` workflow. The change **simplifies the CI pipeline** by eliminating a third-party dependency and consolidating logic, improving overall maintainability and efficiency of pull request checks.

This commit **introduces a new automated validation system** for Pull Request bodies within the **GitHub Actions CI/CD pipeline**. It adds a `validatePRBody.js` script and an `analyze-pr.yml` workflow to enforce standards for PR descriptions, checking for minimum length, the presence of "Summary" and "Test Plan" sections, and valid changelog entries. This **new capability** aims to improve the **quality and consistency of PR submissions**, providing immediate feedback to contributors. The validation workflow will fail if critical sections are missing or invalid, but it gracefully skips certain checks for Phabricator-sourced PRs, ensuring a streamlined developer experience.

This commit **refactors** the **CI/CD system** by introducing a new **GitHub Actions workflow**, `api-changes.yml`, to replace the existing `danger-pr` mechanism for detecting and reporting changes in the **JavaScript API**. It implements two new GitHub Actions: `diff-js-api-changes` to identify API modifications and `post-pr-comment` to manage automated feedback on pull requests. This **maintenance** and **new capability** effort streamlines the process of monitoring **API stability** and provides immediate, automated feedback to developers directly within the pull request flow. The change enhances the **developer experience** by ensuring consistent and timely notification of API evolution.

This commit **updates the Flow type definition** for the **`URL` constructor** within **React Native's DOM types** (`packages/react-native/flow/dom.js.flow`). It **fixes** the type signature to correctly accept a `URL` object as the first argument, aligning with the WHATWG URL API specification where `USVString` parameters can accept stringifiable objects. This **type definition update** also clarifies that both the `url` and `base` arguments can accept `URL` objects or `StringLike` objects. The change improves **type correctness** and enhances the **developer experience** by preventing unnecessary Flow errors when using the `URL` constructor with valid `URL` object inputs.

This commit **refactors** the handling of `serverBaseUrl` within the **`dev-middleware` package**, transitioning its type from a simple string to a native `URL` object. This change significantly improves **type safety** and enables more robust URL manipulation by leveraging the built-in `URL` API instead of string concatenation. The public `createDevMiddleware` function now gracefully accepts either a `string` or `URL` object, ensuring backward compatibility while promoting the new, more reliable type. Internally, core components like `InspectorProxy`, `openDebuggerMiddleware`, and `getDevToolsFrontendUrl` have been updated to consistently use `URL` objects, enhancing the overall stability and maintainability of the **Metro CLI and Gateway**'s development server infrastructure.

This commit **fixes** the **`diff-js-api-changes` GitHub Action** to accurately compare the API snapshot of a pull request's head against its merge base with the `main` branch. Previously, the action was incorrectly comparing `main` to `main`, leading to inaccurate or missing API change detections. The **CI/CD workflow** (`danger-pr.yml`) is updated to explicitly check out `main` for trusted scripts, ensuring **security** by only executing trusted code. This **maintenance update** provides **accurate API diffs** for all incoming pull requests, improving the reliability of API change reviews.

This commit **fixes a Flow type definition** by adding the missing `isBinary: boolean` parameter to the `ws$MessageListener` type within the `ws` library's Flow declarations. Previously, the type only accounted for the `data` parameter, causing Flow errors when correctly accessing the `isBinary` flag provided by the `ws` `message` event. This **maintenance update** ensures **type correctness** for `ws` message listeners in both **Metro** and **React Native GitHub** environments, allowing proper usage of binary message detection. The change is backwards compatible, as existing JavaScript code that ignored the second parameter will continue to function, while Flow will now correctly validate its usage.

This commit **fixes a bug** in the **React Native DevTools frontend** that prevented the "Open in Editor" button in the **Sources tab** from functioning correctly. Previously, clicking this button resulted in a **400 Bad Request error** because the underlying `openStackFrameInEditor` request was missing the required `Content-Type` header. By updating the frontend assets to include this header, the **debugging experience** is improved, allowing developers to seamlessly navigate to source code from stack frames. This ensures the **DevTools Sources panel** provides its intended functionality for code inspection.

This commit **adds a new capability** to the **React Native DevTools Performance panel** by introducing the `ResourceReceivedData` trace event. This event is emitted by the `NetworkReporter` when **chunked network response data** is received, specifically for incremental text responses, providing more granular insights into network activity. It enhances the **`jsinspector-modern` subsystem's performance tracing** by aligning with the behavior of CDP's `Network.dataReceived` event. Developers can now observe detailed data reception events, significantly improving the diagnosis and optimization of network performance for streaming or chunked responses.

This commit **fixes a bug** in the **API snapshot generation** process by ensuring `declare const` type declarations are correctly tracked when computing API hashes. Previously, changes to these types, such as `AccessibilityInfo`, were not always reflected in the `ReactNativeApi.d.ts` hash, leading to **missed breaking change detections**. The **`versionExportedApis.js`** script is updated to include `VariableDeclaration` nodes, prevent declaration overwrites, and properly extract dependencies from `TSTypeQuery` nodes (e.g., `typeof X`). This **improves the accuracy of breaking change detection** for the React Native API, though it will cause many existing API hashes to change due to the more comprehensive dependency tracking.

This commit delivers a **bug fix** for the **`RCTDevLoadingView`** on **iOS**, specifically addressing redundant tap handling for the dismiss button within the development loading banner. It **removes the `primaryAction`** and disables user interaction for the dismiss button in `RCTDevLoadingView.mm`, making it purely visual. This change ensures that taps on the dismiss button now correctly pass through to the underlying banner's tap gesture recognizer, **improving the overall user interaction** and preventing conflicting tap behaviors.

This commit **fixes** an issue in the **`RCTDevLoadingView`** on **iOS** where the development loading banner would incorrectly block all touch interactions on the screen. Previously, the banner's window occupied the full screen height, making the underlying app unresponsive even when only a small banner was visible. This **bug fix** adjusts the banner's window frame to precisely match its content height after Auto Layout completes, ensuring that only the banner itself is interactive. As a result, the rest of the application's UI below the banner remains fully responsive, significantly **improving the developer experience** by preventing unintended UI blocking.

This commit **fixes two bugs** within the **`RCTDevLoadingView`** component, which is part of **React Native's iOS development tools**. It addresses an issue where the dismiss button would not appear consistently by moving its creation and removal logic to execute dynamically on every `showMessage` call, ensuring it's added or removed based on the current parameter. Additionally, it resolves a button text wrapping problem by setting appropriate compression resistance and content hugging priorities, preventing the button from being compressed and ensuring its text is always visible. This **bug fix** also enhances state management by resetting all UI elements in the `hide()` method, ensuring a clean slate between loading sessions while preserving previous performance optimizations.

This commit **fixes a crash** occurring in the **`RCTDevLoadingView`** on **iOS** by correcting a faulty conditional check. Previously, when attempting to add layout constraints for the dismiss button, the implementation incorrectly referenced a function parameter instead of the `self->_dismissButton` instance variable, leading to `NSLayoutConstraint` crashes. This **bug fix** ensures the proper instance variable is verified before applying constraints, thereby preventing unexpected application termination and improving the stability of the **React Native development experience**.

This commit **enhances the developer experience** by introducing a visible "Dismiss x" button to the "Disconnected from dev server" Fast Refresh notifier message. This **new capability** provides a clear visual cue for dismissing the banner, complementing the existing tap-anywhere gesture. The change impacts the **DevLoadingView** across **iOS and Android native modules**, updating the `showMessage` method signature to include a `dismissButton` parameter. This modification is propagated through the JavaScript `HMRClient` and the `NativeDevLoadingView` TurboModule specifications, ensuring a consistent and more intuitive way to dismiss developer-facing messages.