Artem Kholodnyi

This commit **fixes broken tests** within the **Fresco `fbcore` module**, specifically addressing issues in `BetterImageSpanMarginTest.java`. The **maintenance fix** involves **refactoring the test data** to use `int` arrays for margin values instead of `Rect` objects, and ensuring `Rect` instances are properly initialized in the test setup. This change resolves previous test failures, ensuring the correct validation of `BetterImageSpan` functionality and improving the overall stability of the test suite.

This commit **enhances the documentation** for the **Fresco Vito core library** by adding KDoc to the `fetch` function within `FrescoController2.kt`. This **maintenance task** specifically clarifies the return value of the `fetch` method, improving the overall readability and understanding of this critical API. By providing explicit documentation for `FrescoController2#fetch`, developers can more easily comprehend its behavior and integrate it correctly, reducing potential misuse and streamlining future development efforts.

This commit performs a **refactoring** within the **Fresco Vito core implementation** by removing the redundant boolean return type from the `setActualDrawable` function in `FrescoController2Impl.kt`. Since `setActualDrawable` consistently returned `true`, its signature has been simplified, and all call sites, including within the `submit` method, have been updated accordingly. This change improves code clarity and maintainability by eliminating unnecessary API surface without altering the functional behavior of the image loading system.

This commit performs a **refactoring** within the **Fresco Vito core implementation** by adjusting the visibility of an internal function. Specifically, the `setActualDrawable` function in `vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoController2Impl.kt` has been marked as **private**. This change improves the **encapsulation** of the `FrescoController2Impl` class, ensuring that `setActualDrawable` is only invoked internally. The scope of this work is to enhance internal API consistency and maintainability within the **Fresco Vito core**, with no impact on external functionality or public APIs.

This commit **refactors** the **Image Pipeline's caching mechanism** by converting the `CacheMissException` class from Java to Kotlin. This **language migration** ensures the exception's functionality remains identical, preserving its behavior for all callers within the `com.facebook.imagepipeline.cache` package. The change is a **maintenance** effort to modernize the codebase, with no expected functional impact on downstream consumers or the overall image loading process.

This commit primarily involves a significant **refactoring** within the **ImagePipeline** library, converting the `CacheKeyFactory` interface and its associated methods like `getBitmapCacheKey` and `getEncodedCacheKey` from Java to Kotlin. Concurrently, it introduces a **bug fix** in the `ImagePipeline` core by adding a crucial null check for `imageRequest` within the `isInDiskCache` method. This change prevents potential `NullPointerException` issues when querying the disk cache with a null request, thereby enhancing the overall stability and modernizing the codebase of the image loading system. The work improves the maintainability of the **caching mechanism** and fortifies the **core disk cache checks**.

This commit **fixes a bug** within the **Android build configuration system** that caused incorrect parsing of `BuildConfig` field values containing an equals sign (`=`). Specifically, the `_get_build_config_field` function in `prelude/android/android_build_config.bzl` has been updated to correctly handle these values by limiting its string split operation. This **bug fix** ensures that **Android builds** can properly process context-arguments and other configurations where values might inherently include an equals sign. The change prevents parsing errors and improves the robustness of the build process for **Android projects**.

This commit introduces a **new feature** by adding the `ModifiedByAiqConfig` class to the **`urimod`** module within Fresco. This class is specifically designed to represent and manage **URI modifications** that are driven by **AIQ configuration**. It establishes the foundational structure for enabling dynamic URI processing based on AIQ settings, allowing for more intelligent and configurable URI handling within the system. This change prepares the `urimod` for future integration with AIQ-driven behaviors, impacting how URIs are interpreted and transformed.

This commit **refactors** the **ImagePipeline's disk caching mechanism** by **migrating** the `DefaultDiskStorage` implementation from Java to Kotlin. The entire `DefaultDiskStorage.kt` file was rewritten to leverage Kotlin's features, improving code maintainability and consistency within the `imagepipeline-base` module. This change is an internal language conversion and does not alter the external behavior or functionality of the disk cache, but sets the foundation for future Kotlin-native enhancements in the **caching layer**.

This commit **refactors** the **Image Pipeline's `producers` module** by **converting the `PostprocessorProducer` class and its nested consumer classes from Java to Kotlin**. This language migration modernizes the implementation of `PostprocessorProducer`, `PostprocessorConsumer`, `SingleUsePostprocessorConsumer`, and `RepeatedPostprocessorConsumer`. The change is purely an internal **codebase modernization**, affecting core logic within methods like `produceResults()` and `doPostprocessing()`. There is **no functional impact** on the Image Pipeline's behavior or its downstream consumers, as the public API and semantic behavior remain unchanged.

This commit **refactors** the **`FLog` logging utility** within the `fbcore` module to improve its internal robustness and null-safety. It **removes redundant non-null assertions** from various logging methods, including `v`, `d`, `i`, `w`, `e`, and `wtf`, simplifying their implementation. Additionally, the `getTag` function is updated to consistently return a non-nullable `String`, ensuring callers always receive a valid tag. This **maintenance** work enhances the reliability and clarity of the **`FLog` API**, reducing potential null-pointer issues within the logging framework itself.

This commit **refactors** the `MainActivity` within the `samples/comparison` module by **converting its implementation from Java to Kotlin**. This **language migration** preserves all existing functionality related to image loading, display, and user interaction, ensuring no behavioral changes for the end-user. The conversion of `MainActivity.java` to `MainActivity.kt` directly impacts the codebase's maintainability and future development, without altering the application's runtime behavior or feature set.

This commit **refactors** the **`FLog` logging utility** by converting its implementation from Java to Kotlin. The conversion of `fbcore/src/main/java/com/facebook/common/logging/FLog.kt` maintains all existing functionality, including methods like `setLoggingDelegate`, `isLoggable`, and various logging levels (`v`, `d`, `i`, `w`, `e`, `wtf`). This **language migration** improves the codebase's consistency and leverages Kotlin's features without introducing any functional changes or downstream impact for consumers of the logging utility.

This commit performs a significant **refactoring** within the **`imagepipeline`** module by **converting the core `ProducerFactory` class from Java to Kotlin**. This modernization effort impacts the creation logic for numerous producers, including `DecodeProducer` and `DiskCacheWriteProducer`, enhancing code maintainability and leveraging Kotlin's null safety features. Consequently, several producer sequences and related classes, such as `ProducerSequenceFactory`, also see updates to their type parameters, specifically removing nullable `EncodedImage` types. This internal change streamlines the **ImagePipeline**'s producer instantiation mechanism without altering its external behavior or introducing new features.

This commit **refactors** the **Image Pipeline** test suite by **converting** the `ResizeAndRotateProducerTest` from Java to Kotlin. The entire test file, located at `imagepipeline/src/test/java/com/facebook/imagepipeline/producers/ResizeAndRotateProducerTest.kt`, has been rewritten, including all test methods and helper functions. This **maintenance** effort aims to modernize the test codebase, improving its consistency and developer experience within the `imagepipeline` module. The change is purely internal to the test infrastructure and does not alter the runtime behavior or public API of the `ResizeAndRotateProducer`.

This commit **refactors** the core `Objects` utility class within the `fbcore/common/internal` module by **converting its entire implementation from Java to Kotlin**. This **language migration** ensures that all existing functionality, including methods like `equal`, `hashCode`, `toStringHelper`, and `firstNonNull`, is preserved without any behavioral changes. The primary goal is to modernize the codebase and enhance maintainability for this widely used utility, with no expected downstream impact on its consumers.

This commit primarily **migrates the `BasePoolTest` from Java to Kotlin**, modernizing the testing infrastructure for the **ImagePipeline memory module**. This **test conversion** ensures future maintainability and leverages Kotlin's features for the core memory pooling tests. Additionally, a minor **refactoring** was performed in `PoolStats.java` within the `imagepipeline-test` module, standardizing internal member variable naming from `mPrefix` to `prefix` for improved code consistency. This change has no functional impact but enhances code readability and consistency across the codebase.

This commit **refactors** the **ImagePipeline**'s `EmptyJpegGenerator` by **migrating its implementation from Java to Kotlin**. Specifically, the `EmptyJpegGenerator` class and its `generate` method within the `com.facebook.imagepipeline.bitmaps` package have been rewritten. This **language conversion** aims to modernize the codebase, leveraging Kotlin's features for improved readability and maintainability. The change primarily impacts the internal implementation details of how empty JPEG images are created, without altering the external behavior or API of the ImagePipeline.

This commit introduces a **new image loading mechanism** within the **Fresco Vito view implementation**, specifically affecting `VitoViewImpl2.kt`. It leverages the `onLayoutChange` event to trigger image loading, providing a more precise and potentially efficient way to initiate the `show` operation. This **enhancement** allows for images to be loaded or reloaded in response to layout changes, complementing the existing `onViewAttachedToWindow` trigger. The change also includes new **configuration flags** to manage this behavior, offering greater control over the image display lifecycle within the **Vito view system**.

This commit introduces an **LRU cache** within the **Fresco Vito `ImageSourceProvider`** to optimize URI parsing and retrieval. This **new feature** integrates the cache directly into the `forUri` method, allowing the system to store and quickly retrieve previously parsed URI strings. The primary goal is to significantly improve **performance** by reducing redundant URI parsing operations. This enhancement leads to faster image source resolution and overall responsiveness within the image loading subsystem.