Dmitriy Vasyura

This commit **introduces new sanity tests for the CLI Dev Tunnel functionality**, significantly expanding the project's test coverage. It adds a dedicated test file, `test/sanity/src/devTunnel.test.ts`, to validate Dev Tunnel operations across various platforms. To enhance test reliability and debugging, the commit also **refactors** existing test infrastructure in `githubAuth.ts` and `wsl.test.ts` by adding try-catch blocks and screenshot captures on error. Furthermore, it improves the screenshot utility in `test/sanity/src/context.ts` to prevent overwrites and integrates necessary environment variables for Docker-based test execution, ensuring robust and debuggable test runs for this **new capability**.

This commit delivers significant **maintenance** and **UI improvements** to the application's **update mechanism**. It **refactors** the update notification experience by replacing link-based actions in the update tooltip with a more prominent button bar and **removes the dedicated update title bar entry**, streamlining the UI. Furthermore, the **update lifecycle management** is enhanced with the introduction of a new `Restarting` state and a **bug fix** ensuring the `explicit` flag is correctly passed during the update process. This work also includes a **bug fix** for title bar overflow issues and removes telemetry related to the title bar update mode.

This commit **enhances the stability of sanity tests** by introducing **retry logic for `dpkg` commands** on Linux, specifically addressing `dpkg` lock errors that can cause test flakiness. It **refactors the test `context` module** (`test/sanity/src/context.ts`) to include a new `timeout` helper and integrate these retry mechanisms into package installation and uninstallation methods like `installDeb` and `uninstallDeb`. This **maintenance work** ensures more robust test execution by making package management operations within tests more resilient to transient failures. Consequently, calls to affected functions, such as `context.installDeb` in `desktop.test.ts`, are updated to correctly `await` their now asynchronous execution, significantly **reducing test flakiness** and improving CI reliability.

This commit **fixes an issue** within the **update UI** where the update tooltip in the title bar was not consistently refreshed across all open windows. Specifically, it modifies the `UpdateTitleBarEntry` component to react to window focus/blur events (`onDidFocusWindow`, `onDidBlurWindow`) and active window changes (`onDidActiveWindowChange`). This **bug fix** ensures that the update status tooltip is accurately displayed in every window, improving the multi-window user experience for update notifications.

This commit **removes the automated trigger** for the **sanity tests pipeline**, specifically targeting the project's continuous integration/continuous deployment (CI/CD) configuration. This **maintenance adjustment** means the `sanity-tests` will no longer execute automatically upon certain events, requiring manual invocation or a revised triggering strategy for these critical checks. The change primarily impacts the **testing infrastructure** and the automated release process, ensuring greater control over when these resource-intensive tests are run.

This commit **refactors** and **enhances** the **update service** by centralizing the tracking of application version changes. A new `trackVersionChange` method is introduced in `src/vs/platform/update/electron-main/abstractUpdateService.ts` to consistently log telemetry data, utilizing storage and telemetry services. This change involves updating platform-specific update services (`updateService.darwin.ts`, `updateService.linux.ts`, `updateService.win32.ts`) to pass these services to the abstract base class, while simultaneously removing redundant tracking logic from `src/vs/workbench/contrib/update/browser/updateTitleBarEntry.ts`. The overall impact is a **more robust and centralized mechanism for collecting update velocity telemetry**, improving data consistency and simplifying the `updateTitleBarEntry` module.

This commit introduces **maintenance improvements** to the **sanity test suite**, primarily focusing on enhancing test reliability and logging capabilities. Specifically, the `test/sanity/src/context.ts` module now includes a new `warn` method for logging warnings and updates the `error` method to align with **Azure DevOps logging format**, improving error visibility. Concurrently, the `test/sanity/src/uiTest.ts` module sees an increase in retry attempts and the implementation of a retry loop within the `installExtension` method, directly addressing **flakiness in UI tests** related to extension installation. These changes collectively aim to make the **sanity tests more robust and reliable**, reducing intermittent failures and providing clearer diagnostic information during test execution.

This commit introduces **telemetry logging** for **update actions** initiated directly from the **title bar entry**. It specifically adds tracking for user interactions with `download`, `install`, and `restart` commands related to software updates. This **new feature** enhances the **telemetry collection** for the `update` subsystem, providing valuable insights into how users engage with the update process. The changes primarily affect the `updateTitleBarEntry.ts` file, improving our understanding of the **update experience** and informing future development.

This commit delivers several **bug fixes** and **UI/UX improvements** to the **update mechanism**. It **repositions the Update button** to its own group within the **title bar** to prevent layout shifts and replaces actionable state notifications with a direct animation effect on the button itself. The changes also refine the **update service's state management** by preventing transient update states from persisting and ensure update UI elements are not displayed when the title bar is hidden. These adjustments enhance the user experience by providing a less intrusive and more consistent update notification system.

This commit **fixes a focus issue** within the **update title bar entry** component, specifically by refining the `handleFocus` logic in `updateTitleBarEntry.ts`. Concurrently, it **enables** this update entry to be displayed for **insider builds** by adjusting the configuration in `update.config.contribution.ts`. This **enhances the user experience** for Insiders by providing a stable and functional update status indicator directly in the title bar.

This commit significantly **enhances the update notification experience** by introducing new capabilities and refining existing UI elements. It **overhauls the update tooltip** to display richer information, including markdown-rendered release notes and a version copy feature, while also adding a **new configuration option** (`update.titleBar: 'always'`) for persistent display. The **title bar update entry** itself is refactored to include detailed state management, detect major/minor version changes, and improve visual alignment, providing users with a more informative and user-friendly update mechanism. This work primarily constitutes **feature development** within the **update subsystem**, improving both functionality and user interface.

This commit introduces an **experimental update indicator in the title bar**, controlled by a new configuration setting `update.titleBar`. It significantly **refactors the update UI**, moving the primary update notification from the status bar to this new title bar entry, and introduces a new stateful `UpdateTooltip` component. Furthermore, the **update service logic** is enhanced across various platforms to support policy-based update disablement and utilizes new utility functions in `updateUtils.ts` for robust version parsing and update information calculations. The existing `UpdateStatusBarEntry` is refactored to conditionally display and leverage the new tooltip. This work represents a **new feature** and substantial **refactoring** of the update subsystem, improving both its user-facing presentation and underlying robustness.

This change enhances the application's update service by incorporating `internalOrg` into the update feed URL construction. This enables more granular or organization-specific update checks for new versions.

This commit **fixes and improves the reliability** of the **extension installation wait condition** within the **UI test suite**. Specifically, it updates the `installExtension` function in `test/sanity/src/uiTest.ts` to leverage `getByRole` for a more robust and stable waiting mechanism. This **test improvement** addresses potential flakiness in existing UI tests, ensuring more consistent and reliable execution when verifying extension installations.

This commit enhances the **sanity test runner** by introducing **verbose logging** for key test execution events. It now logs the start, pass, and fail events of Mocha tests, along with the final exit status of the test runner, specifically within `test/sanity/src/index.ts`. This **maintenance** improvement provides better visibility into test execution, making it easier to diagnose issues or understand the flow of tests. The added logging will significantly aid in debugging unexpected test runner behavior or test failures.

Fix Guardian errors in sanity tests stage (#298662)

This commit significantly **improves the stability and diagnosability of the sanity testing framework**. It introduces **automatic screenshot capture on UI test failures**, providing crucial visual context for debugging, configurable via a new `--screenshots-dir` command-line option. Furthermore, it enhances **resource cleanup** by ensuring browsers and Electron applications are consistently closed after tests in `serverWeb.test.ts`, `wsl.test.ts`, and `desktop.test.ts` using `try-finally` blocks. These **maintenance** updates also bolster the robustness of command execution and extension installation within `uiTest.ts`, leading to more reliable and less flaky test runs across the entire test suite.

This commit introduces a **UI/UX improvement** to the **update status bar entry**, making it less intrusive and more subtle within the workbench. The `src/vs/workbench/contrib/update/browser/media/updateStatusBarEntry.css` file is updated to **adjust the entry's color and font size**, reducing its visual prominence. Concurrently, `src/vs/workbench/contrib/update/browser/updateStatusBarEntry.ts` modifies the entry to **remove its prominent kind**, change its icon to a filled circle, and **align it to the right** of the status bar. This **feature enhancement** provides update information in a more discreet manner, improving the overall user experience by affecting the `workbench/contrib/update` module.

This commit **finalizes the `env.isAppPortable` API**, transitioning it from a proposed feature to a stable part of the **extension host API**. The change involves **removing references to the proposed API definition** (`vscode.proposed.envIsAppPortable.d.ts`) from `tsconfig.json` files within the `github-authentication` and `microsoft-authentication` extensions, and **simplifying the `isAppPortable` getter** implementation in `extHost.api.impl.ts`. This **API stabilization** allows extension developers to reliably use `env.isAppPortable` to determine if the application is running in a portable mode, without requiring experimental API opt-ins. The work improves API consistency and reduces boilerplate for extensions utilizing this capability.

This commit implements a **bug fix** for the **Windows update service** to resolve issues where update timeouts occurred during system hibernation. It replaces a fixed polling timeout with a `ProcessTimeRunOnceScheduler` within `updateService.win32.ts`, ensuring the update process correctly accounts for system sleep states. Additionally, the commit **refactors** file unlinking into a dedicated private method and enhances error handling for `unlinkSync` in the `quitAndInstall` function, improving the overall reliability and robustness of the update mechanism.