Alexander Potapenko

This commit **introduces a new automated background task** by registering the `/cron/dungeon_preheat` endpoint within the **`dashboard/app`** module. It **configures App Engine's cron scheduler** to execute this new handler **hourly** via an entry in `cron.yaml`. This **new feature** ensures that the `handleDungeonPreheat` logic is regularly invoked by the `initHTTPHandlers` function. The change enables proactive data preparation or caching for the "dungeon" subsystem, improving overall system responsiveness.

This commit **introduces new API endpoints** to the **public JSON API** within the `dashboard/app` module. It **adds support for Dungeon-related page types**, specifically `uiDungeonPage`, `uiDungeonPlayer`, and `uiDungeonKingdom`, by extending the `GetJSONDescrFor` function. This **new feature** enables the dashboard to fetch and display comprehensive data for various Dungeon entities. The change significantly expands the information accessible through the public API, allowing for richer data presentation related to the Dungeon subsystem.

This commit **introduces a new feature** by adding a conditional link to "Syzkaller Dungeon" within the **dashboard's footer template**. Specifically, the `templates.html` file is updated to include this navigation option, enhancing the **dashboard UI**. This change provides users with direct access to an external resource, improving discoverability and integration from the main application interface. The link's conditional rendering ensures it appears only when relevant, contributing to a cleaner user experience.

This commit introduces **unit tests** for the **AI coverage exploration tools** within `pkg/aflow/tool/syzlang`. It adds a `NewTestContext` helper in `pkg/aflow/test_util.go` to facilitate local testing by mocking the `aflow.Cache` and `aflow.Context`, removing the need for real LLM workflows. Comprehensive tests in `pkg/aflow/tool/syzlang/coverage_test.go` now validate the `getCoverageFiles` and `getFileCoverage` functions. These tests ensure correct formatting, snippet padding, right-aligned line spacing, and binary-search deduplication logic for coverage extraction. This significantly improves the testability and reliability of the AI agent's coverage processing.

This commit **updates the `GEMINI.md` documentation** to enhance development guidelines for Gemini-related work. It introduces new instructions for contributors, emphasizing the importance of **preferring `require.Equal()`** for assertions within test suites and consistently **running the linter** to maintain code quality. This **documentation update** serves as a maintenance task, aiming to standardize testing practices and improve overall code consistency for the project.

This commit **updates the documentation** for the `pkg/aflow` package by adding definitions for several **new state variables** to the `GEMINI.md` file. It introduces explanations for variables such as `PatchDiff`, `Explanation`, `Confident`, `Benign`, `Actionable`, `Recipients`, `SyzkallerCommit`, `Reproduced`, and `ReproducedCrashReport`. This **documentation update** ensures that the `aflow` module's internal state representation, particularly within the GEMINI system, is accurately described and understood by developers. The change improves the overall clarity and maintainability of the project's documentation by synchronizing it with the evolving system state.

This commit introduces a **new capability** to **improve the readability** of LLM-generated textual explanations within the `pkg/aflow/flow/assessment` module. It adds a `formatExplanation` action, implemented in `pkg/aflow/flow/assessment/actions.go`, which word-wraps these explanations to an 80-column width. This **enhancement** is integrated into both the **KCSAN assessment** and **bug moderation workflows**, as seen in `kcsan.go` and `moderation.go`, ensuring their outputs are consistently formatted. The change significantly **improves the presentation** of these detailed analyses in automated reports and dashboards, preventing overly long lines and making them easier to consume.

This commit introduces **automatic word-wrapping** for LLM-generated patch descriptions within the **patching flow** (`pkg/aflow/flow/patching`). It addresses the issue of inconsistent line lengths by adding a new `formatDescription` action that reflows the text to a strict 72-character limit, aligning with Linux kernel conventions. This **enhancement** improves the quality and compatibility of generated commit messages, and also removes the redundant word-wrapping instruction from the LLM prompt. The change ensures all generated patch descriptions meet professional formatting standards.

This commit introduces a **new `WordWrap` utility function** within the **`pkg/email` module**, designed to intelligently reflow text and prevent excessively long lines, particularly from LLM-generated content. This **new capability** merges consecutive lines with consistent indentation into reflowed paragraphs, while carefully preserving existing newlines, leading indentation, and handling visual line lengths, including tab expansion. The `WordWrap` function ensures improved readability by preventing single words from splitting and maintaining original spacing, providing a robust solution for various text formatting needs. Comprehensive **unit tests** for `WordWrap` are included to validate its behavior across diverse text structures.

This commit **fixes a bug** in the `pkg/gce` module by correcting the project ID used for instance information retrieval. Specifically, the `NewContext` function in `pkg/gce/gce.go` is modified to pass the **local project ID** to the `Instances.Get()` call, rather than a custom one. This **resolves an issue** where the local IP address of GCE instances could not be obtained correctly, ensuring reliable GCE instance management and data fetching. The change restores proper functionality for identifying and interacting with local GCE resources.

This commit **refactors** the `pkg/gce` module by extracting the logic for determining the **local GCE zone ID** into a new, dedicated function, `localZone`. This ensures the zone ID is consistently passed to `ctx.computeService.Instances.Get()`, restoring previous behavior within the GCE context initialization. Additionally, the `getMeta` function is enhanced to allow injection of the metadata URL, significantly **improving testability** of GCE metadata interactions. This **refactoring** simplifies the `NewContext` function and is supported by new unit tests in `pkg/gce/gce_test.go`.

This commit introduces a **new capability** for **Syzkaller's GCE VM driver**, enabling users to specify a custom GCP project for creating instances. A `ProjectID` field has been added to the **GCE VM configuration** (`vm/gce/gce.go`), allowing instances to be provisioned in a project different from where the syz-manager is running. The core `pkg/gce.NewContext` function was modified to accept this custom project ID, unifying its handling with existing custom zone ID logic. This enhancement significantly improves the flexibility of **GCE instance provisioning** by allowing cross-project resource management.

This commit **introduces new capabilities** for **GCE VM provisioning**, allowing users to specify `nic_type` and enable `nested_virtualization` during instance creation. The changes in `pkg/gce/gce.go` and `vm/gce/gce.go` update the `CreateInstance` and `Create` functions to pass these configurations to the Google Cloud Compute API. This **feature enhancement** enables syzkaller to utilize specific NIC architectures (e.g., GVNIC) and leverage hardware-assisted virtualization, significantly improving the flexibility and performance of its GCE-based test environments.

This commit **updates the `aflow` package documentation** by adding a new section to `GEMINI.md`. It **documents state variable naming conventions** specifically for **actions and workflows**, providing clear guidelines for developers. This **documentation update** serves as a **maintenance task** to standardize development practices. The primary impact is to make it **easier to write new actions and tools** within the `aflow` system, improving consistency and reducing onboarding friction for contributors.

This commit **adds comprehensive unit tests** for the **Syzkaller Dungeon game logic**, covering both the core mechanics in `pkg/dungeon` and the dashboard-specific processing in `dashboard/app`. These new tests validate intricate aspects such as XP distribution, linear/legendary leveling formulas, cosmetic badge evaluations based on vulnerability strings and fix counts, and RPG profile stat scaling. Furthermore, they ensure the correctness of player identity resolution, kingdom aggregation bounds, and naming logic. This **enhances the reliability and correctness** of the Dungeon feature by thoroughly validating its complex calculations and aggregations.

This commit **updates the local UI test configuration** for the **dashboard application**, specifically modifying `dashboard/app/local_ui_test.go`. It changes the default namespace and URL path used in tests from `linux` to `upstream`, aligning with the actual default dashboard namespace. This **test maintenance** ensures the test environment accurately reflects the production setup, preventing discrepancies caused by outdated namespace assumptions. The change improves the **reliability and accuracy of local UI tests** by using the canonical `/upstream` path.

This commit introduces a **new capability** by adding a `syzlang-format` action within the `pkg/aflow/action/actionsyzlang` module. This action ensures proper formatting of **syzkaller programs** by deserializing and then serializing them, with comprehensive unit tests covering various inputs. The new formatting logic is integrated into the **crash reproducer flow** in `pkg/aflow/flow/repro/repro.go`, which will now process programs through this formatter to maintain consistency. Additionally, a minor **maintenance** change renames the `ReproSyz` field to `CandidateReproSyz` in LLM outputs to better reflect its purpose. This enhancement improves the quality and readability of generated syzkaller programs within the reproducer subsystem.

This commit introduces a **new feature** within the `pkg/aflow` package by modifying the **LLM agent's output definition** in `repro.go`. The agent will now explicitly return a **syzkaller program** via a new `ReproSyz` field, replacing the previous generic `Reply` field. This structural change enforces a specific format for the program output, directly addressing issues with malformed or unstructured responses from the LLM. By ensuring a well-defined output, the reliability and downstream processing of the LLM agent's fuzzing-related contributions are significantly enhanced.

This commit introduces a **new capability** to the **`prog` module's argument parser**, enabling it to correctly interpret integer arguments specified in **decimal and octal formats**. Previously, the parser in `prog/encoding.go` only recognized hexadecimal integer arguments (e.g., `0x...`); now, the `parseArgImpl` function routes any leading digit to the integer parsing logic, leveraging `strconv.ParseUint` for robust base-10 handling. This enhancement significantly improves the flexibility and usability of program argument input, with corresponding **documentation updates** in `docs/program_syntax.md` and new **test cases** to ensure correct deserialization.

This commit **updates the documentation** for the **`pkg/aflow`** module by adding a new section to `GEMINI.md`. It provides **essential guidelines for implementing tools**, covering naming conventions, state parameter declaration, and proper tool registration practices. This **documentation enhancement** aims to standardize tool development within the `aflow` framework, improving developer consistency and reducing potential implementation errors. The changes clarify best practices for future tool contributions and maintenance, directly addressing the need for structured guidance.