Ben Blackburne

This commit **fixes** an issue in the **`apple_static_archive`** rule where it would incorrectly attempt to link shared libraries (dylibs) into a static archive. Previously, targets with `preferred_linkage = "shared"` could be passed to `apple_static_archive`, leading to `libtool` trying to process dylibs during static archive creation. The **linking logic** in `prelude/apple/apple_static_archive.bzl` has been updated, specifically within `_get_static_link_args`, to use `unpack_link_args_object_files_and_lazy_archives_only`. This ensures that only object files and lazy archives are considered for static linking, preventing shared libraries from being included. This change improves the correctness and efficiency of **Apple static archive builds** by eliminating erroneous linking attempts.

This commit introduces a **new capability** to the **`prelude/cxx` link group management system** by implementing the **`MATCH_DIRECT_DEPS`** strategy. This new linking mechanism allows precompiled dynamic libraries, such as **Xcframeworks**, to be included only in link groups that contain targets which directly depend on them. Previously, such libraries were either included everywhere (`MATCH_ALL`) or nowhere (`MATCH_NONE`), leading to unnecessary duplication or complex dependency pinning. This change, primarily in `link_groups.bzl` and `groups_types.bzl`, simplifies the management of dynamic dependencies and optimizes binary size by ensuring libraries are linked only where truly needed.

This commit **refactors** the **Apple build rules** by modifying the internal implementation of the `prebuilt_apple_xcframework` macro in `prelude/apple/prebuilt_apple_xcframework_macro_impl.bzl`. Previously, this macro generated an `alias` to a set of platform-specific `prebuilt_apple_framework` targets. Now, it directly creates a single `prebuilt_apple_framework` target that uses `selects` to dynamically choose the correct framework and dSYM paths based on the build configuration. This **internal improvement** simplifies the build graph and allows downstream targets to link against the `prebuilt_apple_framework` using its user-provided name, enhancing clarity and consistency.

This commit **refactors** the handling of the `emit-module.dia` diagnostics file within **Swift incremental builds** to correctly account for **Xbat builds**. Previously, the build system incorrectly assumed this file was always emitted for incremental builds, leading to attempts to track non-existent artifacts in scenarios like **Xbat builds**. The logic for declaring and tracking `emit-module.dia` is now moved from `swift_incremental_support.bzl` into the `add_serialized_diagnostics_output` function in `swift_output_file_map.bzl`. This ensures the file is only added to the output map and tracked as an artifact when it is actually generated, improving the reliability of **remote artifact handling** and preventing build failures.

This commit **fixes a logical error** within the **Swift incremental build system** by ensuring that `swift_incremental_file_hashing` is only active when the overall incremental Swift build mode is also enabled. It modifies the `get_incremental_file_hashing_enabled` function in `prelude/apple/swift/swift_incremental_support.bzl` to correctly gate hashing on the incremental build state. This **bug fix** addresses broken tests and prevents incorrect build behavior that arose when incremental hashing was applied without the corresponding incremental build mode. The change **improves the stability and correctness of Swift builds** by aligning the hashing mechanism with the intended incremental build strategy.

This commit **refactors** the **Swift compilation logic** to **optimize performance** for **Swift incremental builds**. It specifically modifies the `_get_action_properties` function within `prelude/apple/swift/swift_compilation.bzl` to **adjust the `prefer_local` settings** for these builds. This **performance optimization** empirically improves the speed of incremental builds by favoring local execution, even when remote execution (RE) actions are enabled. The change impacts the build system's efficiency for **Swift projects**, ensuring faster iteration times for developers by prioritizing local execution for incremental changes.

This commit introduces a **new feature** by adding the `apple.swift_incremental_logging_enabled` Buck configuration option, enabling detailed logging for **Swift incremental compilation**. This enhancement to the **Apple build rules** provides crucial visibility into the compilation process, outputting messages to stderr that indicate what was compiled and what was skipped. Specifically, it adds a `swift_incremental_logging_attrs` attribute to the `apple_library` rule and integrates conditional flag generation in `swift_incremental_support.bzl` based on the new buckconfig. This capability is essential for **testing and debugging** the effectiveness of incremental compilation for Swift targets.

This commit **refactors** the **Swift incremental compilation** process to prevent absolute paths from being embedded in generated `swiftmodule` files. It modifies the `_get_incremental_compilation_flags_and_objects` function in `prelude/apple/swift/swift_incremental_support.bzl` to include `-working-directory .` and reorder `-avoid-emit-module-source-info`. This **maintenance** change eliminates "cache-busting" absolute paths, thereby improving the cacheability of `swiftmodule` artifacts and simplifying debugging efforts. The full benefit of this change is dependent on a future Pika release.

This commit introduces a **new capability** to the `swift_exec.py` wrapper tool by adding the `--no-file-prefix-map` command-line argument. This option allows **disabling the application of file prefix and coverage prefix maps** during Swift compilation, addressing a critical issue in **Swift Incremental builds**. The problem arose because `--file-prefix-map` could lead to unstable build arguments in non-local environments due to varying file paths across machines. This **maintenance improvement** ensures more consistent and reliable incremental compilation, particularly for **WA incremental builds**, by preventing argument changes from run to run.

This commit introduces **support for tracking `.swiftdoc` artifacts** generated during Swift compilation within Buck2, which were previously untracked. This **new capability** primarily affects the **incremental build process** for Swift modules, ensuring these files are properly declared and passed as incremental inputs. By tracking `.swiftdoc` files, the system improves the reliability of remote execution actions and overall build correctness, preventing silent omissions of critical artifacts. The implementation leverages the convention that the compiler emits `.swiftdoc` files alongside `.swiftmodule` files, addressing limitations with `output-file-maps` in incremental mode.

This commit **disables the emission of depsfiles** for **Swift incremental builds** when using remote execution and incremental file hashing. This **maintenance fix** addresses an incompatibility where depsfiles contain absolute paths, which breaks hermeticity and prevents correct incremental behavior in remote environments. By modifying `prelude/apple/swift/swift_compilation.bzl` and `prelude/apple/swift/swift_incremental_support.bzl`, the change ensures that **Swift builds with remote execution remain functional and hermetic**, albeit without depsfile generation, until the absolute path issue can be fully resolved.

This commit introduces a **performance optimization** to the **Swift execution tool** (`prelude/apple/tools/swift_exec.py`) by conditionally managing file writability. The `_make_path_user_writable` function has been **refactored** to only make paths writable when the `in_remote_execution` variable is true, indicating operation within a **remote execution worker context**. This change prevents unnecessary and performance-degrading file permission modifications on **local development machines**, addressing identified slowdowns. The **maintenance** work ensures efficient resource usage for local builds while preserving correct behavior for remote execution.

This commit **disables** the `--file-prefix-map` flag for **Swift incremental compilation** when file-hashing is enabled, resolving issues where changing paths in remote build environments could lead to inconsistent arguments. To prevent absolute paths from being embedded in DWARF data for compiler-generated Swift code due to this change, it also **enforces DWARF version 5** by adding `-dwarf-version=5` to the compilation flags. This ensures that generated source code, particularly from Swift Macros, is embedded inline within the DWARF data, maintaining **correct debug information** without relying on potentially unstable file paths. This is a **maintenance update** to the **Swift build system**'s debug information generation and remote compilation logic, primarily affecting `prelude/apple/swift/swift_incremental_support.bzl`.

This commit introduces a **build system fix** to enhance the reliability of **Swift incremental compilation** within Buck2. It modifies the `prelude/apple/swift/swift_incremental_support.bzl` rule to **disable the emission of `.swiftsourceinfo` files** during incremental builds. These files, which contain absolute paths and are not tracked by Buck2, were causing issues with incremental inputs in remote execution actions. By adding a flag to the Swift compiler wrapper via `_get_incremental_compilation_flags_and_objects`, this change ensures that **incremental Swift builds function correctly** by preventing the generation of problematic untracked outputs.

This commit **enhances Buck2's Swift compilation support** by **tracking the `emit-module.dia` file**, a critical diagnostic output for **incremental Swift builds**. This **feature enhancement** ensures that this generated file is correctly recognized and available as an input for remote execution actions, addressing a gap where untracked files could lead to incorrect incremental inputs. It modifies `prelude/apple/swift/swift_incremental_support.bzl` to declare and add the artifact to the output file map, and `prelude/apple/tools/swift_exec.py` to include `emit-module-diagnostics` in recognized output types, thereby improving the reliability of **incremental Swift builds**.

This commit **restores** the critical functionality of **incremental remote outputs** for **Swift compilation** within the **Apple build prelude**. It **fixes a regression** by explicitly re-enabling the `incremental_remote_outputs` parameter in the `_compile_with_argsfile` function, located in `prelude/apple/swift/swift_compilation.bzl`. This ensures that previously generated incremental outputs are correctly leveraged as inputs in **Remote Execution (RE) actions**, significantly improving build performance and efficiency for Swift projects.

This commit introduces a **bug fix** within the **`prelude/apple/tools/swift_exec.py`** module to address a persistent path permissions issue. The `_make_path_user_writable` function is modified to robustly handle read-only inputs by recreating files via a backup and copy operation before setting permissions. This change specifically resolves problems where "outputs-as-inputs" cannot be directly marked writable, ensuring that **Swift execution tools** can correctly process such files. The fix restores critical logic to prevent failures and maintain the integrity of build processes involving Apple-specific Swift operations.

This commit introduces a **new capability** to the `codesign_bundle` tool by adding the `--only-select-provisioning-profile` command-line option. This enhancement to the **Apple code signing utility** in `prelude/apple/tools/code_signing/main.py` allows the tool to **select and print a provisioning profile** without performing the actual code signing operation. This provides greater flexibility, enabling external systems like Orchard to reuse the profile selection logic independently. It serves as a preparatory step to decouple profile selection from the full signing process, making the utility's components more modular.

This commit introduces a **new feature** to the **Apple code signing tools**, specifically within `codesign_bundle`, by adding a `--no-check-certificates` option. This option allows users to **skip the validation of developer certificates** during the provisioning profile selection process. The change affects `prelude/apple/tools/code_signing/codesign_bundle.py`, `prelude/apple/tools/code_signing/main.py`, and `prelude/apple/tools/code_signing/provisioning_profile_selection.py`, modifying functions like `select_best_provisioning_profile` to conditionally bypass certificate checks. This enhancement is crucial for enabling the reuse of this code in environments like **CI systems** (e.g., Orchard) where enterprise certificates may not be installed, thus improving the flexibility and automation capabilities of the signing process.

This commit **fixes a critical bug** in **Buck's Swift compilation** that prevented `swiftinterface` generation for prebuilt third-party frameworks with inter-dependencies. It **enhances** the `compile_swiftinterface_common` function to correctly include `swiftinterfaces` from transitive third-party Swift dependencies, resolving `import` failures. Specifically, it ensures that `SwiftDependencyInfo` containing compiled Swift modules is passed to the `swiftinterface` compilation action for **prebuilt Apple frameworks**. This change enables proper module resolution and successful compilation for complex Swift projects utilizing multiple prebuilt third-party frameworks.