Bin Huang

This commit introduces a **new capability** to the **`INPUT_POWER_TYPE` feature**, enabling **automatic detection of the switch's input power type (AC or DC)**. It extends the **`SensorServiceImpl`** to dynamically apply appropriate voltage thresholds to input voltage sensors that lack explicit configuration, using configurable AC/DC voltage ranges defined in the **`PowerConfig`** Thrift struct. This **refactoring** and enhancement improves the robustness of sensor monitoring by ensuring all input voltage sensors have relevant thresholds, with defaults provided for both 12V/48V DC and 90-305V AC systems. The change also involved updating `sensor_config.thrift` and refactoring the `processInputVoltage` function and associated tests.

This commit **fixes a test failure** within the **`fan_service` control logic tests** by modifying how configuration is loaded. Specifically, `ControlLogicTests.cpp` now utilizes `ConfigLib().getFanServiceConfig()` to retrieve the `fan_service` configuration from compiled-in resources, rather than relying on a hardcoded filesystem path that caused failures in deployed environments. This **test maintenance** ensures the `fan_service` tests are robust and execute correctly regardless of the `fbcode` tree's presence. The change also includes necessary **build system updates** in `cmake/PlatformFanService.cmake` and `BUCK` to link against `platform_config_lib`.

This commit performs significant **code cleanup** within the **`rackmon`** module by **removing various pieces of dead and obsolete code**. It eliminates unused `from_json` declarations in `Register.h`, the redundant `Rackmon::getRawData()` wrapper, and the unused `setBaudEnabled_` field from `ModbusDevice`. Additionally, obsolete `#ifdef PROFILING` branches are removed from `Log.h`, and compatibility shims for `experimental/filesystem` are purged from `Rackmon.cpp`, `RegisterMapTest.cpp`, and `TempDir.h`, as they targeted long-obsolete compiler versions. This **refactoring** improves code maintainability and reduces the codebase size without altering any functional behavior.

This commit performs **code cleanup** by **removing dead code** from the **FBOSS platform firmware utility component**. Specifically, it **removes three unused method declarations** (`storeFlashromConfig`, `performReadOperation`, and `performUpgradeOperation`) from the `FwUtilImpl.h` header file. This **maintenance** task improves the codebase's clarity and reduces technical debt within the `fboss/platform/fw_util` module, with no functional impact on the system as the methods were already unused.

This commit performs a **code cleanup** and **refactoring** by **removing dead code** from the **`fboss/platform/weutil`** component. It eliminates the unused `FIELD_DATE` enum value from `EepromFieldType` within `FbossEepromInterface.h`. Additionally, the unused `printData()` method declaration and definition are removed from `Prefdl.h` and `Prefdl.cpp`, along with an now-unnecessary `iostream` include. This effort improves code maintainability and reduces the codebase's footprint without introducing any functional changes or regressions.

This commit performs **code cleanup** within the **`fan_service`** module by removing several pieces of **dead or unused code**. Specifically, it eliminates an orphaned `getRpcOptions()` declaration, an unused `folly/coro/BlockingWait.h` include, and a redundant `FsdbPubSubManager` forward declaration from `FsdbSensorSubscriber.h`. Additionally, an unused `std::ifstream` variable and its corresponding include are removed from `Bsp.cpp`'s `readSysfs()` function, along with the `qsfpSvcThriftPort_` private field from `Bsp.h`. This **maintenance** work improves code clarity and reduces unnecessary dependencies without altering any functionality. The changes primarily affect `Bsp.h`, `Bsp.cpp`, and `FsdbSensorSubscriber.h`.

This commit performs significant **code cleanup** and **refactoring** within the **`fboss/platform/sensor_service`** module by **removing various pieces of dead and unused code**. It eliminates unused gflags, constants like `kAsicTemp` and `kSensorSymlinkRegex`, unneeded variable declarations, and redundant forward declarations and header includes from files such as `Flags.h/cpp`, `SensorServiceImpl.h`, `ConfigValidator.cpp/h`, `FsdbSyncer.h`, `Utils.cpp`, and `oss/PmClientFactory.cpp`. This **maintenance** effort improves code hygiene, reduces compilation overhead, and streamlines the codebase without altering any functional behavior.

This commit performs **code cleanup** by **removing dead code** from the **`fboss/platform/helpers`** module. It specifically eliminates the unused constant `kCacheDir` from the `PlatformNameLib.h` file. This **maintenance** task improves code clarity and reduces the codebase's footprint, with **no functional impact** on the platform's helper utilities. The change ensures better maintainability by removing obsolete declarations.

This commit performs **code cleanup** within the **`fboss/platform/fixmyfboss`** utility by **removing dead code**. Specifically, it eliminates the unused `getStatusColor()` method declaration and definition from `ResultPrinter.h` and `ResultPrinter.cpp`, along with the associated `COLOR_YELLOW` and `BG_YELLOW` constants. This **maintenance** task improves code clarity and reduces the codebase's footprint without altering any functional behavior of the `ResultPrinter` or the `fixmyfboss` platform.

This commit performs **maintenance** by **increasing the maximum allowed setup time** for platform exploration within the `PlatformExplorer` module. This change specifically addresses **test flakiness** observed on platforms such as Meru800 and Morgan800CC, where the setup process could exceed the previous 49-second threshold. It updates the default maximum setup time and introduces new platform-specific constants in `fboss/platform/platform_manager/PlatformExplorer.h`. Concurrently, `fboss/platform/platform_manager/hw_test/PlatformManagerHwTest.cpp` is updated to utilize these new platform-specific thresholds in its assertion logic, ensuring more robust and reliable hardware tests for platform exploration.

This commit **enhances test coverage** for the **FbossEepromInterfaceTest** by adding new assertions to the V5 and V6 EEPROM test cases. It specifically validates the individual getter methods responsible for extracting key product information, such as product name, part number, serial number, and production state, from the parsed EEPROM data. This **improves the robustness** of the platform's EEPROM parsing logic by ensuring that these accessor methods correctly return expected values, thereby preventing potential issues with hardware identification and inventory.

This commit introduces a **new capability** to the **Sensor Service** by adding an `INPUT_POWER_TYPE` ODS counter. This enables **monitoring of AC vs DC power input** at the chassis level, providing crucial data for power infrastructure management. The power type is semantically derived within the `processInputVoltage` function, classifying input voltages >= 60V as AC and lower voltages as DC. This enhancement provides valuable information for **power infrastructure monitoring and debugging**.

This commit significantly **refactors and enhances the EEPROM interface tests** located in `fboss/platform/weutil/test/FbossEepromInterfaceTest.cpp`. It addresses a **test infrastructure issue** by implementing a test fixture for robust temporary directory lifetime management, ensuring proper cleanup. To improve **test code maintainability**, a `CommonEepromFields` struct and `verifyCommonEepromFields()` helper function were introduced, reducing assertion duplication across tests. Additionally, the tests now include version verification via `getVersion()` and feature simplified assertions, resulting in more reliable and readable **EEPROM interface tests**.

This commit **reverts** the previous addition of a buffer constructor to `FbossEepromInterface`, favoring a more effective **file-based testing strategy** using `folly::test::TemporaryDirectory` for unit-level validation over hardware-dependent tests. It significantly **refactors** the **`weutil` subsystem** by replacing Boost string algorithms with `std::transform` for uppercase conversion in `createWeUtilIntf`, thereby **removing the Boost dependency**. The **EEPROM interface tests** in `FbossEepromInterfaceTest.cpp` are updated to align with this file-based approach, eliminating buffer-based constructor tests. This **dependency reduction** and **test improvement** also involves updating `cmake/PlatformWeutil.cmake` and `fboss/platform/weutil/test/BUCK` to remove `Boost` and `fmt` library linkages.

This commit introduces a **new capability** to the **`FbossEepromInterface`** within the `fboss/platform/weutil` subsystem by adding a constructor that accepts raw EEPROM data as a `std::vector<uint8_t>`. This change significantly **improves the unit testability** of EEPROM parsing logic, allowing tests to run entirely in memory without relying on temporary files or file I/O. As a result, the **`FbossEepromInterfaceTest`** suite has been **refactored** to utilize this new constructor, enhancing test reliability, isolation, and robustness, including new tests for invalid data. Additionally, shared initialization logic was extracted into `initFromBuffer()`, and build configurations were updated for new dependencies.

This commit **updates the platform testing requirements documentation** by clarifying the applicability of the **Buttons firmware test**. It explicitly states that this test is required for hardware platforms where buttons are controlled through **programmable hardware** such as CPLDs or FPGAs. This **documentation update** improves understanding for hardware partners, ensuring they correctly identify when to perform button testing based on their platform's programmable hardware configuration. The change is localized to the `docs/docs/platform/platform_testing_requirements.md` file.

This commit performs **maintenance** on the build system by integrating the `PlatformManagerHandlerTest` into the **Open Source Software (OSS) CMake build configuration**. Previously, this critical test was omitted, preventing its execution in OSS environments. By modifying `cmake/PlatformPlatformManagerTest.cmake`, the commit ensures that the `platform_manager_handler_test` executable is properly built, linked, and discovered as part of the `fboss_platform_services` target. This change significantly improves **test coverage and quality assurance** for the platform services component within OSS builds.

This commit **integrates a new test file**, `PmUnitInfoFetcherTest.cpp`, into the **open-source build system** for the **Platform Sensor Service**. It modifies the `cmake/PlatformSensorServiceTest.cmake` configuration to include this test as part of the `sensor_service_sw_test` executable. This **maintenance** change ensures that the `PmUnitInfoFetcher` component of the sensor service has its dedicated tests compiled and executed in the OSS environment. By **extending test coverage**, this improves the overall **reliability and robustness** of the **Platform Sensor Service**.

This commit significantly enhances the **test coverage** for the **sensor service** by introducing comprehensive **unit tests** for the `PmUnitInfoFetcher` component. The new tests validate critical aspects such as version extraction logic, error handling for `PlatformManagerError` exceptions, and request/response type validation. To enable effective mocking and testing, the `PmClientFactory` class was **refactored** to make its `create()` method and destructor **virtual**. This work improves the **robustness** and maintainability of the platform information fetching subsystem within the sensor service.

This commit **introduces new unit tests** for the `PlatformManagerHandler`, significantly improving the **test coverage** of the **Platform Manager** subsystem. These tests specifically target the **Thrift API handler methods** such as `getPmUnitInfo`, `getAllPmUnits`, and `getEepromContents`, which were previously untested. The addition of `PlatformManagerHandlerTest.cpp` and its corresponding `cpp_unittest` target in `BUCK` enhances **code quality** and provides crucial **regression protection** for these critical data retrieval functionalities within the platform management stack. This ensures the reliability and correctness of the platform's reported unit and EEPROM information.