Ben Villalobos

This commit performs a **maintenance merge** of the `main` branch into the `isidorn/nursing-marlin` feature branch, integrating a wide array of recent updates. It incorporates changes across core **UI components** like trees and hover widgets, various **platform services** (e.g., actions, environment, keybindings), and the **Git extension**. Most significantly, this merge updates numerous files within the **`sessions`** and **`chat`** subsystems, affecting agent feedback, changes views, chat contributions, prompt handling, and related API definitions. This broad integration ensures the feature branch is synchronized with the latest development, particularly in areas related to **AI-powered features** and their underlying infrastructure.

This commit introduces a **workflow configuration update** within the **CI/CD system**, specifically modifying `.github/workflows/no-engineering-system-changes.yml`. As a **chore**, it now explicitly **allows the `vs-code-engineering[bot]` to update only the `distro` field in `package.json`**. This change creates an exception to existing engineering system change restrictions, streamlining automated updates related to distribution metadata. It ensures that bot-driven modifications to this specific field can proceed without triggering workflow failures, enhancing the efficiency of repository automation.

This commit performs **maintenance** by updating the project's reference to the **distro commit** on the `main` branch. This action ensures that the project is built and tested against the latest specified version of its distribution or a core dependency. The update helps to keep the project aligned with upstream changes, potentially incorporating bug fixes or minor improvements from the referenced distribution, and is a routine part of dependency management.

This commit introduces new **documentation** to guide the **Copilot review process** for **Open Source Software (OSS) license files**. Specifically, it adds instructions to `.github/instructions/oss.instructions.md` detailing how to conduct these reviews. This **maintenance** update aims to standardize and clarify the procedures for handling OSS licenses, ensuring consistent compliance and proper usage across the project.

Bump vscode engine to 1.111 (#4195)

This commit performs a general **maintenance update** to the project's underlying **distribution**. It ensures that the build and runtime environments are based on the latest stable or secure versions, addressing potential vulnerabilities or improving compatibility with newer system components. This update primarily impacts the **project's dependencies** and **build infrastructure**, contributing to overall system stability and security. The change does not introduce new features or fix specific application bugs, but rather updates the foundational software stack.

This commit performs a **maintenance** task by **bumping the project's minor version** from its previous state to `1.111`. This update primarily affects the **project's versioning metadata** and **release cycle**, signifying a new development milestone or release candidate. It prepares the entire **codebase** for subsequent feature integrations or bug fixes, impacting how the project is identified and managed in future deployments.

0.39.0 (#4057)

This commit performs a **maintenance** update to the **CLI**'s open-source compliance documentation. It adds new third-party license notices for several crates, including `serde_spanned`, `toml` and its related components, `winnow`, and `winresource` to `cli/ThirdPartyNotices.txt`. This ensures the project's **legal compliance** by accurately reflecting all third-party dependencies for the upcoming 1.110 release, generated by the OSS tool.

This commit **reverts a previous dependency upgrade**, specifically undoing the bump of the **`hono` library** from version `4.12.0` to `4.12.3`. This **maintenance revert** affects the dependencies within the **`/test/mcp` directory**, ensuring that the `hono` version remains at its prior stable state. The action suggests that the upgraded version might have introduced compatibility issues or was not ready for integration into this specific test environment. As a result, the test environment will continue to use `hono` `4.12.0`, preventing any potential regressions from the newer version.

Revert "Bump minimatch (#4051)" (#4053)

This commit **updates the project timeline** for the **endgame notebook**, adjusting its target milestone to **February 2026**. This is an **administrative update** reflecting a revised schedule or planning for the completion of this significant documentation or analysis artifact. The change primarily impacts **project planning and expectations** regarding the delivery of the `endgame notebook` feature or report, signaling a revised completion date.

This commit **refactors test dependencies** within the **Copilot extension's review module** to address a `tsfmt` issue. It introduces a dedicated interface for managing mock dependencies in `extensions/copilot/src/extension/review/node/test/doReview.spec.ts`, specifically for `handleReviewResult` tests, improving test clarity and maintainability. This **maintenance fix** enhances the robustness and readability of the **Copilot review feature's unit tests**, making them easier to manage and debug.

This commit **fixes** the definition of the **accessibility skill** by **renaming** its metadata file, `SKILL.md`, and **updating its internal name and description**. This **maintenance fix** ensures the skill's documentation accurately reflects its purpose and identity within the `.github/skills` directory. The change improves the clarity and discoverability of the **accessibility skill** for anyone interacting with the project's skill definitions.

This commit performs a **major refactoring** of the **Copilot extension's code review logic**, primarily affecting `githubReviewAgent.ts` and `doReview.ts`. It extracts complex, nested conditional logic from the `githubReview` function into dedicated helper functions like `collectChanges()` for various change collection strategies, and breaks down the `ReviewSession.review` method into smaller, more focused private methods. This **pure refactoring** significantly enhances the **maintainability and readability** of the core review codebase, improving type safety and ensuring **no behavioral changes** to existing functionality. The changes are thoroughly validated by extensive new **unit tests** added for the refactored components.

This commit significantly **increases code coverage** for the **Copilot code review agent**, addressing issue #3396. It **adds comprehensive unit and integration tests** for critical functions within `extensions/copilot/src/extension/review/node/githubReviewAgent.ts`, covering parsing, patching, comment creation, and custom instruction loading, alongside new tests for `combineCancellationTokens` in `extensions/copilot/src/extension/review/node/doReview.ts`. To facilitate this extensive testing, several internal utilities like `parsePatch` and `combineCancellationTokens` were **refactored for testability** by being exported. This work enhances the **robustness and reliability** of the code review subsystem by ensuring better validation of its core logic.

This **maintenance** commit **removes the dedicated engineering agent** from the system, streamlining the overall agent architecture. It primarily involves **refactoring** the **AI prompt system** by updating references within `.github/prompts/` files, including `find-duplicates.prompt.md`, `find-issue.prompt.md`, and `issue-grouping.prompt.md`. Agent references are consistently changed from `'Engineering'` to a more generic `'agent'`, and the prompt retrieval method is adjusted in relevant files. This ensures that prompts correctly interact with the updated agent infrastructure following the removal of the specialized engineering agent.

This commit significantly **enhances test coverage** for the **Copilot extension's feedback generation capabilities**. A comprehensive test suite is introduced for the `FeedbackGenerator` module, specifically targeting `parseFeedbackResponse`, `parseReviewComments`, `generateComments`, and `sendReviewActionTelemetry` functions, covering various edge cases and mock service interactions. This **test coverage improvement** also involved **refactoring existing test suites** and simplifying mock services for better maintainability. The work ensures the robustness and correctness of user feedback processing and telemetry within the **Copilot extension**.

This commit performs **maintenance** by **adding descriptive metadata** to the **GitHub Actions prompt files** for `/find-issue` and `/find-duplicates`. Specifically, it updates `.github/prompts/find-duplicates.prompt.md` and `.github/prompts/find-issue.prompt.md` with additional context. This change enhances the clarity and understanding of these automated prompts, improving the overall **documentation** and usability of the associated workflows.

This commit **rewrites and simplifies** the instructions for the **`/find-issue` prompt**, located at `.github/prompts/find-issue.prompt.md`. The work involves a **complete restructuring of content** to enhance clarity and ease of understanding for this internal prompt. This **documentation update** aims to improve the effectiveness and user experience of the issue-finding mechanism by providing more concise and straightforward guidance.