Eric Boren

This commit performs **infrastructure maintenance** by updating the **Mac build configurations** to utilize new **Mac Mini M4 Pro machines**. It semantically changes the default Mac model identifier from `Mac16,10` to `Mac16,11` within the `infra/bots/gen_tasks_logic/gen_tasks_logic.go` file's `defaultSwarmDimensions` and across various task definitions in `infra/bots/tasks.json`. This **infrastructure upgrade** ensures that Mac-related tasks are scheduled on the updated hardware, potentially improving build performance and capacity for the **Skia infrastructure**.

This commit performs a **roll of Skia Infra**, updating its internal dependencies to a newer revision and incorporating various upstream changes. It includes a significant **refactoring** within the `infra/bots` module to standardize **CIPD package management** for the build system. New helper functions, such as `getCIPDPackage` and `setPkgPaths`, are introduced to ensure consistent assignment of CIPD package paths, which are then utilized by task generation functions like `kitchenTaskNoBundle`, `usesGit`, and `usesPython`. This **maintenance and improvement** effort enhances the robustness and maintainability of dependency handling across the Skia build infrastructure.

This commit **updates the Skia infrastructure** to **add support for the GalaxyS25+** Android device. It integrates the new device by updating the `androidDeviceInfos` map in `infra/bots/gen_tasks_logic/gen_tasks_logic.go` and defining corresponding **new job and task configurations** in `infra/bots/jobs.json` and `infra/bots/tasks.json`. This **infrastructure update** enables the continuous integration system to **build, test, and monitor Skia on the GalaxyS25+**, expanding the project's hardware coverage for Android platforms.

This commit **removes a specific Vulkan GPU test job** from the **Continuous Quality (CQ) system** configuration due to persistent timeouts. Specifically, the `Test-Ubuntu24.04-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-Vulkan` entry is deleted from the `infra/bots/jobs.json` file. This **infrastructure maintenance** improves the reliability and efficiency of the automated testing pipeline by preventing merges from being blocked by a consistently failing test. The change affects the **Skia infrastructure**, temporarily reducing automated Vulkan test coverage on the QuadroP400 until the underlying timeout issue can be resolved.

This commit provides a **bug fix** for **iOS18 builds** by resolving an issue where the necessary provisioning profile was missing. It enhances the underlying provisioning logic to be more flexible, ensuring that builds for the latest iOS version can proceed without errors. This change specifically impacts the **infrastructure** responsible for compiling and signing iOS applications, preventing build failures and improving the reliability of the CI/CD pipeline for iOS development.

This commit updates the **iOS build infrastructure** to leverage an **upstream provisioning profile**. This **configuration change** is a **maintenance update** that directly impacts the **CI/CD pipeline** for iOS applications. By adopting the upstream profile, this commit resolves a **bug** (b/484075615) related to iOS provisioning, ensuring that **iOS builds** are correctly signed and can be deployed without issues, improving the reliability of the build process.

This commit **enhances the authentication for `nano` results uploads** by integrating `luci-auth` to acquire service account tokens. It modifies the `infra/bots/recipes/upload_nano_results.py` script to use the `service_account` module within its `RunSteps` function, passing the obtained token to `gcloud storage cp` for secure authentication. This **infrastructure improvement** affects both normal and trybot executions of the nano upload process, ensuring reliable and authenticated data transfer. Additionally, the `infra/bots/README.recipes.md` documentation is updated to reflect this new dependency and authentication flow.

This commit performs an **infrastructure update** by **updating the iOS provisioning profile** used within the Skia build system. It **bumps the version of the `skia/bots/provisioning_profile_ios` asset from 13 to 14**, reflected in `infra/bots/assets/provisioning_profile_ios/VERSION` and referenced across various task definitions in `infra/bots/tasks.json`. Furthermore, a **new capability** is introduced with the addition of `create.py` to `infra/bots/assets/provisioning_profile_ios/`, a Python script designed to **automatically fetch and create this provisioning profile asset via CIPD**. This change ensures that **Skia's iOS builds** utilize the most current provisioning profile and streamlines the process for future profile updates.

This commit **refactors** the **GCS mirroring infrastructure** within `bazel/gcs_mirror/gcs_mirror.go` to replace the reliance on the `gsutil` command-line tool with direct usage of the `cloud.google.com/go/storage` API for file uploads. This **infrastructure improvement** modernizes the upload mechanism, aiming for increased reliability and efficiency in mirroring operations. Specifically, the `processOneDownload` and `processOneLocalFile` functions now leverage a newly introduced internal `upload` helper, streamlining the GCS interaction. This change addresses an internal infrastructure bug (b/483982061) by adopting a more robust, Go-native approach for GCS interactions.

This commit performs an **infrastructure maintenance update** by modifying the **Skia bot job configurations** in `infra/bots/jobs.json`. Specifically, it updates the settings for **Windows P400 machines** to reflect their migration from Windows 10 to **Windows 11**. This ensures that all continuous integration and testing jobs running on these specific hardware configurations are correctly aligned with the new operating system, maintaining the integrity and reliability of the **Skia project's testing infrastructure**.

This commit performs an **infrastructure update** to correctly reflect the latest configuration for **Pixel10 devices** within the Skia bot system. Specifically, it updates the device OS build number for Pixel10 in the `androidDeviceInfos` map within `infra/bots/gen_tasks_logic/gen_tasks_logic.go`. Concurrently, the `device_os` dimension value for Pixel10 devices is updated across various tasks in the `infra/bots/tasks.json` configuration file. This **maintenance** ensures that the **Skia infrastructure** accurately recognizes and schedules tasks for these updated devices.

This commit **reverts** the previous integration of **M4 Mac Minis** into the build infrastructure, acting as a **bug fix** for **iOS build failures**. It restores the **build configuration** by undoing changes to `gen_tasks_logic.go` that defined M4 machine dimensions and adjusted Bazel usage. Additionally, it reverts the `create.py` and `download_mac_toolchain.bzl` scripts to use **universal Mac Clang assets** and toolchains. This ensures the stability of **iOS builds** by rolling back the changes that caused the failures, effectively removing M4 Mac Minis from the active build pool.

This commit **introduces comprehensive support for the new 'Corsola' ChromeOS device** within the Skia infrastructure. It's a **feature addition** that updates the **task generation logic** in `infra/bots/gen_tasks_logic/gen_tasks_logic.go` to include 'Corsola' in `defaultSwarmDimensions`. Furthermore, it defines new **performance and test job configurations** in `infra/bots/jobs.json` and specifies corresponding **performance and test tasks** in `infra/bots/tasks.json` for this device. This enables automated testing and performance monitoring for the 'Corsola' platform, significantly expanding the project's device coverage.

This commit **updates the Bazel build system dependencies** by bumping versions for `rules_go`, `rules_cc`, and `platforms` within `MODULE.bazel`. It also introduces new configuration to **inject the `go_sdk` and `rules_go` repositories**, ensuring these critical components are correctly sourced for builds. This **maintenance** change improves the **build environment's stability and compatibility**, particularly for Go-based modules, by using the latest recommended Bazel rules and SDK setup.

This commit performs a **critical maintenance update** of the **Bazelisk CIPD packages** across all supported platforms (Linux, macOS, Windows, for both AMD64 and ARM64 architectures). It updates Bazelisk to version 1.27.0 by modifying the `create.py` scripts and `VERSION` files within `infra/bots/assets/`, along with updating the referenced package versions in `infra/bots/tasks.json`. This **bug fix** addresses a regression where older Bazelisk versions failed to respect `.bazelversion` files when the `WORKSPACE` file was removed. The update is essential for **Bzlmod compatibility**, ensuring that the build infrastructure correctly selects Bazel versions and prevents potential build failures on the bots.

This commit performs an **infrastructure dependency roll** of the `infra` repository, primarily to **refactor CIPD package management** within the Skia build system. It **removes platform-specific CIPD packages for Git and Python**, replacing them with generic `${platform}` placeholders. This **maintenance** effort impacts the **task generation logic** in `infra/bots/gen_tasks_logic/task_builder.go` and the **task definitions** in `infra/bots/tasks.json`, simplifying how these essential tools are provisioned across different platforms in the Skia buildbot system.

This commit introduces a **new Python script**, `infra/bots/recipe_modules/flavor/resources/wait_for_device.py`, to centralize and simplify the process of **connecting to and waiting for Android devices** within the build infrastructure. It **refactors** the `wait_for_device` and `install` methods in the `android.py` recipe module to leverage this external script, which encapsulates the specific `adb connect` and `adb wait-for-device` sequence. This **infrastructure refactoring** improves the maintainability of Android build recipes by externalizing complex device provisioning logic. The change affects various **Android performance and test recipes** by standardizing how devices are prepared for execution, ensuring more robust and consistent device setup.

This commit performs **maintenance** and **refactoring** within the **Android recipe flavor** module, specifically enhancing the **Android device recovery logic**. It introduces shared code for `reboot_device_and_wait` and `wait_for_device` operations, improving code cleanliness and maintainability in `infra/bots/recipe_modules/flavor/android.py`. Crucially, the `wait-for-device` timeout has been increased for better stability, and the no-longer-functional force quarantine step has been removed to adapt to recent lab migrations. These changes ensure more robust and up-to-date device preparation for various Android-based performance and test runs, reflected in updated expected recipe outputs.

This commit **fixes** an issue within the **Android testing infrastructure** by adjusting the logic for determining Android Debug Bridge (ADB) paths. It specifically modifies the `__init__` method in `infra/bots/recipe_modules/flavor/android.py` to correctly set the **ADB binary and public key paths** based on the swarming bot ID. This **infrastructure bug fix** ensures that **Android tests** can properly locate and utilize the ADB tool, preventing failures caused by incorrect pathing. Consequently, several expected recipe outputs for `perf_skottietrace` tests have been updated to reflect these corrected ADB paths and an empty ADB vendor key.

This commit performs a **documentation update** by adding the **Louhi service account** to the project's `AUTHORS` file. This **maintenance task** ensures that the service account is properly recognized as a contributor within the project's **contributor metadata**. The change specifically affects the `AUTHORS` file, updating the official list of project contributors without impacting any functional aspects of the codebase.