alexsong-oai

This commit performs **maintenance** by **shortening the default prompts** for several plugins to be under 128 characters. Specifically, it updates the `plugin.json` configuration files for the **Build iOS Apps**, **Build Web Apps**, and **Outlook Calendar** plugins. This change aims to optimize prompt length, potentially improving performance or reducing token consumption for these **core plugin functionalities**.

This commit introduces a **new system skill**, `plugin-creator`, to the `codex-rs/skills` module, designed to streamline the development and management of plugins. It provides a **new Python script** (`create_basic_plugin.py`) for scaffolding basic plugin structures, including `plugin.json` and `marketplace.json` updates, and integrates a dedicated `OpenAI agent configuration`. The work also includes comprehensive **documentation** detailing the skill's usage and specifications for plugin and marketplace JSON files. This **new capability** significantly enhances the platform's extensibility by offering dedicated tools and standardized guidance for plugin creation.

This commit introduces a **new capability** to the **plugin management system**, enabling the fetching of **platform-specific featured plugins**. It modifies the `featured_plugin_ids_for_config` function within `codex-rs/core/src/plugins/manager.rs` to pass a `platform` parameter, derived from the `restriction_product`, to the remote API call `fetch_remote_featured_plugin_ids`. A new `to_app_platform` method is added to the `Product` enum in `codex-rs/protocol/src/protocol.rs` to facilitate this conversion, ensuring that the application can request and display **relevant featured plugin lists** tailored to specific product variants. This **enhancement** improves the accuracy of plugin recommendations, with updated and new tests verifying the correct handling of the platform parameter.

This commit introduces **support for featured plugins**, enabling the system to identify and communicate a curated list of prominent plugins. It primarily involves extending the **App Server Protocol** by adding a `featuredPluginIds` array to the `PluginListResponse` schema and its corresponding types in Rust and TypeScript. The **plugin management subsystem** in `codex-rs/core` gains new functionality to fetch and cache these featured plugin IDs from a remote source, which are then included in plugin list responses by the **app server**. This **new capability** allows clients to display or prioritize specific plugins, with comprehensive new tests ensuring correct fetching and caching behavior.

This commit **refactors the error handling** for **cloud requirements loading** to provide more structured and actionable diagnostic information. It introduces a new `CloudRequirementsLoadErrorCode` enum and modifies `CloudRequirementsLoadError` to include this specific code along with an optional HTTP status. This enhanced error metadata is now **surfaced through the JSON-RPC API** for `thread/start`, `thread/resume`, and `thread/fork` operations when configuration loading fails. This **enhancement** improves the clarity of error messages for clients, allowing them to better understand and respond to issues related to cloud configuration.

This commit introduces a comprehensive **plugin usage telemetry** system, a **new capability** designed to track how plugins are utilized within the `codex-rs` application. It integrates an `AnalyticsEventsClient` across key **`core` components** like the `PluginsManager`, `ConfigApi`, and the `run_turn` function to capture events such as plugin installation, uninstallation, enabling, disabling, and runtime usage. This enhancement provides valuable insights into plugin adoption and interaction patterns, significantly improving **observability** of the plugin ecosystem.

This commit introduces **granular metrics** for the **cloud requirements** module, significantly enhancing observability for fetching and loading operations. It adds new metrics, such as `emit_fetch_attempt_metric`, `emit_fetch_final_metric`, and `emit_load_metric`, which now incorporate **status codes** into error reporting. This **new capability** provides more detailed insights into the success and failure modes of cloud requirement retrieval, aiding in monitoring and troubleshooting. The change also includes a minor **refactoring** of related error types for improved consistency within the `codex-rs/cloud-requirements/src/lib.rs` file.

This commit introduces **new metrics** to enhance observability for the **external agent configuration** and **skill import** process within `codex-rs/core`. Specifically, it adds tracking for the detection and successful import of external agent configurations and skills, including a count of imported skills. This **feature enhancement** provides crucial insights into the migration process, allowing for better monitoring and troubleshooting of external configuration integration.

This commit introduces a **bug fix and improvement** to the **external agent configuration** module, specifically within `codex-rs/core/src/external_agent_config.rs`. It ensures that all environment variable values imported via `shell_environment_policy.set` are correctly converted to strings, preventing potential type-related issues during agent execution. Furthermore, the commit refines the **agent definition file detection and import logic**, prioritizing `.claude/CLAUDE.md` over `AGENTS.md` and validating that these files contain non-empty content before processing. This enhances the robustness and reliability of **agent configuration loading** by guaranteeing proper environment variable handling and more accurate discovery of agent definitions.

This commit implements a **fail-close strategy** for the **cloud requirements loading mechanism**, significantly enhancing the system's **robustness** by explicitly propagating errors instead of allowing silent failures or panics. It introduces a new `CloudRequirementsLoadError` type and modifies the `CloudRequirementsLoader` and related fetching functions, such as `fetch_with_timeout` and `refresh_cache`, to return `Result` types. This change primarily affects the **CLI's configuration loading** via `load_config_layers_state`, ensuring that issues with fetching cloud requirements are properly surfaced and handled. The scope is currently limited to the CLI, with plans to extend this behavior to the app-server in the future.

This commit introduces a **new background job** within the **`codex-rs/cloud-requirements`** module to **periodically refresh** the local cache for cloud requirements. The **Time-To-Live (TTL)** for this cache is now set to 30 minutes, with the new background job actively refreshing it every 5 minutes to ensure data freshness. This **enhancement** improves the consistency and reliability of cloud requirements data by proactively updating the cache. Furthermore, it includes logic to ensure that only a single refresh task, managed by `refresher_task_slot` and executed by `refresh_cache_in_background`, runs per process, optimizing resource usage and preventing redundant operations.

This commit introduces a **new capability** for **external agent configuration detection and import**, primarily focusing on **migration** from legacy Claude-based setups to the new Codex system. It implements comprehensive logic within the **`core`** and **`app-server`** modules to automatically convert `settings.json` to `config.toml`, copy and rewrite skill directories from `.claude/skills` to `.agents/skills`, and migrate `CLAUDE.md` to `AGENTS.md`. This **new feature** ensures a smooth transition for users by updating configuration fields, skill paths, and documentation content with Codex-specific terminology. The change significantly enhances the **configuration management** and **agent onboarding** experience by providing automated migration paths.

This commit introduces a **new feature** to detect and track **implicit skill invocations** within the `codex-rs/core` module, significantly enhancing the project's analytics capabilities. It adds a new `skills/invocation_utils` module responsible for identifying skill usage inferred from user actions like running scripts or accessing `SKILL.md` files, distinguishing them from explicit calls. The **analytics client** is updated with an `InvocationType` enum to categorize these events, and a `TurnSkillsContext` is integrated into the session management to manage tracking per turn. This change provides **improved telemetry** by offering a more complete picture of how skills are utilized, impacting the `shell` and `unified_exec` command handlers where detection logic is integrated.

This commit introduces **performance metrics** to the **connector loading process** within the `codex-rs/core/src/mcp_connection_manager.rs` module. As a **new feature**, it instruments key operations like `list_tools_for_client` to measure the duration of listing tools, fetching uncached tools, and writing to the tools cache. By utilizing `emit_duration`, this change provides crucial insights into the efficiency of connector operations. This will enable better monitoring and optimization, ultimately improving the overall performance of **connectors**.

This commit introduces a **new feature** to enable **app usage analytics** within the `codex-rs/core` module. It implements tracking for `app mentioned` and `app used` events, with deduplication logic applied to `app used` events based on `turn_id` and `connector_id`. The core `analytics_client.rs` now handles event generation and deduplication, while the `run_turn` function in `codex.rs` tracks app mentions. Additionally, `mcp_tool_call.rs` is updated to record `app used` events, distinguishing between explicit and implicit invocations. This provides crucial data for understanding how applications are engaged and utilized within the system.

This commit introduces a **new capability** to **configure the OpenTelemetry metrics exporter** within the `codex-rs` core module. It adds a `metrics_exporter` field to the `OtelConfigToml` struct and updates the `config.schema.json` to allow users to specify their desired exporter. The **OpenTelemetry configuration logic** in `codex-rs/core/src/config/mod.rs` is updated to utilize this new setting, with a default fallback to `statsig` if no exporter is explicitly defined. This enhancement provides greater flexibility for integrating with various monitoring systems by allowing custom metrics exporter selection.

This commit introduces a **new capability** to control skill invocation behavior by adding a `SkillPolicy` to **skill metadata**, specifically an `allow_implicit_invocation` flag. This flag allows skill developers to specify whether a skill can be automatically invoked by an agent or requires explicit user confirmation. The **`codex-rs/core`** module is updated to define, parse, and integrate this policy into the skill loading and filtering process, affecting how skills are made available for implicit use. This enhancement provides **fine-grained control over skill execution**, preventing unintended automatic skill usage and improving the predictability of agent interactions.

This commit introduces a **new capability** to the **`otel` integration module** by adding an `originator` field to the metadata tags collected for metrics. The `originator` value is now **sanitized** when an `OtelManager` is initialized, ensuring data integrity before being included in the telemetry. This enhancement provides richer context in collected metrics, improving the ability to trace the source of operations. **Tests have been updated** to verify the correct capture and inclusion of this new `originator` tag in both manager and snapshot metrics.

This commit **introduces an `originator` field to OpenTelemetry (Otel) events**, enabling better identification of the source component for telemetry data. It modifies the **`OtelEventMetadata` struct** and updates the **`OtelManager` initialization** to accept and propagate this new `originator` parameter. The **core session initialization** (`codex-rs/core/src/codex.rs`) and the **TUI application** (`codex-rs/tui/src/app.rs`) are updated to pass their respective originators during telemetry setup. This **new capability** enhances observability by allowing more granular tracking and filtering of telemetry events based on their originating module or feature, with corresponding test updates across `core` and `otel` modules.

This commit introduces a **new analytics client** to enable **tracking of skill invocation events** within the `codex-rs` core. It integrates this client into the `Codex` session, making it available via `SessionServices`, and modifies the `run_turn` function and `build_skill_injections` to record when skills are used. This **new capability** provides valuable telemetry on skill usage, allowing for better understanding and optimization of the skill system. The `analytics_client` module includes helper functions for path normalization and skill ID generation to ensure consistent event data.