Arjun Chaturvedi

This commit **reverts** the accidental migration of the **`asic_vendor_config`** module from `thrift-py-deprecated` to `thrift-python`. It restores the build dependency in `BUCK` and the import statements in `asic_vendor_config.py` to use `asic_config_v2-py-deprecated` and `asic_config_v2.ttypes` respectively. This **maintenance rollback** ensures that the `asic_vendor_config` module continues to use the older Thrift bindings for `asic_config_v2` types, preventing potential compatibility issues. The changes also revert enum access patterns and type hints within the module, specifically for functions like `get_asic_vendor_config`.

This commit **refactors** the `asic_vendor_config` component within `fboss/lib/platform_mapping_v2` by migrating its Python Thrift dependencies from `thrift-py-deprecated` to the modern `thrift-python` library. This involved updating `BUCK` build rules, changing import paths from `ttypes` to `thrift_types`, and adjusting enum access and return type hints for dictionary mappings. A temporary `pyre-fixme` was added in `read_files_utils.py` to address a cross-module type mismatch, which will be resolved when that module is also migrated. This ensures the `asic_vendor_config` module leverages the updated Thrift bindings, improving maintainability and aligning with current Python development standards.

Update agent hw test documentation.

This commit introduces a **new capability** to enhance **FBOSS code review** by adding an **OSS compatibility rule** to Devmate. This rule automatically checks for common issues like unguarded internal headers, internal API usage, missing CMake updates, and missing OSS stubs, surfacing them as non-blocking warnings to prevent OSS build failures. Additionally, a new **Claude skill** (`/fboss-check-oss`) is added, allowing developers to manually invoke these checks on diffs or local changes. This work aims to improve the maintainability and cross-platform compatibility of **FBOSS code** by proactively identifying potential issues during the review process.

This commit **reverts** changes introduced by a `thrift_codemod` in the **`fboss/lib/platform_mapping_v2`** module to resolve a **build incompatibility**. It removes the usage of `thrift_enums` imports and `fbthrift_name_or_key_error` from `asic_vendor_config.py` and `helpers.py`, restoring the previous method of using `ttypes` and `_VALUES_TO_NAMES` for handling Thrift enums such as `MultistageRole`, `ChipType`, and `CoreType`. This **maintenance fix** addresses the issue where the codemod's changes were not compatible with the **OSS CMake build**. The `BUCK` file is also updated to remove the codemod-added dependencies, ensuring the **platform mapping v2** module can be built correctly in open-source environments.

This commit **optimizes the build process** by preventing unnecessary `getdeps` jobs from running. It modifies the **`fboss` manifest** to include the `.llms` directory in the `shipit.strip` configuration. This ensures that **on-diff builds** are skipped when only Devmate LLM rule files, which are exclusively used for AI-assisted code review, are changed. The primary impact is a **reduction in CI/CD overhead** for OSS builds, as these AI-related files are not relevant to the open-source compilation process.

This commit **optimizes the build process** by preventing unnecessary `getdeps` jobs from running. It modifies the **`fboss` manifest** to include the `.llms` directory in the `shipit.strip` configuration. This ensures that **on-diff builds** are skipped when only Devmate LLM rule files, which are exclusively used for AI-assisted code review, are changed. The primary impact is a **reduction in CI/CD overhead** for OSS builds, as these AI-related files are not relevant to the open-source compilation process.

This commit **optimizes the build process** by preventing unnecessary `getdeps` jobs from running. It modifies the **`fboss` manifest** to include the `.llms` directory in the `shipit.strip` configuration. This ensures that **on-diff builds** are skipped when only Devmate LLM rule files, which are exclusively used for AI-assisted code review, are changed. The primary impact is a **reduction in CI/CD overhead** for OSS builds, as these AI-related files are not relevant to the open-source compilation process.

This commit **open-sources** the **AgentEnsembleQsfpFsdbTests**, making a crucial suite of **integration tests** for **QSFP FSDB functionality** available for external builds. It involves **refactoring** by moving `AgentEnsembleQsfpFsdbTests.cpp` and `QsfpFsdbTestUtils.h` to public directories, along with updating **BUCK and CMake build configurations** accordingly. The new tests cover various transceiver, PHY, and port state changes, enhancing the test coverage for the **FBOSS agent's QSFP service**. Additionally, it includes a **bug fix** by adding `inline` to `operator<<` definitions in `QsfpFsdbTestUtils.h` to prevent multiple definition errors. This change enables external contributors to build and run these important tests, improving overall project reliability.

This commit provides a **bug fix** for **FSDB subscription serving** in **OSS builds** by disabling the `useIdPathsForSubs` flag. Previously, enabling this flag caused an exception related to `thrift_cow::PatchNode` missing a bundled schema, leading to broken subscriptions and warm boot test failures in the OSS environment. The change modifies the `fboss/oss/scripts/run_scripts/fsdb_service_utils.py` script to explicitly set `--useIdPathsForSubs=false` when starting the FSDB service. This ensures **FSDB functionality** is restored and **warm boot tests** can execute successfully in the **OSS environment**.

This commit **refactors** the **QSFP service's Thrift server termination logic** to implement a **graceful shutdown** mechanism, specifically for the **OSS environment**. A new function, `stopQsfpServerGracefully`, is introduced and called by the signal handler to ensure the server first stops listening for new connections before fully terminating. This **maintenance** improvement enhances the robustness and reliability of the **QSFP service**, preventing abrupt shutdowns and ensuring cleaner resource release during test execution and general operation. The change primarily impacts the **stability of the QSFP service** and **test cleanup processes** in OSS deployments.

This commit introduces the **capability to start and manage the FSDB service** as part of the `run_test.py` **link test execution**. It integrates new utility functions from `fsdb_service_utils.py` for setting up, starting, and cleaning up the FSDB service directly into the `LinkTestRunner` in `run_test.py`. This **feature enhancement** provides command-line options like `--disable-fsdb` to control FSDB behavior, enabling more comprehensive testing of components such as the **HW agent** and **QSFP service** that rely on FSDB. Ultimately, this change significantly **improves the realism and coverage of link tests** by ensuring FSDB-dependent functionalities are properly exercised.

This commit **fixes a bug** preventing certain **HW Agent warmboot tests** from running successfully, specifically `AgentEnsembleLinkSanityTestDataPlaneFlood.warmbootIsHitLess`. The issue stemmed from the `HwTestThriftHandler` not being registered, as it requires either `--thrift_test_utils_thrift_handler` or `--hw_agent_for_testing` to be set. To resolve this, the **OSS HW Agent setup script** (`fboss/oss/scripts/run_scripts/fboss_agent_utils.py`) is updated to explicitly include the `--hw_agent_for_testing=true` flag during service setup. This **maintenance change** ensures the proper registration of the Thrift handler, thereby **enabling the correct execution of dependent HW Agent tests**.

This commit **fixes a build failure** in the **OSS build** by updating the `CliFboss2.cmake` configuration. The previous changes had caused the build to fail, necessitating this **maintenance** update. Specifically, this change integrates new **BGP protocol configuration** command source files and links the required libraries to the `fboss2_config_lib` target. This ensures the **OSS build** can now complete successfully, enabling further development and deployment of **BGP features**.

This commit delivers a crucial **bug fix** to resolve **Open Source Software (OSS) build failures** impacting the **FBOSS CLI**. It addresses compilation errors caused by references to internal libraries, such as `neteng/fboss/bgp/if/gen-cpp2/TBgpService.h` and `neteng/netwhoami/lib/cpp/Recover.h`, by implementing **conditional compilation** in `fboss/cli/fboss2/commands/show/hardware/CmdShowHardware.cpp` and `fboss/cli/fboss2/utils/CmdUtils.cpp`. Additionally, it corrects an include path for `common/network/AddressUtil.h` in `fboss/cli/fboss2/commands/show/route/CmdShowRouteDetails.cpp` and ensures the `show_hardware_model` thrift library is properly linked in `cmake/CliFboss2.cmake`. This **maintenance** work guarantees that the **FBOSS CLI** can be successfully built and deployed in **OSS environments**.

This commit **integrates platform services tests** into the `run_test.py` script, providing a unified and streamlined method for executing these hardware-specific tests. It introduces a new `platform` subcommand to `run_test.py` and implements a `PlatformServicesTestRunner` to manage the execution of various **platform service hardware tests**, including support for filtering specific tests. This **new capability** significantly enhances the testing workflow for **platform-specific hardware components** and is reflected in updated documentation, making it easier to run and manage these critical tests.

This commit **updates the platform hardware test suite** by integrating `fw_util_hw_test` into the `run_test.py` script's `platform` command. This **maintenance fix** addresses a previous oversight, ensuring that the **firmware utility hardware tests** are now consistently executed as part of the comprehensive platform validation process. By enhancing the **testing infrastructure**, this change provides more complete **test coverage** for **firmware utility functionality**, improving the overall reliability and robustness of platform hardware validation.

This commit **introduces multi-switch mode support** for the **link test execution script** `run_test.py`. It **enhances the `LinkTestRunner`** within `fboss/oss/scripts/run_scripts/run_test.py` by adding new command-line arguments via `add_subparser_args` and modifying test binary selection logic in `_get_test_bin_name`. This **new capability** allows link tests to be run and validated in more complex, multi-switch network topologies, improving test coverage and realism by conditionally managing hardware agent services during test setup and teardown.

This commit introduces a **new GitHub Actions workflow** dedicated to the **FSDB** subsystem, establishing a robust CI/CD pipeline for its binary artifact. This **new capability** automates the entire process of building, validating, and publishing the FSDB binary, ensuring consistent quality and availability. As part of this integration, the `DeltaPublisherTest` in `fboss/fsdb/client/test/FsdbPublisherTest.cpp` was adjusted to correctly track `chunksWritten` baselines. Additionally, a **maintenance chore** was performed in `fboss/oss/scripts/github_actions/docker-unittest.py` to add `--network=host`, ensuring IPv6 localhost availability for tests within the new CI environment. This significantly enhances the automation and reliability of FSDB's development and release cycle.

This commit performs **maintenance** on the **Wiki page** by **removing duplicate test entries** from the test listings. Previously, some tests were redundantly listed under multiple categories, leading to an inaccurate and cluttered view. This change ensures that each test appears in only one designated category, significantly improving the **accuracy and organization** of the test documentation for users browsing the Wiki.