Developer
CliffyWong
cliffy.wang@celestica.com
Performance
Key patterns and highlights from this developer's activity.
Breakdown of growth, maintenance, and fixes effort over time.
Bugs introduced vs. fixed over time.
No bugs introduced or fixed in this period.
Latest analyzed commits from this developer.
| Hash | Message | Date | Files | Effort |
|---|---|---|---|---|
| 64e03ea | This commit **updates the thermal configuration** for the **Tahan SB800BC platform** to ensure proper **Hardware Over-Temperature Protection (HW OTP)** functionality. It **modifies the `platform_manager.json`** to set the initial register settings for TMP432 local and remote high temperature limits to 95°C, down from 100°C. Concurrently, the **`sensor_service.json`** is updated to align the `upperCriticalVal` for several TMP432 temperature sensors to 95°C, reflecting the new hardware thresholds. This **configuration update** is a **maintenance** task, driven by thermal team verification, and is crucial for accurate thermal monitoring and protection. | Mar 20 | 2 | grow |
| 7dc19dd | This commit performs a **configuration update** for the `tahansb800bc` platform, primarily affecting its **Board Support Package (BSP)** and device identification. It **bumps the BSP kernel modules RPM version to 4.1.0-1** and **updates the `kernelDeviceName` for the SMB_CPLD** from `santa_smbcpld` to `th6_smbcpld` in `platform_manager.json`. This **maintenance task** ensures compatibility with recent driver updates in the BSP, allowing for correct identification and interaction with the **SMB_CPLD module** on the `tahansb800bc` device. | Mar 6 | 1 | maint |
| 49a9185 | This commit **updates the platform configuration** for the **Tahan SB800BC** platform to align with its DVT hardware revision. It **removes the `ina238` sensor configuration** from `platform_manager.json` as the device is no longer present in the updated hardware design. Additionally, this **maintenance** change **adds the `fboss_iob_i2c` kernel module** to the list of required modules, which prevents potential I2C bus creation conflicts. This ensures the correct functioning of **platform management** and **sensor services** on the DVT hardware, preventing issues related to device presence and I2C bus initialization. | Mar 6 | 1 | grow |
| ef8d708 | This commit **updates sensor thresholds** within the **Tahan SB800BC platform's sensor service configuration**. It adjusts the maximum alarm thresholds for several **SMB_VDDCORE and SMB_ASIC_VOLTAGE iout sensors** based on TH6 B0+ hardware design specifications. Additionally, it modifies the minimum alarm thresholds for numerous **iin/iout and POUT sensors** across SMB and MCB power rails, incorporating vendor recommendations to account for negative current readings at zero load. This **configuration update** is a **maintenance** task that improves the accuracy of **power monitoring** and alarm generation, preventing false positives and ensuring reliable system health reporting for critical hardware components. | Jan 29 | 1 | maint |
| 7ae8eaa | This commit **updates the configuration** for the **tahansb800bc platform**, performing essential **maintenance** and **alignment**. It **bumps the Board Support Package (BSP) version to `4.0.0-1`** and **corrects the `kernelDeviceName` for the `tps16890` device to `tps1689`** within the `fboss/platform/configs/tahansb800bc/platform_manager.json` file. This change is crucial for aligning with recent BSP driver updates, ensuring proper device recognition and continued functionality of platform services on `tahansb800bc` devices. | Jan 8 | 1 | maint |
| 34795aa | This commit **adds new sensor configurations** to `fboss/platform/configs/montblanc/sensor_service.json`, specifically introducing support for **COME (NETLAKE) device versions 4.2.1 and 4.2.2**. This **feature addition** is crucial for **Minipack3** devices, where these new COME versions are deployed. It ensures that the **`sensor_service`** can correctly discover and monitor all associated sensors on these updated hardware variants. Consequently, services such as `platform_manager`, `data_corral_service`, and `fan_service` will now operate normally and successfully explore sensors on Minipack3 devices equipped with COME V4.2.1 and V4.2.2. | Dec 10 | 1 | grow |
| c85e855 | This commit **adds comprehensive BSP test configuration** for the **tahansb800bc platform** by updating the `fboss/platform/configs/tahansb800bc/bsp_tests.json` file. This **new capability** is essential for **OSS new-platform onboarding requirements**, enabling a full suite of Board Support Package (BSP) tests for the new hardware. Specifically, the configuration now includes detailed test data for `i2c`, `hwmon`, `led`, and `watchdog` functionalities. This work ensures thorough **validation and integration** of the **tahansb800bc platform** within the FBOSS ecosystem, allowing for comprehensive hardware verification. | Dec 9 | 1 | grow |
| 4e2d6be | This commit **enables** the `HwmonTests` within the **BSP tests** framework by integrating `HwmonTests.cpp` into the `bsp_tests` executable via `PlatformBspTests.cmake`. It also includes a **build fix** for `HwmonTests.cpp` by adding the necessary `<fmt/ranges.h>` header to ensure `fmt::join` compiles correctly. Furthermore, an empty `bsp_tests.json` configuration file is added for the `tahansb800bc` platform, allowing these new hardware monitoring tests to be executed as part of the default test cases. This work expands the test coverage for hardware monitoring functionality on supported platforms. | Dec 9 | 3 | maint |
| 2fe44cb | This commit **updates the fan service configuration** for the **TahanSB800BC platform** by setting the `pwmMax` value to 64 within `fboss/platform/configs/tahansb800bc/fan_service.json`. This **configuration update** is a **maintenance change** to align the software with the latest MCB CPLD Design Specification, which mandates a maximum PWM of 64 for fan speed control. The adjustment ensures that the **fan service** can correctly utilize the full range of fan speeds supported by the hardware. This change directly impacts the **fan speed control mechanism**, potentially improving thermal management and system cooling capabilities on the TahanSB800BC devices. | Dec 9 | 1 | maint |
| c03f8a2 | This commit introduces a **configuration update** to the `platform_manager.json` file for the **Tahan SB800BC platform**, specifically targeting the **TMP432 temperature sensors**. It sets the local and remote temperature high thresholds to 100°C, a crucial requirement for enabling the **Hardware Over-Temperature Protection (OTP)** feature. Additionally, registers 0x27 and 0x28 are configured to 0x05 to calibrate the TMP432 temperature values, ensuring accurate readings. This **new capability** is vital for proper system thermal management and protection. | Dec 8 | 1 | grow |
| 59a098a | This commit **enhances the `sensor_service` configuration** for the **tahansb800bc platform** by adding support for distinct voltage sensor thresholds. It specifically addresses the varying specifications of **TH6 B0 and TH6 B0+ hardware revisions**, which have different nominal and alarm voltage levels for sensors like `XP0R72V_PB_TRVDD`. This **configuration update** ensures that the `sensor_service` correctly monitors and triggers alarms for voltage sensors across different SMB versions (1.1.10-1.5.10 vs. 1.6.10+). By introducing versioned sensor configurations in `fboss/platform/configs/tahansb800bc/sensor_service.json`, the system can now prevent misconfigurations or inaccurate alerts due to hardware variations. | Dec 5 | 1 | grow |
| cebf56d | This commit **updates the ASIC temperature sensor list** for the **TahanSB800BC platform**, aligning the software configuration with the hardware design. It specifically designates `temp2` and `temp3` from `tmp432-1` and `temp2` from `tm-432-2` as the correct sensors for monitoring ASIC temperature. This **configuration update** is crucial for accurate hardware monitoring, directly impacting the **sensor_service** and other platform services that rely on precise temperature readings for the ASIC on the `TahanSB800BC` device. | Nov 24 | 2 | – |
| a7b9bf0 | This commit **updates the sensor configuration** for the **tahansb800bc platform**, specifically within the `fboss/platform/configs/tahansb800bc/sensor_service.json` file. This **maintenance** work involves revising **sensor thresholds**, **calibration formulas**, and **sensor node paths** based on the latest hardware specifications and validation. Key changes include adding temperature sensors for `SMB_TH6_SENSOR_TMP432_1`, updating current and power calibration for `LTC4287` and `TPS25990` devices, and adjusting sensor names for `SMB_ASIC_VOLTAGE_7`. These modifications are crucial for ensuring **accurate sensor readings and reliable hardware monitoring**. | Nov 21 | 1 | waste |
| 73c3fdd | This commit performs a **platform name update**, systematically changing all references from `tahansb` to **`tahansb800bc`**. This **maintenance** task involves **refactoring** the **platform identification logic** within `PlatformMode.h` and `PlatformProductInfo.cpp` to recognize the new name. It also updates **platform configuration files** for `tahansb800bc`, specifically `platform_manager.json` and `sensor_service.json`, and modifies the `ALLOWED_PMUNIT_NAMES` in `platform_manager_validators.thrift`. Finally, a **BSP mapping test case** in `ParserTest.cpp` is adjusted to reflect the updated platform name, ensuring proper configuration and functionality for various **platform services**. | Nov 11 | 10 | maint |
| a080cfc | This commit **fixes a critical bug** affecting **Power Brick** devices on the **TahanSB** platform. Previously, an unexpected PMBus page register flip from 0x00 to 0x01 after power-up caused the **PMBus driver** to fail, leading to `sensor_service` test failures. This **configuration update** introduces `initRegSettings` in `fboss/platform/configs/tahansb/platform_manager.json` to explicitly set the PMBus page to 0 for devices at addresses 0x60 and 0x61. This ensures correct PMBus driver operation, preventing the page flip issue and resolving sensor failures on EVT2B units with new Power Brick versions. | Oct 9 | 1 | waste |
| 46a2cb4 | This commit **updates the fan control configuration** for the **tahansb** platform, specifically within the `fboss/platform/configs/tahansb/fan_service.json` file. This **maintenance** work involves **revising parameters for the PID and Linear control algorithms**, adjusting **PWM-related settings** like boost, transition, and upper thresholds, and modifying the list of sensors utilized by the **Fan Speed Controller (FSC)**. The changes are driven by the latest thermal design and fan datasheet, ensuring the **fan service** operates optimally according to current hardware specifications. This update directly impacts the thermal management and fan behavior on **tahansb** devices. | Sep 26 | 1 | grow |
| 2117e2f | This commit **onboards the new TAHANSB800BC platform** to FBOSS by implementing its foundational Board Support Package (BSP) and platform mapping. It introduces new platform-specific code for the **FBOSS Agent**, **QSFP Service**, and **LED Service**, including `Tahansb800bcPlatformMapping`, `Tahansb800bcBspPlatformMapping`, and `Tahansb800bcLedManager`. This **new capability** involves extensive updates to the build system (CMake, BUCK) and core libraries to recognize and manage the new hardware. While the initial platform mapping JSON is a placeholder, this work establishes the necessary framework for full software support and interaction with the `TAHANSB800BC` platform. | Sep 16 | 32 | grow |
| 59ab19b | This commit **enhances the fan service** by **implementing support for two-rotor fan failure** (N+2 redundancy) on the **TahanSB platform**. It introduces new `twoRotorsFailUpTable` and `twoRotorsFailDownTable` configuration tables in `fboss/platform/configs/tahansb/fan_service.json` and updates the `fboss/platform/fan_service/if/fan_service_config.thrift` schema to define these. The core **PWM calculation logic** in `fboss/platform/fan_service/ControlLogic.cpp`'s `updateTargetPwm` function is modified to detect two-rotor failures and utilize these new tables. This **new capability** ensures appropriate fan speeds are maintained even with two failed rotors, significantly improving the system's thermal management robustness and reliability under severe fault conditions. | Sep 3 | 3 | grow |
| 56960aa | This commit **updates the `platform_manager.json` configuration** for the **tahansb platform**, introducing `isEeprom` and `chassisEepromDevicePath` fields and renaming `CHASSIS_EEPROM` to `CHASSIS_IDPROM`. This **configuration update** aligns the `platform_manager` with recent changes in its Thrift interface, enabling the correct publishing of hardware versions for CHASSIS EEPROMs not modeled as IDPROMs. Additionally, the `bspKmodsRpmVersion` is **bumped to `3.3.0-1`** to reflect the latest Board Support Package. This **maintenance** ensures the **platform manager** and related services (`sensor_service`, `fan_service`, `data_corral_service`) function correctly on `tahansb` hardware, preventing errors related to outdated interfaces or BSP versions. | Aug 27 | 1 | grow |
| 3d16e3b | This commit **updates platform service configurations** for the **TAHANSB EVT1** hardware phase, aligning software with the latest specifications after initial bring-up. It involves significant changes across the **`platform_manager`**, **`sensor_service`**, **`fw_util`**, **`led_manager`**, and **`fan_service`** modules. Specifically, `platform_manager` sees updates to device names, CSR offsets, and kernel device names, while `sensor_service` receives corrected sensor names, formulas, `sysfsPath` values, and thresholds. Additionally, `fw_util` adjusts a GPIO pin for DOM FPGA upgrades, `led_manager` gains PWR/SMB presence detection, and `fan_service` is refined by removing optics lists and updating sensor configurations. This **maintenance and configuration update** is crucial for the correct functioning and monitoring of the TAHANSB platform's EVT1 hardware. | Aug 12 | 5 | grow |
This commit **updates the thermal configuration** for the **Tahan SB800BC platform** to ensure proper **Hardware Over-Temperature Protection (HW OTP)** functionality. It **modifies the `platform_manager.json`** to set the initial register settings for TMP432 local and remote high temperature limits to 95°C, down from 100°C. Concurrently, the **`sensor_service.json`** is updated to align the `upperCriticalVal` for several TMP432 temperature sensors to 95°C, reflecting the new hardware thresholds. This **configuration update** is a **maintenance** task, driven by thermal team verification, and is crucial for accurate thermal monitoring and protection.
This commit performs a **configuration update** for the `tahansb800bc` platform, primarily affecting its **Board Support Package (BSP)** and device identification. It **bumps the BSP kernel modules RPM version to 4.1.0-1** and **updates the `kernelDeviceName` for the SMB_CPLD** from `santa_smbcpld` to `th6_smbcpld` in `platform_manager.json`. This **maintenance task** ensures compatibility with recent driver updates in the BSP, allowing for correct identification and interaction with the **SMB_CPLD module** on the `tahansb800bc` device.
This commit **updates the platform configuration** for the **Tahan SB800BC** platform to align with its DVT hardware revision. It **removes the `ina238` sensor configuration** from `platform_manager.json` as the device is no longer present in the updated hardware design. Additionally, this **maintenance** change **adds the `fboss_iob_i2c` kernel module** to the list of required modules, which prevents potential I2C bus creation conflicts. This ensures the correct functioning of **platform management** and **sensor services** on the DVT hardware, preventing issues related to device presence and I2C bus initialization.
This commit **updates sensor thresholds** within the **Tahan SB800BC platform's sensor service configuration**. It adjusts the maximum alarm thresholds for several **SMB_VDDCORE and SMB_ASIC_VOLTAGE iout sensors** based on TH6 B0+ hardware design specifications. Additionally, it modifies the minimum alarm thresholds for numerous **iin/iout and POUT sensors** across SMB and MCB power rails, incorporating vendor recommendations to account for negative current readings at zero load. This **configuration update** is a **maintenance** task that improves the accuracy of **power monitoring** and alarm generation, preventing false positives and ensuring reliable system health reporting for critical hardware components.
This commit **updates the configuration** for the **tahansb800bc platform**, performing essential **maintenance** and **alignment**. It **bumps the Board Support Package (BSP) version to `4.0.0-1`** and **corrects the `kernelDeviceName` for the `tps16890` device to `tps1689`** within the `fboss/platform/configs/tahansb800bc/platform_manager.json` file. This change is crucial for aligning with recent BSP driver updates, ensuring proper device recognition and continued functionality of platform services on `tahansb800bc` devices.
This commit **adds new sensor configurations** to `fboss/platform/configs/montblanc/sensor_service.json`, specifically introducing support for **COME (NETLAKE) device versions 4.2.1 and 4.2.2**. This **feature addition** is crucial for **Minipack3** devices, where these new COME versions are deployed. It ensures that the **`sensor_service`** can correctly discover and monitor all associated sensors on these updated hardware variants. Consequently, services such as `platform_manager`, `data_corral_service`, and `fan_service` will now operate normally and successfully explore sensors on Minipack3 devices equipped with COME V4.2.1 and V4.2.2.
This commit **adds comprehensive BSP test configuration** for the **tahansb800bc platform** by updating the `fboss/platform/configs/tahansb800bc/bsp_tests.json` file. This **new capability** is essential for **OSS new-platform onboarding requirements**, enabling a full suite of Board Support Package (BSP) tests for the new hardware. Specifically, the configuration now includes detailed test data for `i2c`, `hwmon`, `led`, and `watchdog` functionalities. This work ensures thorough **validation and integration** of the **tahansb800bc platform** within the FBOSS ecosystem, allowing for comprehensive hardware verification.
This commit **enables** the `HwmonTests` within the **BSP tests** framework by integrating `HwmonTests.cpp` into the `bsp_tests` executable via `PlatformBspTests.cmake`. It also includes a **build fix** for `HwmonTests.cpp` by adding the necessary `<fmt/ranges.h>` header to ensure `fmt::join` compiles correctly. Furthermore, an empty `bsp_tests.json` configuration file is added for the `tahansb800bc` platform, allowing these new hardware monitoring tests to be executed as part of the default test cases. This work expands the test coverage for hardware monitoring functionality on supported platforms.
This commit **updates the fan service configuration** for the **TahanSB800BC platform** by setting the `pwmMax` value to 64 within `fboss/platform/configs/tahansb800bc/fan_service.json`. This **configuration update** is a **maintenance change** to align the software with the latest MCB CPLD Design Specification, which mandates a maximum PWM of 64 for fan speed control. The adjustment ensures that the **fan service** can correctly utilize the full range of fan speeds supported by the hardware. This change directly impacts the **fan speed control mechanism**, potentially improving thermal management and system cooling capabilities on the TahanSB800BC devices.
This commit introduces a **configuration update** to the `platform_manager.json` file for the **Tahan SB800BC platform**, specifically targeting the **TMP432 temperature sensors**. It sets the local and remote temperature high thresholds to 100°C, a crucial requirement for enabling the **Hardware Over-Temperature Protection (OTP)** feature. Additionally, registers 0x27 and 0x28 are configured to 0x05 to calibrate the TMP432 temperature values, ensuring accurate readings. This **new capability** is vital for proper system thermal management and protection.
This commit **enhances the `sensor_service` configuration** for the **tahansb800bc platform** by adding support for distinct voltage sensor thresholds. It specifically addresses the varying specifications of **TH6 B0 and TH6 B0+ hardware revisions**, which have different nominal and alarm voltage levels for sensors like `XP0R72V_PB_TRVDD`. This **configuration update** ensures that the `sensor_service` correctly monitors and triggers alarms for voltage sensors across different SMB versions (1.1.10-1.5.10 vs. 1.6.10+). By introducing versioned sensor configurations in `fboss/platform/configs/tahansb800bc/sensor_service.json`, the system can now prevent misconfigurations or inaccurate alerts due to hardware variations.
This commit **updates the ASIC temperature sensor list** for the **TahanSB800BC platform**, aligning the software configuration with the hardware design. It specifically designates `temp2` and `temp3` from `tmp432-1` and `temp2` from `tm-432-2` as the correct sensors for monitoring ASIC temperature. This **configuration update** is crucial for accurate hardware monitoring, directly impacting the **sensor_service** and other platform services that rely on precise temperature readings for the ASIC on the `TahanSB800BC` device.
This commit **updates the sensor configuration** for the **tahansb800bc platform**, specifically within the `fboss/platform/configs/tahansb800bc/sensor_service.json` file. This **maintenance** work involves revising **sensor thresholds**, **calibration formulas**, and **sensor node paths** based on the latest hardware specifications and validation. Key changes include adding temperature sensors for `SMB_TH6_SENSOR_TMP432_1`, updating current and power calibration for `LTC4287` and `TPS25990` devices, and adjusting sensor names for `SMB_ASIC_VOLTAGE_7`. These modifications are crucial for ensuring **accurate sensor readings and reliable hardware monitoring**.
This commit performs a **platform name update**, systematically changing all references from `tahansb` to **`tahansb800bc`**. This **maintenance** task involves **refactoring** the **platform identification logic** within `PlatformMode.h` and `PlatformProductInfo.cpp` to recognize the new name. It also updates **platform configuration files** for `tahansb800bc`, specifically `platform_manager.json` and `sensor_service.json`, and modifies the `ALLOWED_PMUNIT_NAMES` in `platform_manager_validators.thrift`. Finally, a **BSP mapping test case** in `ParserTest.cpp` is adjusted to reflect the updated platform name, ensuring proper configuration and functionality for various **platform services**.
This commit **fixes a critical bug** affecting **Power Brick** devices on the **TahanSB** platform. Previously, an unexpected PMBus page register flip from 0x00 to 0x01 after power-up caused the **PMBus driver** to fail, leading to `sensor_service` test failures. This **configuration update** introduces `initRegSettings` in `fboss/platform/configs/tahansb/platform_manager.json` to explicitly set the PMBus page to 0 for devices at addresses 0x60 and 0x61. This ensures correct PMBus driver operation, preventing the page flip issue and resolving sensor failures on EVT2B units with new Power Brick versions.
This commit **updates the fan control configuration** for the **tahansb** platform, specifically within the `fboss/platform/configs/tahansb/fan_service.json` file. This **maintenance** work involves **revising parameters for the PID and Linear control algorithms**, adjusting **PWM-related settings** like boost, transition, and upper thresholds, and modifying the list of sensors utilized by the **Fan Speed Controller (FSC)**. The changes are driven by the latest thermal design and fan datasheet, ensuring the **fan service** operates optimally according to current hardware specifications. This update directly impacts the thermal management and fan behavior on **tahansb** devices.
This commit **onboards the new TAHANSB800BC platform** to FBOSS by implementing its foundational Board Support Package (BSP) and platform mapping. It introduces new platform-specific code for the **FBOSS Agent**, **QSFP Service**, and **LED Service**, including `Tahansb800bcPlatformMapping`, `Tahansb800bcBspPlatformMapping`, and `Tahansb800bcLedManager`. This **new capability** involves extensive updates to the build system (CMake, BUCK) and core libraries to recognize and manage the new hardware. While the initial platform mapping JSON is a placeholder, this work establishes the necessary framework for full software support and interaction with the `TAHANSB800BC` platform.
This commit **enhances the fan service** by **implementing support for two-rotor fan failure** (N+2 redundancy) on the **TahanSB platform**. It introduces new `twoRotorsFailUpTable` and `twoRotorsFailDownTable` configuration tables in `fboss/platform/configs/tahansb/fan_service.json` and updates the `fboss/platform/fan_service/if/fan_service_config.thrift` schema to define these. The core **PWM calculation logic** in `fboss/platform/fan_service/ControlLogic.cpp`'s `updateTargetPwm` function is modified to detect two-rotor failures and utilize these new tables. This **new capability** ensures appropriate fan speeds are maintained even with two failed rotors, significantly improving the system's thermal management robustness and reliability under severe fault conditions.
This commit **updates the `platform_manager.json` configuration** for the **tahansb platform**, introducing `isEeprom` and `chassisEepromDevicePath` fields and renaming `CHASSIS_EEPROM` to `CHASSIS_IDPROM`. This **configuration update** aligns the `platform_manager` with recent changes in its Thrift interface, enabling the correct publishing of hardware versions for CHASSIS EEPROMs not modeled as IDPROMs. Additionally, the `bspKmodsRpmVersion` is **bumped to `3.3.0-1`** to reflect the latest Board Support Package. This **maintenance** ensures the **platform manager** and related services (`sensor_service`, `fan_service`, `data_corral_service`) function correctly on `tahansb` hardware, preventing errors related to outdated interfaces or BSP versions.
This commit **updates platform service configurations** for the **TAHANSB EVT1** hardware phase, aligning software with the latest specifications after initial bring-up. It involves significant changes across the **`platform_manager`**, **`sensor_service`**, **`fw_util`**, **`led_manager`**, and **`fan_service`** modules. Specifically, `platform_manager` sees updates to device names, CSR offsets, and kernel device names, while `sensor_service` receives corrected sensor names, formulas, `sysfsPath` values, and thresholds. Additionally, `fw_util` adjusts a GPIO pin for DOM FPGA upgrades, `led_manager` gains PWR/SMB presence detection, and `fan_service` is refined by removing optics lists and updating sensor configurations. This **maintenance and configuration update** is crucial for the correct functioning and monitoring of the TAHANSB platform's EVT1 hardware.
Commit activity distribution by hour and day of week. Shows when this developer is most active.
Developers who frequently work on the same files and symbols. Higher score means stronger code collaboration.