Cj Longoria

This commit performs a **revert** of the previous change identified as `D93925488`. It effectively **undoes** all modifications introduced by that specific differential revision, restoring the codebase to its state prior to its application. This **rollback** ensures that any features, bug fixes, or refactorings from `D93925488` are no longer present in the system. The primary impact is the removal of the functionality or changes previously added, ensuring stability or addressing unforeseen issues.

This commit **reverts** a previous **refactoring** within the **Rust Thrift generator**, specifically undoing changes introduced by `D94012486`. It restores the constant value property generation logic to `thrift/compiler/generate/t_mstch_rust_generator.cc`, moving it back from the `mstch_rust_value` class. Consequently, the `thrift/compiler/generate/templates/rust/lib/value.mustache` template also reverts to its prior state, no longer utilizing the refactored constant value property accessors. This action effectively restores the generator's structure to its state before the refactoring attempt.

This commit **reverts** a previous **refactoring** within the **Thrift Rust code generator**, specifically undoing changes to internal template variable keys. It **restores** the use of `field:default_value` instead of `field:default` for struct field defaults and `constant:value` instead of `constant:rust` for constant values. This change impacts the `t_mstch_rust_generator.cc` and its associated Mustache templates, including `const.mustache`, `structimpl.mustache`, and `value.mustache`, effectively rolling back the standardization of these template variable names.

This commit **reverts** the previous **refactoring** introduced in `D94013994`, which aimed to streamline type information access within the **Thrift Rust compiler generator**. It undoes changes in `thrift/compiler/generate/t_mstch_rust_generator.cc` that refactored property definition lambdas, and restores the original usage of type accessors in **Rust code generation templates**. Specifically, it reverts the use of `list_elem_type`, `set_elem_type`, `key_type`, and `value_type` in templates like `arg_inner.mustache`, `mod.impl.mustache`, and `type_generics.mustache`. This **revert** ensures the stability of the **Rust Thrift compiler's output** by restoring the prior, working state of type handling.

This commit **reverts a recent refactoring** within the **Thrift compiler's Rust code generation backend**. It undoes the introduction of dedicated MSTCH classes like `mstch_rust_value`, `mstch_rust_map_entry`, and `mstch_rust_struct_field` in `thrift/compiler/generate/t_mstch_rust_generator.cc`, which were intended to provide a more structured representation for values, map entries, and struct fields. Consequently, the `thrift/compiler/generate/templates/rust/lib/value.mustache` template also reverts to its prior state, no longer relying on the new `value:` properties for type checks. This **revert** effectively rolls back changes aimed at improving the internal structure and maintainability of the **Rust generator**.

This commit **reverts** a recent **refactoring** within the **Thrift compiler's Rust generator**, specifically in `t_mstch_rust_generator.cc`. It undoes the extraction of type splitting, service, and function-related logic into dedicated `rust_mstch_program`, `rust_mstch_service`, and `rust_mstch_function` classes. This **revert** restores the previous, more monolithic structure of the Rust code generation logic. The change impacts the internal organization and modularity of the **Rust Thrift code generation** process, returning it to its state before the refactoring.

This commit **refactors** the **Thrift Rust code generator** by migrating the handling of constant value properties to the **Whisker prototype system**. Specifically, it moves logic from numerous `mstch_rust_value` methods, such as `is_newtype` and `integer_value`, into a new `make_prototype_for_const_value` function. This change centralizes how constant value properties are defined and accessed, impacting the `t_mstch_rust_generator.cc` file where the logic resides and the `value.mustache` template which now consumes these new prototype properties. The refactoring aims to improve the internal architecture and consistency of **Rust code generation** for constant values.

This commit **refactors** the **Rust Thrift generator** by directly switching its base class from the `t_mstch_generator` compatibility layer to the `t_whisker_generator` templating engine. This **upgrade** involves replicating necessary methods and significantly updating the generator's internal logic, including prototype definitions for `service`, `function`, `typedef`, `program`, and `interaction`. Key changes ensure correct `service:*` template lookups for interactions, proper contextual `parent_service_name` for shared interactions, and prevent qualifier shadowing in `{{#typedef:type}}` blocks. The `mock.rs.mustache` template is also updated to align with the new templating engine's features, ultimately **improving the robustness and maintainability** of the Rust code generation.

This commit performs a **significant refactoring and migration** within the **Rust Thrift compiler**, transitioning the generation of **structural properties** like `struct`, `field`, and `const` from the **Mustache templating engine to Whisker**. It updates `t_mstch_rust_generator.cc` to remove Mustache-specific value classes, integrating their functionality into Whisker prototypes, and adjusts structured annotations and program generation logic. Concurrently, the `lib/value.mustache` template is refactored to adopt Whisker-compatible syntax, replacing legacy Mustache references. This internal architectural change streamlines the templating process by removing a Mustache-specific map for identifier positions, now accessed via `rust_context_->get_info(&self)`. The overall impact is a cleaner, more maintainable codebase for Rust code generation within the Thrift compiler.

This commit **refactors** the **Rust code generation** by migrating `nonstandardTypes` and `nonstandardFields` from `rust_mstch_program` properties to **Whisker prototypes** on `t_program`. It updates the `mod.impl.mustache` template to use new conditional logic, `{{#if type:i64?}}{{#if (not (and type:typedef? typedef:newtype?))}}`, which leverages Whisker's short-circuiting `and` to ensure **correct type handling** for `typedef:newtype?` checks. Additionally, this change **fixes type resolution** for container sub-type accessors (`list_elem_type`, `set_elem_type`, `key_type`, `value_type`) on the `t_type` Whisker prototype, ensuring they correctly follow typedefs via `get_true_type()` to match prior `mstch` behavior. This work improves the robustness and consistency of **type metadata access** within the code generation system.

This commit **refactors** the **Rust Thrift code generation** by migrating various function and service properties from the legacy `mstch` system to the **Whisker templating engine**. It completely removes the custom `rust_mstch_function` and `rust_mstch_service` classes, replacing their functionality with direct Whisker prototypes for properties like `index`, `uniqueExceptions`, `rustFunctions`, `rust_exceptions`, and `extendedClients`. This **migration** simplifies the `thrift/compiler/generate/t_mstch_rust_generator.cc` and updates numerous **Rust code generation templates** to use the new `service:functions` and `service:exceptions` properties. The change streamlines property access within the **Rust code generation templates**, moving towards a more unified and efficient Whisker-based generation process.

This commit **establishes core infrastructure** within the **Rust generator** to facilitate an incremental migration of `mstch_rust_value` properties to Whisker prototypes. It introduces a `rust_const_value_info` struct for pre-computed constant data and a `rust_generator_context` class to manage AST visitors that populate this information. The `t_mstch_rust_generator` is updated to initialize this context and enable `value:self` registration on `mstch_rust_value`, allowing future access to migrated properties. This foundational work prepares the Rust code generation for enhanced constant value processing and metadata handling.

This commit **refactors** the **Rust code generation** process by migrating all remaining split-mode properties from the now-removed `rust_mstch_program` class to Whisker prototypes on `t_program`. This **simplifies the generator architecture** by consolidating split-related state and logic directly into the `t_mstch_rust_generator` class, leveraging Whisker's lazy evaluation to reuse a single `cached_program()` object across different split renders. The split computation logic is also **consolidated** into a new `initialize_type_splits()` method, streamlining the overall process. This change **optimizes resource usage** and **reduces complexity** within the Rust Thrift compiler's code generation pipeline.

This commit **refactors** the **Thrift compiler's Rust code generation templates** to standardize type accessor naming conventions. It **renames** several template type accessors, such as `list_elem_type` and `key_type`, to adopt a new **Whisker dot-access convention** using `true_type` (e.g., `true_type.elem_type`, `true_type.key_type`). This **maintenance** change primarily affects the **`rust/lib` templates** (`arg_inner.mustache`, `mod.impl.mustache`, `type_generics.mustache`), ensuring consistent type introspection within the generated Rust code. The `t_mstch_rust_generator.cc` file also receives minor string formatting refactoring to align with these updates, improving the overall clarity and maintainability of the **Rust code generation logic**.

This commit **refactors** the **Thrift compiler's Rust generator** and its associated **Mustache templates** by renaming `mstch` method registrations and template references. Specifically, `constant:rust` is updated to `constant:value` and `field:default` to `field:default_value` within `t_mstch_rust_generator.cc` and the `const.mustache`, `structimpl.mustache`, and `value.mustache` templates. This **refactoring** aligns these `mstch` method names with the underlying base Whisker prototype property names, such as `t_const`'s `value` and `t_field`'s `default_value`. The change is a **preparation for the eventual removal of `mstch` subclasses** and introduces no behavioral changes, as `mstch` methods already take precedence.

This commit **migrates** the `program:adapters` and `program:adapted_structs` properties from `rust_mstch_program` to **Whisker prototypes**, streamlining the Rust code generation process. It **refactors** how adapter type aliases are generated, simplifying the `lib/mod.adapters.mustache` template from a multi-line block to a single line. A key part of this change involves updating the `t_type::adapter_name` property to correctly resolve polymorphic types, ensuring proper dispatch for both `t_structured` and `t_typedef` types. This improves the accuracy and maintainability of **Rust adapter generation** within the Thrift compiler by leveraging the new Whisker system.

This commit delivers a **bug fix** for the **Rust code generator** within the Thrift compiler, resolving a **recursive type alias cycle** that affected **adapted structs with generic adapters**. The `compute_rawtype_name` function in `t_mstch_rust_generator.cc` was updated to correctly include the `::unadapted::` path segment for structured types that utilize adapters. This prevents generic adapter type parameters from incorrectly resolving to adapted type aliases, thereby eliminating the infinite recursion during type resolution. The fix ensures the correct compilation and functionality of generated Rust code for complex adapted types.

This commit **refactors** the **Rust Thrift compiler's client template** (`client.mustache`) by updating its boolean conditional syntax. It transitions from the Mustache `?` suffix to the more explicit `if` helper syntax, aligning with what's referred to as Whisker syntax. This change impacts numerous conditional sections within the template, including checks for `type:has_adapter`, `service:extends`, and `function:args`. The work is a **maintenance** improvement aimed at **modernizing and standardizing the template's internal logic**, ensuring consistent code generation without altering the functionality of the generated Rust client code.

This commit **refactors** the `thrift/compiler/generate/templates/rust/lib/method_metadata.mustache` template within the **Thrift compiler's Rust generator**. It converts complex, nested boolean conditionals, particularly for `RpcKind` selection and service interaction checks, into cleaner `{{#if}}...{{#else if}}...{{/if}}` chains using **Whisker syntax**. This change significantly improves the readability and maintainability of the template code by simplifying its conditional logic. The update is purely a **template syntax modernization** and does not alter the generated Rust code or its runtime behavior.

This commit **refactors** the **Rust code generation templates** for client and server traits by migrating their boolean conditional logic from Mustache to Whisker syntax. Specifically, `client_trait.mustache` and `server_trait.mustache` are updated to use Whisker for checks like `service:docs?` and `function:docs?`. This **internal templating language update** improves consistency within the **Thrift Rust code generator** without altering the generated Rust code's functionality. Context-switching logic within these templates, such as `service:rustFunctions`, remains in Mustache to preserve existing template behavior.