Christof Marti

This commit **enhances the robustness of the chat setup process** by improving its timeout recovery mechanism. It **refactors the computation of diagnostic information** into a new private method, `computeDiagnosticInfo`, within `src/vs/workbench/contrib/chat/browser/chatSetup/chatSetupProviders.ts`. The primary goal is to add **comprehensive logging and telemetry** to better understand and recover from chat setup timeouts, ensuring a more stable user experience. This **maintenance and improvement** work provides better insights for debugging and future enhancements to the **Chat feature**.

This commit introduces a significant **refactoring** of the **Copilot extension's WebSocket communication management** to establish and maintain a single, persistent WebSocket connection per conversation. The `chatWebSocketManager.ts` now internally handles `turnId` for individual requests, superseding active requests when new ones arrive on the same conversation to ensure efficient resource utilization. This change optimizes the communication flow for chat interactions, affecting modules like `chatMLFetcher.ts` and `chatEndpoint.ts` by simplifying their connection logic. The update aims to improve performance and resource management by reducing connection overhead, with new tests verifying cross-turn reuse and request superseding.

This commit significantly enhances the **Copilot extension's WebSocket communication** by implementing robust **CAPI error handling**, particularly for **rate limiting and quota exhaustion**. It introduces new logic within `chatMLFetcher` and `chatWebSocketManager` to process server-provided quota snapshots and manage stream termination events, ensuring the user's quota information is accurately updated via the `chatQuotaService`. This **feature development** improves the reliability and user experience of chat features by providing clearer feedback on usage limits and extends telemetry to capture new WebSocket error outcomes, alongside adding a debug configuration for simulating WebSocket responses.

This commit **enhances the diagnostic capabilities and robustness** of the **Copilot extension's WebSocket networking**. It **refines error handling** within `extensions/copilot/src/platform/networking/node/chatWebSocketManager.ts` to ensure that the specific reason for a WebSocket connection closing, including detailed error messages, is consistently captured and passed to the connection close event. Concurrently, the `extensions/copilot/src/platform/networking/node/chatWebSocketTelemetry.ts` module is **refactored** to remove the now redundant `connection_error` type, as error reporting is consolidated. This **fix and refactoring** effort provides **more accurate and comprehensive telemetry** regarding WebSocket connection stability, significantly aiding in the identification and resolution of network-related issues.

Update dependencies (#4664)

This commit introduces a **feature enhancement and refactoring** to **Copilot's networking infrastructure**, specifically improving **WebSocket connection management and traceability**. It refactors the `chatWebSocketManager` to introduce an explicit `connect()` method, separating connection establishment from retrieval, and exposes `requestId` and `gitHubRequestId` properties for better identification. The `chatMLFetcher` is updated to utilize this new `connect()` method and **attach the GitHub request ID to connection errors**, which will significantly aid in **diagnostics and debugging** of Copilot's interactions with GitHub services. Test cases were also updated to reflect these changes.

This commit introduces a **new telemetry feature** to enhance the monitoring of **Copilot chat WebSocket interactions**. It integrates logic within the `chatWebSocketManager.ts` to determine and pass two new properties, `previousResponseIdUnset` and `hasCompactionData`, to the telemetry system. The `chatWebSocketTelemetry.ts` module is updated to include these properties in the `sendRequestSentTelemetry` and `sendRequestOutcomeTelemetry` events. This improvement provides crucial insights into the statefulness of chat responses and the occurrence of data compaction, aiding in the analysis and optimization of the **Copilot chat experience**.

This commit **enables by default** the `chat.advanced.chatRequestPowerSaveBlocker` setting within the **Copilot extension's chat functionality**. This **configuration update** changes the default value from `false` to `true`, ensuring that the power save blocker is active for all users without manual intervention. This modification impacts how the system handles power management during Copilot chat requests, potentially improving the reliability or responsiveness of these interactions by preventing power-saving interruptions.

This commit **refactors** and **enhances** the **Copilot chat networking layer** to accurately convey whether a request was user-initiated. Specifically, it modifies the `chatWebSocketManager`'s `sendRequest` method to include an `initiator` field in `response.create` messages, falling back to request headers if needed. The `chatMLFetcher` is updated to pass this `userInitiated` flag, and new **unit tests** are added to `chatWebSocketManager.spec.ts` to validate the correct propagation of the `initiator` field. This ensures the backend receives crucial metadata about the origin of chat requests, improving telemetry and service behavior.

This commit introduces a **bug fix** within the **telemetry collection** for **certificate errors** in the `proxyResolver` module. It adds a new function, `sanitizeCertErrorMessage`, which is integrated into `collectNodeSystemCertErrors` to preprocess and **sanitize certificate error messages**. This crucial change prevents **false-positive redaction** by the telemetry scrubbing regex, ensuring that valuable diagnostic information is not inadvertently removed. The fix improves the accuracy and completeness of collected telemetry data, aiding in better understanding and resolving network-related issues.

This commit performs a **dependency update**, upgrading the `@vscode/proxy-agent` package to version `0.40.0`. This **maintenance** task ensures the application benefits from the latest improvements and fixes in the upstream proxy handling library. The update primarily affects the **network request subsystem**, enhancing its reliability and compatibility when operating in environments that require a proxy. This change improves the overall stability and performance of proxy-aware operations by incorporating the latest advancements in the `proxy-agent` functionality.

This commit **enhances the diagnostic capabilities** for **Copilot WebSocket connection failures** by capturing and logging the HTTP response status code and status text. It **modifies the `WebSocketConnection` interface** and the `createWebSocket` function to store these critical details, which are then included in the `sendConnectErrorTelemetry` event. This **fix** significantly improves the **observability and diagnosability of connection issues** within the **Copilot extension's networking stack**, providing essential context for debugging server-side or proxy-related problems. A refactor also centralizes the `createWebSocket` implementation to reduce duplication.

This commit introduces a **new feature** to enhance **telemetry collection** by specifically capturing Node.js system certificate errors. It modifies the **proxy resolution module** (`src/vs/workbench/api/node/proxyResolver.ts`) to include a new function, `collectNodeSystemCertErrors`, which gathers these critical error details. The collected certificate errors are then incorporated into the existing "additional certificates" telemetry event. This provides crucial diagnostic information for understanding and resolving connectivity issues stemming from **system certificate trust problems** in Node.js environments.

This commit introduces a **new developer command** within the **Copilot extension** to enhance diagnostic capabilities for Node.js system certificate issues. It registers a command that allows developers to collect and display detailed information and errors related to Node.js system certificates. This **feature enhancement** provides a crucial tool for troubleshooting connectivity problems and ensuring secure operations, directly impacting developer experience when dealing with certificate-related failures. The change includes adding a localized string for the command and implementing its registration logic in `loggingActions.ts`.

Publish after extension (#4517)

This commit **fixes a bug** within the **Copilot extension's logging service** that caused error messages to display as the unhelpful `[object Object]`. It resolves this by **removing the `e.toString?.()` call** from the `collectErrorMessages` and `collectSingleLineErrorMessage` functions in `extensions/copilot/src/platform/log/common/logService.ts`. This **enhances the clarity and usefulness of error reporting**, making it easier to diagnose issues within the Copilot extension by providing meaningful error strings instead of generic object representations.

This commit introduces **proxy support for WebSocket connections** within the **Copilot extension's networking services**. The `createWebSocket` function in `extensions/copilot/src/platform/networking/vscode-node/fetcherServiceImpl.ts` has been modified to prioritize retrieving response headers directly from the WebSocket object when available. This ensures proper handling of headers that may be modified or added by a proxy during the WebSocket handshake. This **enhancement** significantly improves the **Copilot extension's** compatibility and reliability in network environments requiring **proxy connections for WebSocket communication**.

This commit introduces **proxy support for WebSockets**, enhancing network connectivity for users operating in restricted network environments. It adds a new configuration setting, `http.webSocketAdditionalSupport`, within the **platform request module** to control this feature. The core logic is implemented in `src/vs/workbench/api/node/proxyResolver.ts`, which **patches the global WebSocket object** to route connections through configured proxies. This **new capability** allows the application to properly establish WebSocket connections when a proxy is required, significantly improving network compatibility.

This commit introduces a **new capability** to track a `statefulMarker` within **Copilot's WebSocket connections**, specifically for chat-related features. The `chatWebSocketManager` now maintains this marker to track the last completed response ID, integrating it into request handling and telemetry. This enhancement also updates `chatWebSocketTelemetry` to include a `statefulMarkerMatched` property in event data, providing richer insights into WebSocket request outcomes. A minor **refactoring** in `chatMLFetcher.ts` removes an unnecessary type assertion when sending requests via the WebSocket connection. This work improves the state tracking of WebSocket requests and enhances telemetry for the **Copilot extension**.

This commit **reverts** a previous **refactoring** that converted numerous private fields and methods within the **inline chat feature** to use private class fields. It **undoes** these changes across various core components, including `inlineChatSessionServiceImpl`, `inlineChatController`, `inlineChatWidget`, and UI elements like `inlineChatZoneWidget` and `inlineChatEditorAffordance`. As a result, these **inline chat classes** will revert to their prior implementation for private members, effectively rolling back the adoption of private class fields for this subsystem. This **maintenance** task likely addresses issues or reconsiders the architectural approach introduced by the original commit.