Christoph Purrer

This commit introduces a **centralized `ReservedPrimitiveTypes.js` registry** and a shared `toSafeIdentifier` helper within the **React Native codegen system**. This **refactoring** effort aims to **reduce duplication and inconsistency** in primitive type mappings for C++ and Java generators, and standardize identifier capitalization across the codebase. By consolidating type definitions and string handling into single sources like `ReservedPrimitiveTypes.js` and `Utils.js`, the change improves the **maintainability and reliability** of the codegen output. This ensures more consistent type support and identifier generation for native modules, while also performing **maintenance** by removing obsolete code from various parser files.

This commit **refactors** the **React Native bridging mechanism** by conditionally compiling the `RCTGetModuleClasses` function within `RCTBridge.mm`. Specifically, when the `RCT_REMOVE_LEGACY_ARCH` flag is defined, this function will now return an empty array, effectively disabling its functionality. This **maintenance** change is crucial for **preparing React Native for the complete removal of the legacy architecture**, ensuring that the system behaves correctly and avoids issues when legacy components are no longer present. It streamlines the codebase by excluding legacy-specific logic when it's no longer needed.

This commit performs a significant **refactoring** within the **`react-native-codegen`** tool, specifically in the `GenerateModuleObjCpp` module responsible for Objective-C code generation. It **deduplicates** the `toObjCType` function, which was previously duplicated across `serializeConstantsStruct.js` and `serializeRegularStruct.js`, by extracting it into a new shared utility file, `serializeStructUtils.js`. The generalized `toObjCType` now accepts a `structContext` parameter, allowing it to handle specific differences for `CONSTANTS` and `REGULAR` struct serialization, thereby improving code maintainability and reducing redundancy in the **Objective-C type mapping logic**.

This commit **adds comprehensive unit tests** for the `DoubleConversions::toString(double, char)` function within the **`react/renderer/graphics` module**. The new tests in `DoubleConversionsTest.cpp` validate the function's behavior across a wide range of inputs, including zero, positive/negative integers, fractional values, very small/large numbers, scientific notation, and special values like infinity and NaN. This **improves the reliability and robustness** of double-to-string conversions by ensuring correct handling of various numerical scenarios and suffix appending, including null suffixes and their interaction with special values.

This commit delivers a **bug fix** for the **React Native TurboModule C++ codegen**, specifically addressing an issue where custom struct types wrapped in `Readonly` or `$ReadOnly` utility types were silently dropped. Previously, the `getObjectTypeAnnotations` function within the `parsers-commons.js` module failed to correctly parse these types, leading to incomplete or incorrect C++ code generation for `cxxOnly` specifications. The **type parsing logic** has been enhanced to explicitly unwrap `GenericTypeAnnotation` (Flow) and `TSTypeReference` (TypeScript) nodes representing these `Readonly` wrappers. This ensures that **TurboModules** can now accurately process and generate C++ code for such common type definitions, validated by an update to `NativeCxxModuleExample.js`.

This commit delivers two distinct **bug fixes** to enhance the stability and correctness of the React Native framework. It resolves a `bugprone-use-after-move` error within the **JSI Native Modules** (`JSINativeModules.cpp`) by ensuring `moduleName` is correctly accessed from the map iterator after its initial move. Concurrently, it addresses a `bugprone-optional-value-conversion` in **Text rendering attributes** (`TextAttributes.cpp`), simplifying the assignment of `textShadowOffset` by directly using the optional value and eliminating an unnecessary round-trip conversion. These improvements prevent potential undefined behavior and streamline code in critical runtime and rendering components.

This commit performs a **refactoring** within the **ReactCommon** module to **optimize build performance** by removing unnecessary header inclusions. It **removes unused `folly` and `sstream` headers** from various files, and replaces `<iostream>` with `<iosfwd>` in `JsErrorHandler.h` for better compilation efficiency. Specifically, the `<sstream>` header is now conditionally included in `ColorStop.h`, `LinearGradient.h`, and `RadialGradient.h` only when `RN_DEBUG_STRING_CONVERTIBLE` is defined. This targeted cleanup reduces redundant dependencies across the `jserrorhandler` and `react/renderer/graphics` components, potentially leading to faster compilation times for React Native.

This commit **restores** the **C++ Turbo Module example** within the **RNTester application**, which was inadvertently removed in a previous change. It brings back the `TurboCxxModuleExample.js` file and re-registers it in the **RNTesterList** for **Android** and **iOS**. This **fix** ensures that developers can once again access and test the `NativeCxxModuleExampleExample` through the `TurboCxxModuleExample` wrapper. The primary impact is on the **RNTester's example suite**, making the **C++ Turbo Module demonstration** fully functional again across these platforms.

This commit **removes the `TurboCxxModule` infrastructure**, marking a **breaking change** within the React Native framework. It deprecates and eliminates the specific C++-based module type, streamlining the **TurboModule system** by removing an older implementation path. This change impacts any existing native modules that were implemented using `TurboCxxModule`, requiring them to migrate to alternative TurboModule implementations. This is a **general cleanup and modernization effort**, simplifying the core architecture and reducing maintenance burden.

This commit **enhances the React Native image rendering system** by ensuring that the view's width and height are correctly propagated to the image prefetcher. It **modifies the `ImageShadowNode`** to pass these dimensions to the `ImageRequestParams` structure, which now includes a new `Size` member. This **new capability** is crucial for the **`ImageManager`** to accurately handle image resize requests and perform correct resource prefetching, preventing incorrect image scaling or unnecessary re-fetches. The changes also involve updating serialization keys in `conversions.h` to accommodate these new view dimensions, improving the overall accuracy of image resource management.

This commit delivers a **bug fix** for the **React Native C++ renderer**, specifically addressing the **Image component's property handling**. It ensures that the `resizeMethod` and `resizeMultiplier` properties of `ImageProps` are correctly initialized with their default values, which were previously not being properly parsed in the C++ layer. By adding in-class default member initializers in `ImageProps.h` and updating the `ImageProps` constructor in `ImageProps.cpp`, this change resolves a parsing issue that could lead to incorrect image rendering behavior on Android. This improves the reliability of the **Image component's** default property application within the C++ rendering pipeline.

This commit **re-enables JNI batching for image prefetching requests** within the **React Native Android image subsystem**, specifically affecting `ImageFetcher` and `ImageManager`. This **performance optimization** introduces conditional batching for `requestImage` calls, aiming to reduce JNI overhead by processing multiple image requests in a single batch. The flushing of these batched requests is integrated into the `FabricUIManagerBinding`'s render transactions, ensuring timely processing. This re-introduction of batching is a refined approach, addressing stability issues encountered in prior attempts, and should lead to improved efficiency and responsiveness for image loading on Android.

This commit **reintroduces a feature flag** named `enableImagePrefetchingJNIBatchingAndroid` within the **React Native feature flag system**. This flag provides explicit control over whether **JNI batching is enabled for image prefetching on the Android platform**. The work involves adding the flag's definition, accessors, and default value across Kotlin, C++, and JavaScript components of the `ReactNativeFeatureFlags` system. This **configuration management** allows developers to dynamically enable or disable a specific performance optimization related to image loading and JNI communication, impacting the **Android image prefetching subsystem**.

This commit **fixes** the `equals` method within the **Fresco Vito** `ImageOptions` class. The **bug fix** modifies the `equals` implementation to now conditionally include all fields in the comparison, governed by a new static flag. This **maintenance** ensures that `ImageOptions` objects are correctly compared, which is critical for reliable caching, deduplication, and state management within the **Fresco Vito** library.

This commit **completes the removal of CxxModule support** from the **React Native Android C++ JNI layer**, marking a significant **breaking architectural cleanup**. It **refactors** the native module registration and initialization process by eliminating the `cxxModules` parameter and associated logic from `CatalystInstanceImpl` and `ModuleRegistryBuilder` functions like `initializeBridge`, `extendNativeModules`, and `buildNativeModuleList`. Additionally, `TurboModuleManager` is updated to remove references to deprecated CxxModule headers, streamlining the codebase. This change simplifies the internal module system by removing a legacy implementation, impacting any native modules that previously relied on the CxxModule C++ interface.

This commit performs a significant **refactoring** within the **React Native Android** codebase, specifically targeting the **removal of CxxModule-related logic** from the Java/Kotlin side. It eliminates references to `CxxModuleWrapper` and hardcodes the `isCxxModule` flag to `false` across `ReactPackageTurboModuleManagerDelegate` and `ModuleHolder`, effectively deprecating this module type. Furthermore, the `NativeModuleRegistry` is refactored to remove `getCxxModules` and related filtering, while `TurboModuleManager` loses `getLegacyCxxModule` and `getTurboLegacyCxxModule` methods. This **breaking change** simplifies the module system by removing support for CxxModules, streamlining the core module management infrastructure.

This commit **removes CxxModule support** from the **`CatalystInstance`** within the **React Native Android bridge**. It modifies the `initializeBridge` and `extendNativeModules` methods across Java (`CatalystInstanceImpl.java`) and C++ (`CatalystInstanceImpl.cpp`, `CatalystInstanceImpl.h`) implementations to no longer accept or process `CxxModules`. This is a **breaking change** that simplifies the core bridge initialization logic by deprecating and eliminating a legacy module registration mechanism. The removal streamlines the `CatalystInstance` interface and its underlying implementation, impacting any code that previously relied on `CxxModule` integration via these methods.

This commit performs a **major refactoring** by **removing the deprecated `RCTCxxModule` system** entirely from the React Native core. This **breaking change** eliminates all associated logic and imports within the **CxxBridge**, **Cxx module utilities** (`RCTCxxUtils.mm`), and the **TurboModule manager** (`RCTTurboModuleManager.mm`). Specifically, it removes conditional checks for `RCTCxxModule` during module loading, the creation of `CxxNativeModule` instances from `RCTCxxModule` classes, and all handling of `RCTCxxModule` within the TurboModule system, including functions like `createNativeModules` and `getLegacyModule`. This streamlines the module loading architecture by removing a legacy path, requiring any modules still using `RCTCxxModule` to be migrated to modern native module interfaces.

This commit introduces **default initialization** for properties within custom C++ structs generated by the **React Native Codegen** tool. It modifies the `GenerateModuleH.js` generator to append `{}` to member declarations in C++ header files for **TurboModules**, ensuring all struct members are properly zero-initialized or default-constructed. This **fix** addresses a potential source of undefined behavior by preventing uninitialized member variables in generated C++ code. The change significantly enhances the **robustness and safety** of TurboModule integration, improving the overall stability of React Native applications that utilize these modules.

This commit **improves testability** for the **React Native Android image view system** by adjusting the visibility of an internal field. Specifically, it **refactors** the `MultiPostprocessor` class within `com.facebook.react.views.image` by changing the `postprocessors` field from `private` to `internal`. This modification allows internal test suites to access and inspect the list of image post-processors, enabling more thorough testing of image processing logic. The change is a **maintenance** task focused on **testability improvement** and has no impact on the public API or runtime behavior for end-users.