Carlos Zamora

This commit provides a **bug fix** for the **TerminalControl** module, addressing an issue where **selection markers** would erroneously appear when scrolling during **mouse selection**. The `TermControl.cpp` file's scroll handler is updated to check the current **selection mode** before rendering these markers. This ensures that selection markers are only displayed for **keyboard-based selections**, preventing visual artifacts and improving the user experience by correctly hiding markers during mouse-driven scrolling.

This commit **fixes a bug** where restarting a terminal connection would not properly reset the internal **VT state**, leading to lingering escape sequences like mouse mode. It introduces an `erase` parameter to `ITermDispatch::HardReset()` and exposes a new `HardResetWithoutErase()` method through the `Terminal`, `ControlCore`, and `TermControl` layers. The **terminal connection restart mechanism** in `TerminalPage::_restartPaneConnection()` now utilizes this new method to reset the VT state machine without clearing the buffer. This **refactoring** and **bug fix** significantly improves the **user experience** by ensuring a clean terminal state upon reconnection while preserving the session history.

This commit implements a **new capability** to correctly set the AppUserModelID (AUMID) for **unpackaged Windows Terminal** instances. The `WindowEmperor.cpp` module now generates a unique AUMID, incorporating the application's branding, a hash of the full process image name, and the user's SID hash. This **feature implementation** ensures proper shell integration, such as taskbar pinning and jump lists, for users running the unpackaged version of the terminal. Specifically, the logic within `HandleCommandlineArgs` is enhanced to manage this identification.

This commit **fixes a theming bug** in the **TerminalSettingsEditor** where the search dropdown did not correctly inherit the terminal's theme. Previously, popups, being in a separate UI tree, would not apply the theme, leading to visual inconsistencies. A new helper function, `_setThemeOnPopups`, was added to `src/cascadia/TerminalSettingsEditor/MainPage.cpp` to recursively apply the theme to these popups. This function is now called during `OnNavigatedTo` and `_ApplyTheme` to ensure the **search dropdown's theme correctly matches the terminal's theme**, improving visual consistency for users.

This commit **significantly improves the user experience for selection within VT mouse mode** by addressing several inconsistencies. It **fixes bugs** related to selection accuracy, such as preventing coordinate rounding and correcting drag-left behavior to include the starting cell. Crucially, **Shift+Click now clears any existing selection** to initiate a new one, making the interaction more intuitive. These enhancements primarily affect the **TerminalControl** module's `ControlCore.cpp` and `ControlInteractivity.cpp` components, ensuring a more precise and consistent selection process.

This commit **fixes a bug** within the **`TerminalControl`** module where selection markers would incorrectly disappear after being scrolled out of view and then back. The change in `src/cascadia/TerminalControl/TermControl.cpp` modifies the condition for updating these markers, now checking for the existence of a selection rather than their visibility. This ensures that selection markers persist reliably across scrolling actions, significantly improving the user experience for text selection.

This commit **refactors** the **TextBuffer**'s word expansion logic, simplifying multiple `GetWordStart`/`GetWordEnd` variants into unified APIs. It removes several specialized functions like `GetWordStart2()` and `_GetWordEndForSelection()`, standardizing word boundary calculations across the system. This change impacts **TerminalSelection** and **UiaTextRangeBase**, ensuring consistent word movement and selection behavior for accessibility tools and mouse interactions. Unit tests were updated to reflect new exclusive end positions and improved wrap-crossing behavior, preventing regressions and enhancing overall code maintainability.

This commit **fixes several memory leaks** within the **UI Automation (UIA) subsystem** of the Terminal Control. Previously, `ITextRangeProvider` objects, such as `UiaTextRange`s, were not being properly destroyed after use by screen readers, leading to persistent memory consumption. The **bug fix** involves correctly managing parent providers in `InteractivityAutomationPeer`, clearing circular references in `TermControlAutomationPeer`, and adjusting ownership transfers in `ScreenInfoUiaProviderBase` and `SafeArrayToOwningVector`. This ensures that **UIA objects are promptly deallocated**, significantly improving the stability and resource efficiency of the terminal, particularly for users relying on accessibility features.

This commit **fixes a bug** in **hyperlink detection** where partially visible URLs were not recognized, and **refactors** the underlying coordinate system. It expands the search area for patterns and transitions the `_patternIntervalTree` to operate in **absolute-buffer space** instead of viewport-relative coordinates, ensuring URLs cropped off-screen are correctly identified. This change also resolves issues with **mark mode hyperlink navigation** by consistently using buffer-absolute coordinates, improving the reliability of selecting and interacting with hyperlinks across the `TerminalCore` module. New tests validate the improved detection for various visibility scenarios, enhancing the overall user experience.

This commit **resolves a spellcheck warning** within the `tools/GenerateSettingsIndex.ps1` script by introducing commas into existing comments. Specifically, it addresses a "to for" pattern that was flagged as grammatically incorrect, thereby improving the **readability and adherence to style guidelines** of the script's internal documentation. This is a **maintenance change** focused on code quality, ensuring the script's comments are grammatically sound. The modification has no functional impact on the execution or behavior of the `GenerateSettingsIndex.ps1` script.

This commit **refactors** the settings search index generation process, primarily by overhauling the `tools/GenerateSettingsIndex.ps1` script and updating related C++ components in the `TerminalSettingsEditor`. The PowerShell script now leverages **XML parsing for XAML files** and a class map to more accurately generate search index entries, addressing previous feedback. Corresponding C++ files like `SearchIndex.cpp` and `SearchIndex.h` are updated to align with these changes, refining the handling of **resource names and navigation arguments** for search entries. This work **polishes** the index generation, ensuring the settings UI search functions correctly and robustly.

This commit **refactors** the **Settings UI navigation** logic within `MainPage.cpp` and `MainPage.h` to improve maintainability and reduce complexity. It consolidates multiple `_Navigate()` functions into a single, unified method, streamlining how the **Terminal Settings Editor** handles navigation to various pages like profiles, color schemes, and actions. This **refactoring** effort also deduplicates `SettingsNav().SelectedItem()` calls and removes unnecessary element staging behavior for subpages. The change simplifies the underlying navigation mechanism, making the settings UI more robust and easier to extend in the future.

This commit introduces a **new search functionality** to the **Terminal Settings UI**, enabling users to quickly find and navigate to specific settings. It involves a new `GenerateSettingsIndex.ps1` script to build a search index from XAML files, a sophisticated weighted search algorithm in `SearchIndex.cpp` utilizing `fzf` for fuzzy matching, and UI integration via an `AutoSuggestBox` in `MainPage.xaml`. This **feature enhancement** significantly **improves the discoverability and usability** of settings by allowing direct navigation and focus on the desired configuration option. Additionally, it includes refactoring the `fzf` dependency and adding `x:Name` attributes to numerous `SettingContainer` elements across various settings pages to facilitate programmatic navigation.

This commit introduces a **bug fix** within the **TerminalApp** to resolve inconsistent behavior when using the **broadcast input feature**. It **refactors the paste logic** in `src/cascadia/TerminalApp/TerminalPage.cpp` to ensure that text pasted via the **mouse** is now correctly **broadcast to all active panes**. Previously, only keyboard-initiated pastes were broadcast, leading to a functional discrepancy. This change significantly improves the reliability and consistency of the **broadcast input feature** for users, making mouse paste behave as expected.

This commit **refactors** the **Terminal Settings Editor (SUI)** by **standardizing the navigation argument types** used throughout its various pages. It replaces disparate `NavigateToXArgs` structures with a unified `NavigateToPageArgs` across numerous `OnNavigatedTo` methods and internal navigation calls. This change affects almost all sub-pages and view models within the settings UI, including `Actions`, `AddProfile`, `ColorSchemes`, `GlobalAppearance`, `Launch`, and various `Profiles` sections. The primary goal is to improve code consistency and maintainability, simplifying the internal navigation logic and reducing complexity for future development in the settings interface.

This commit implements a **bug fix** to resolve a **memory leak** within the **TerminalSettingsEditor** by addressing circular references involving `IHostedInWindow` and `WindowRoot`. It primarily involves **refactoring** various components, including `MainPage`, `NewTabMenu`, `IconPicker`, and several `Profile` view models, to replace strong references to these window-hosting interfaces with weak references. Additionally, null checks are introduced for `WindowRoot` access points to enhance safety. This change ensures that UI elements and their associated view models are properly deallocated when the settings UI is closed, preventing memory accumulation and improving the overall resource efficiency and stability of the application.

This commit introduces a **new `IconPicker` control** by extracting and generalizing the icon selection logic previously embedded in the **Profile settings** UI. This **refactoring** simplifies icon management across the application and enables a **new capability** for users to assign custom icons to folders within the **New Tab Menu**. The `IconPicker` supports various icon types (none, built-in, emoji, file) and includes performance improvements like lazy loading. Additionally, navigation to the `NewTabMenu` is standardized via a new `NavigateToPageArgs` structure. This change significantly enhances the customization options for the **New Tab Menu** and improves code reusability for icon selection throughout the **Terminal Settings Editor**.

This commit significantly **improves accessibility** for the **terminal search box** by enhancing screen reader announcements. It addresses inconsistencies where search results were not always read aloud and refines the spoken status messages to be more descriptive and accurate for visually impaired users. Specifically, the `_FormatStatus` method in `SearchBoxControl.cpp` now includes an `isAccessible` parameter to generate clearer messages, replacing ambiguous symbols like `?` and `+` with full words and rephrasing fractions (e.g., "4/5" becomes "4 of 5"). This ensures a more reliable and understandable user experience when navigating search results with a screen reader.

This commit **adds tooltips** to various UI elements within the **Terminal Settings Editor** to prevent text truncation. Specifically, it introduces tooltips for both static and dynamically generated **navigation view items** in the settings UI, and for **color scheme names** displayed in the profile appearance settings combo box. This **new feature** significantly enhances usability by ensuring all text is accessible to users, addressing potential information loss. A minor **refactoring** in `src/cascadia/TerminalSettingsEditor/MainPage.xaml` was performed to add `x:Name` attributes, enabling programmatic access for setting these tooltips via `MainPage.cpp`.

This commit **improves accessibility** for the **font features and axes controls** within the Terminal's settings editor. It explicitly adds the `AutomationProperties.Name` property to UI elements such as list view items, number boxes, and delete buttons, allowing screen readers to correctly identify and announce them. This **accessibility enhancement** is implemented by introducing an `AutomationName` method to the `FontKeyValuePair` class and updating the `Appearances.xaml` and resource files. The change provides a more inclusive user experience for individuals interacting with the **font customization settings**.