Atishay Jain (atisjai)

This commit delivers a critical **security fix** and **stability improvement** for the **`VegaDeclarativeChart` component** within the Fluent UI React Charts library. It replaces the previously unsafe `new Function` based expression evaluation with a new `safeEvaluateExpression` function, implemented as a **recursive-descent parser**, to prevent **arbitrary code execution** from malicious Vega-Lite expressions. Additionally, **JSON depth validation** is introduced to safeguard against denial-of-service attacks caused by excessively deep specifications. The `VegaLiteSchemaAdapter` now exclusively uses this secure evaluator for all data transformations and conditional styling, ensuring a significantly more robust and secure charting experience. Comprehensive unit and security tests have been added to validate the new evaluation logic and input validation.

This commit introduces a **new capability** to the **`react-charting`** library, enabling proper support for `min` and `max` Y-axis values in **Vertical Stacked Bar Charts (VSBC)** rendered via **Plotly**. The `PlotlySchemaAdapter.ts` file is updated to integrate the extraction and application of these Y-axis bounds, specifically within the `transformPlotlyJsonToVSBCProps` function. This **enhancement** ensures that `VSBC`s can now accurately reflect desired Y-axis scaling, providing more control over data visualization and preventing unintended auto-scaling behaviors for charts utilizing the `DeclarativeChart` component.

This commit introduces a **bug fix** within the **`react-charting` package**, specifically addressing rendering behavior for the `FunnelChart` component. It **disables the responsive container** for `FunnelChart` when it is utilized within the `DeclarativeChart`. The change ensures that `FunnelChart` is now directly used as the renderer in `DeclarativeChart.tsx`, resolving potential layout or sizing issues that arose from the previous responsive wrapping. This improves the stability and correct display of `FunnelChart` instances in declarative chart configurations.

This commit delivers a **bug fix** within the **`@fluentui/react-charting`** package, resolving an issue where **hover cards** failed to display properly for **LineChart** components, particularly when dealing with large data flows. The fix specifically updates the default value of the `isCalloutForStack` prop to `true` in the `LineChartBase` component. This ensures that callouts (hover cards) are correctly rendered for stacked line charts by default, significantly improving the reliability and user experience of data visualization interactions.

This commit **fixes a bug** in the **`@fluentui-react-charts` package** by resolving a **conditional React hook usage** within the `ScatterChart` component. The `useScatterChartStyles` hook call was moved to the top level of `ScatterChart.tsx` to comply with React's rules, ensuring stable rendering. Concurrently, the styling hook `useScatterChartStyles_unstable` was **refactored** and renamed to `useScatterChartStyles`. This crucial **fix** allows previously skipped tests for the **`ScatterChart` component** to be re-enabled, significantly improving its test coverage and overall stability.

This commit provides a **bug fix** for the **`react-charting`** package, specifically addressing an issue within the **`LineChart`** component. It **corrects the identification of the hovered data point** when a chart displays only a single data point. Previously, the hover behavior for such scenarios was incorrect, but now the `_onMouseMove` function ensures accurate data point detection. This improvement enhances the reliability and user experience of the `LineChart` component, particularly for datasets with minimal entries.

This commit **updates the documentation** for **React Charts**, specifically within the `Introduction.mdx` file of the `chart-docsite` application. It provides current status and planned dates for various chart types relevant to the v9 release. This is a **documentation update** to ensure users have the most up-to-date information regarding the development progress and timelines of the charting library.

This commit introduces a **new GitHub Actions workflow** in `.github/workflows/copilot-setup-steps.yml` to standardize the setup process for **Copilot agent-related tasks**. This **chore** defines reusable steps for checking out code, configuring Node.js, and installing Yarn dependencies, ensuring a consistent environment for future Copilot development and CI. The workflow is specifically designed to be used by the **Copilot agent**, streamlining its operational setup. This infrastructure improvement will facilitate more efficient and reliable execution of **Copilot agent** workflows.

This commit performs a significant **refactoring** within the **`@fluentui-react-charting` package** to improve code reusability and **reduce bundle size**. It introduces new common utility functions like `getTooltipStyle`, `getAxisTitleStyle`, `getBarLabelStyle`, and `getMarkerLabelStyle` in `Common.styles.ts`. Subsequently, numerous chart components, including `AreaChart`, `DonutChart`, `LineChart`, and `VerticalBarChart`, are updated to leverage these shared styling utilities instead of duplicating logic. This consolidation also involves exporting `ISVGTooltipTextProps` and centralizing SVG tooltip properties in `CartesianChart.base.tsx`, leading to more consistent and efficient styling across the charting library.

This commit provides a **bug fix** for **charting components**, specifically addressing **SVG background alignment** issues. It corrects the positioning of SVG backgrounds relative to y-axis labels for numeric values in **Cartesian charts** by adjusting margin calculations within `_createMargins` in the `@fluentui/react-charting` package. Additionally, this change fixes the padding and background rectangle dimensions for **SVG tooltips** in both the `@fluentui/react-charting` and `@fluentui/react-charts` packages. This ensures proper visual alignment for chart elements and tooltips, improving the overall presentation and readability of charts.

This commit introduces **multi-plot support for declarative charts** within the `react-charting` library, specifically enabling the rendering of **non-cartesian chart types**. This **new capability** is achieved by refining data processing, grid property calculation, and legend generation within the `DeclarativeChart` and `PlotlySchemaAdapter` components. Additionally, the `DonutChart` now supports an **x-axis annotation**, complete with styling and API updates. To facilitate these changes, new `FluentChart` and `TraceInfo` types were introduced and integrated into the `chart-utilities` package, streamlining chart data mapping. This work significantly enhances the flexibility and expressiveness of the charting components, allowing for more complex and informative visualizations.

This commit introduces a significant **enhancement** to the **`@fluentui/react-charting`** library by adding comprehensive support for **Plotly axis tick formatting and y-axis ranges**. The `PlotlySchemaAdapter` (`packages/charts/react-charting/src/components/DeclarativeChart/PlotlySchemaAdapter.ts`) now correctly processes these layout properties, enabling more precise control over chart visualization. This change also **fixes** and **refactors** how bar labels are formatted across various chart types, including `VerticalBarChart` and `GroupedVerticalBarChart`, by centralizing the formatting logic to consistently use the Plotly schema adapter. As a result, charts in both `react-charting` and `react-charts` will display axis ticks and bar labels more accurately and according to specified Plotly configurations, improving overall chart customizability and consistency.

This commit introduces a **bug fix** for **Sankey charts** by implementing a mechanism to detect and prevent the rendering of charts containing cycles. A new `findSankeyCycles` function in the **`@fluentui/chart-utilities`** package identifies these problematic structures, ensuring that such charts are marked as unsupported to avoid rendering errors. Additionally, the `isInvalidValue` utility function has been **refactored** from `@fluentui/react-charting` into `@fluentui/chart-utilities`, centralizing common logic and improving code reusability across the charting library. This change enhances the stability and robustness of chart rendering, particularly for complex Sankey diagrams.

This commit introduces a **fix** within the **`@fluentui/chart-utilities`** package to explicitly mark log scale axes as unsupported. A new function, `invalidateLogAxisType`, has been added to `PlotlySchemaConverter.ts` and integrated into the `mapFluentChart` logic. This **prevents the use of an unsupported feature**, ensuring that any attempts to configure log scale axes are correctly identified and handled, thereby improving the robustness and predictability of chart rendering. The change ensures that the chart utility correctly reflects its current capabilities regarding axis scaling.

This commit introduces a **new capability** and a **bug fix** across the charting libraries. It enables **rounded corners** for various chart types, such as donut, bar, and gauge charts, within the **`@fluentui/react-charting`** library by extending the `PlotlySchemaAdapter`'s transformation functions. Concurrently, it **fixes** an issue in the **`@fluentui/chart-utilities`** package by improving **schema validation** within the `getValidSchema` function, ensuring more robust handling of input types and data arrays. This enhances both the visual customization options for `DeclarativeChart` components and the reliability of chart data processing by preventing errors from malformed schemas.

This commit introduces a **Plotly-aligned colorway system** to the **`DeclarativeChart` component** within **`@fluentui-react-charting`**, significantly enhancing chart visualization options. It implements this **new capability** by replacing the `fluentDataVizColorPalette` prop with a more flexible `colorwayType` and **refactoring** color-related utilities into a dedicated `PlotlyColorAdapter` module. This provides a standardized way to apply Plotly color schemes, requiring consumers of `DeclarativeChart` to update their prop usage for color customization.

This commit introduces a **bug fix** and **refactoring** across the **charting components** to improve chart type validation. It makes the check for unsupported chart types stricter within the **`@fluentui/chart-utilities`** package by removing the `isLineData` utility and updating `PlotlySchemaConverter.ts` functions like `validateScatterData` and `getValidTraces`. Concurrently, the `PlotData.mode` type is extended to correctly recognize and render `'markers+text'` and `'text+markers'` modes for scatter charts in **`@fluentui/react-charting`**. This also involves removing `isLineData` usage from **`@fluentui/react-charts`**'s `PlotlySchemaAdapter.ts`, ensuring more robust and accurate chart rendering by preventing incorrect rendering of unsupported types while supporting new valid combinations.

This commit delivers a **bug fix** to the **Fluent UI Charting library**, addressing an issue where year values were incorrectly treated as continuous numerical data. It introduces new utility functions, `isYear` and `isYearArray`, within the `chart-utilities` package to correctly identify year-based data. The `mapFluentChart` function and the `DeclarativeChart` component in `react-charting` are updated to ensure year values are consistently processed as **categorical variables** for chart rendering. This change prevents visual misrepresentations in charts that use year data, leading to more accurate and semantically correct visualizations.

This commit introduces a **new feature** to the **`react-charting` package** by **overhauling the default date label formatting** for x-axes. It implements a **new multi-level date formatter** within `src/utilities/utilities.ts`, specifically impacting functions like `createDateXAxis` and `createNumericXAxis`. This change replaces the previous `multiFormat` function and adjusts tick calculation logic to provide **more intelligent and context-aware date labels** on charts. The update ensures consistent date display across various timezones and environments, significantly improving the readability and usability of date-based charts in components like `AreaChart` and `LineChart`.

This commit performs a **maintenance chore** to facilitate a **patch release** for the **`@fluentui/chart-utilities`** package, which is integral to `react-charting`. It introduces a new change file to track this release, specifically updating the release tag to `v8`. Concurrently, the `project.json` configuration within `packages/charts/chart-utilities` is updated, changing internal project tags from `platform:web` and `vNext` to `v8` and `ships-bundle`. This ensures proper versioning, release tracking, and bundling metadata for the chart utilities package.