Kyle Cutler

This commit introduces a **new capability** to **reuse existing browser tabs** when opening tools within the **browser view contribution**. It modifies the `OpenBrowserTool` to check for an already open page with the same host, navigating to it instead of creating a new tab, unless a `forceNew` parameter is explicitly specified. Helper functions like `findExistingPageByHost` were added to facilitate this logic, which is also applied to the `OpenBrowserToolNonAgentic`. This enhancement improves the user experience by preventing excessive tab creation and promoting more efficient resource utilization within the workbench.

This commit **enhances the browser tools** within the **browserView contribution** by introducing **human-readable element labels** for their invocations. This **new capability** means that actions performed by tools like `clickBrowserTool`, `dragElementTool`, `hoverElementTool`, `typeBrowserTool`, and `screenshotBrowserTool` will now display descriptive labels for the target elements, rather than technical identifiers. The `navigateBrowserTool` also sees a refactor for improved message readability. This change significantly **improves the clarity and usability of browser tool interactions**, making their operations more understandable, and includes updates to the tools' parameter schemas.

This commit introduces a **new capability** to display **URI-based icons**, such as browser tab favicons, directly within the quick access pickers. It enhances both the **Editor Quick Access** (`editorQuickAccess.ts`) and **Anything Quick Access** (`anythingQuickAccess.ts`) features. By retrieving the editor's associated icon and setting the `iconPath`, this change provides a more visually informative experience. Users will now benefit from improved visual identification of open browser tabs and other URI-backed resources, making navigation quicker and more intuitive.

This commit introduces a **new capability** to enhance the **browserView tools** by embedding direct, clickable links to the browser editor within tool invocation and result messages. Various `prepareToolInvocation` methods across tools like `handleDialogBrowserTool`, `typeBrowserTool`, and `navigateBrowserTool` now include markdown links, facilitated by the new `createBrowserPageLink` helper. The **chat UI** is updated to support the `vscodeBrowser` scheme, allowing these links to be rendered with appropriate names and icons in `chatInlineAnchorWidget` and `chatContentMarkdownRenderer`. This significantly improves **accessibility and feedback** by enabling users to quickly navigate from tool outputs directly to the relevant browser context.

This commit delivers a **bug fix** addressing an issue where shortcuts would double-emit from the browser view, specifically impacting **Mac users**. It modifies the `keydown` event handling logic within `src/vs/platform/browserView/electron-browser/preload-browserView.ts` to prevent redundant shortcut activations. The solution involves adding specific checks to filter out non-editing keys, Alt+Key combinations, and native browser shortcuts, thereby improving the reliability and responsiveness of keyboard input within browser views. This ensures a smoother user experience by preventing unintended duplicate actions.

This commit **fixes** an issue within the **Browser View** subsystem, specifically **improving the synchronization** of the "share with agent" status. It ensures that the sharing status is accurately updated via `_setSharedWithAgent` in `browserView.ts` whenever page tracking starts or stops. Concurrently, error handling in the underlying `PlaywrightService` is streamlined by simplifying `addView` and `_removePageFromGroup` in `playwrightService.ts`. This results in more reliable reporting of browser view sharing status and cleaner error propagation for the **Browser View** feature.

This commit **fixes a bug** that prevented users from "adding elements to chat" while debugging. It involves a significant **refactoring** of the **`BrowserView` platform component**'s element inspection mechanism. A new class, `BrowserViewElementInspector`, has been introduced to encapsulate and centralize the logic for inspecting elements within a browser view. This change improves the reliability of element data extraction, particularly by enhancing ancestor tracing within the `extractNodeData` method, thereby resolving the underlying issue encountered during debugging sessions.

This commit introduces **new capabilities** for interacting with **browser views**, enabling **native console log retrieval** and **detailed element inspection**. It enhances the `browserView` platform and workbench contributions by adding methods to get console output and structured element data, including a new `browserViewElementInspector` module. Additionally, **screenshot functionality** is updated to support more precise capture options like `screenRect` and `pageRect`. This work facilitates deeper integration of web content into features like "add to chat" by providing structured access and improved capture of web page information.

This **maintenance** commit **refines the visual styling** of the **browser view component** within the workbench. It adjusts `width`, `height`, and `border-radius` properties, along with `top`/`left`/`right`/`bottom` values for a pseudo-element defined in `src/vs/workbench/contrib/browserView/electron-browser/media/browser.css`. Additionally, a `border-radius` transition is introduced to provide a smoother visual effect. These minor changes aim to improve the aesthetic consistency and polish of the browser view's borders, enhancing the overall user interface experience.

This commit introduces **new capabilities** and **improved robustness** for **browser favicons** within the **Electron main process**. It specifically adds support for using `data:` URLs as favicons, allowing for more flexible and embedded icon definitions. Furthermore, the commit enhances **error handling** during favicon fetching by implementing **content type validation**, preventing issues with invalid or unexpected favicon data. This **feature enhancement** ensures a more reliable and versatile display of favicons across the application, particularly impacting the `src/vs/platform/browserView/electron-main/browserView.ts` module.

This commit **enhances the browser open command** by introducing the **ability to reuse existing browser tabs** instead of always opening new ones. A new `reuseUrlFilter` option has been added to the **browser tab management features**, allowing users to specify a glob pattern to identify and navigate to an already open browser editor. To support this, the `browserEditorInput` now includes a `navigate` method, enabling the update of an existing tab's URL. This **new capability** prevents unnecessary tab duplication, improving the user experience when interacting with integrated browser views.

This commit **fixes a bug** within the **`BrowserEditor`** component that caused an erroneous "Failed to start console session" message to appear as "noise". The change addresses an issue where this specific error or warning was being logged or displayed unnecessarily, even when no critical failure occurred. This **maintenance** update improves the stability and user experience of the browser-based editor by preventing misleading error messages during console session initialization.

This commit provides a **bug fix** for the **Browser Editor** subsystem by correcting an identifier used for editor resolution. Specifically, it updates the editor override ID from `BrowserEditorInput.ID` to `BrowserEditorInput.EDITOR_ID` within both the `browserEditorInput.ts` definition and its registration in `browserView.contribution.ts`. This ensures that the browser editor resolver correctly identifies and handles browser editor inputs, preventing potential issues with editor functionality and registration. The change guarantees proper functioning of the **Browser Editor** component.

This commit **enhances key event handling** for **browser views** by ensuring that browser pages process key events first. It introduces a **preload script** (`preload-browserView.ts`) that captures keydown events within the browser page and forwards only **unhandled events** to the main process via IPC. This **refactoring** removes direct key event dispatching from the main process, simplifying the `browserView` services and improving the responsiveness and native feel of browser-rendered content. A specific consideration was added to ensure that **shortcuts remain functional even when the debugger is paused**.

This commit introduces a **bug fix** for the **integrated browser view's chat features**, specifically addressing an issue where the `Enter` key would unintentionally trigger the `AddFocusedElementToChatAction`. The keybinding for this action, defined in `browserEditorChatFeatures.ts`, has been modified to now require `CtrlCmd + Enter`. This change prevents accidental chat activations, significantly improving the user experience within the integrated browser.

This commit **fixes a bug** that caused **browser focus stealing** within the **Browser Editor** component. It introduces a **debounced focus handling mechanism** by adding `requestFocus` and `cancelFocus` methods to `src/vs/workbench/contrib/browserView/electron-browser/browserEditor.ts`. Existing focus calls have been updated to utilize this new, more controlled approach, which **prevents disruptive focus shifts** and **improves the user experience** in the Electron browser environment.

This commit performs a significant **refactoring** to **modularize the find functionality** within the **browser view editor**. It extracts the `BrowserFindWidget` and its associated contribution (`BrowserEditorFindContribution`) into a new, dedicated feature file, `browserEditorFindFeature.ts`, along with re-registering all find-related actions. Consequently, `browserEditor.ts` is refactored to remove direct find widget management, instead adopting a generic contribution mechanism for toolbar elements, and `browser.css` is updated to reflect UI structural changes. This **maintenance** effort improves the **extensibility and maintainability** of the browser view by making its features more self-contained and dynamically contributable.

This commit introduces **optimizations to the Browser API** by **refactoring the communication protocol** and synchronization logic for browser tab state changes between the main thread and the **Extension Host**. Specifically, the `onDidChangeActiveBrowserTab` event now transmits only the browser ID, reducing data transfer, while `onDidChangeBrowserTabState` directly passes the full DTO for more streamlined state updates. This **refactoring** impacts the `mainThreadBrowsers.ts`, `extHost.protocol.ts`, and `extHostBrowsers.ts` modules, along with corresponding **test adjustments** in `extHostBrowsers.test.ts`. The goal is to improve the efficiency and reduce the complexity of **browser tab synchronization** within the **Browser API**.

This commit introduces significant **feature contributions** to the **BrowserView** component, enhancing capabilities for **browser developer tools** and **data storage management**. It adds new editor contributions and actions, such as `ToggleDevToolsAction`, to control developer tools, and `ClearGlobalBrowserStorageAction`, `ClearWorkspaceBrowserStorageAction`, and `ClearEphemeralBrowserStorageAction` for clearing various scopes of browser data. This work involves **refactoring** existing action definitions into dedicated feature modules and updating the `browserView.contribution.ts` to integrate these new, modular functionalities. The changes provide users with more granular control over browser-related features and improve the internal organization of the `BrowserView` subsystem.

This commit **restricts the `simple-browser` extension from being utilized on desktop environments**, ensuring it is **never used on desktop platforms**. This **maintenance change** prevents the activation of a feature not intended for desktop use, potentially streamlining the user experience or avoiding redundant functionality. The `package.nls.json` file was updated to reflect this restriction in localized strings, aligning the UI with the new behavior. Consequently, desktop users will no longer have access to or see options for the simple browser.