Glenn Lewis

This commit **fixes** and **enhances** the **GitHub API client's pagination mechanism** by migrating specific iterator methods. It updates the `ListHookDeliveriesIter` methods across various services to utilize **cursor-based pagination** instead of the previous `After` parameter. This required **adding support for cursor-based pagination** within the `github/gen-iterators.go` tool, which generates the iterator code, including new fields and conditional template rendering. The change ensures more robust and efficient iteration over **GitHub hook deliveries**, with corresponding **test cases** in `github/github-iterators_test.go` updated to validate the new `Link` header parsing.

This commit performs a **documentation fix** by **correcting a typo** and reformatting a sentence within the introductory section of the project's **contributing guidelines**. Specifically, it addresses minor inaccuracies and improves readability in the `CONTRIBUTING.md` file. This **maintenance chore** ensures that instructions for potential project contributors are clear and accurate, enhancing the overall quality of the project's documentation.

This commit **expands the OpenAPI specification** by **adding new definitions** for **issue field related API endpoints** in `openapi_operations.yaml`. This **feature addition** enhances the documented API surface, allowing clients to discover and utilize new functionalities for managing issue fields. It also includes a routine update to the OpenAPI commit hash, ensuring the specification remains current and aligned with the latest API changes.

This commit performs a **dependency upgrade**, updating the `go.opentelemetry.io/otel` module to version `v1.42.0`. This ensures the project's **OpenTelemetry integration** benefits from the latest features, bug fixes, and performance enhancements provided by the updated SDK. The change primarily impacts the **observability components** responsible for tracing and metrics collection, aligning them with the most recent OpenTelemetry standards. This is a routine **maintenance chore** to keep external dependencies current and improve overall system stability and monitoring capabilities.

This commit **enhances the `structfield` tool** by adding `SAS` to its internal list of common initialisms. This **maintenance chore** ensures that when `structfield` processes code, it correctly preserves the casing of `SAS` (e.g., `SASID` instead of `Sasid`) in generated struct field names. The change specifically affects the `tools/structfield/structfield.go` file, improving **code generation consistency** and adherence to naming conventions for developers utilizing the tool.

This commit delivers a **bug fix** to resolve **data races** occurring specifically on **Windows** platforms within the **`github` module**. It modifies the `NewUploadRequest` function to wrap the request body reader with a new type, effectively circumventing transport optimizations that led to these race conditions. Furthermore, the **test suite** is enhanced with a `raceSafeTestConn` wrapper, integrated into the HTTP transport's `DialContext` for tests. This ensures both the core functionality and the **test execution** are stable and free from race conditions when running on **Windows**.

This commit performs a **dependency update** within the **`scrape`** module, specifically bumping the `go-github` library from `v83` to `v84`. This **maintenance chore** updates the import paths in both `apps.go` and `apps_test.go`, ensuring the scraping logic leverages the latest version of the GitHub API client. The change helps maintain compatibility and allows the `scrape` module to benefit from any improvements or new functionalities introduced in `go-github v84`.

This commit performs a **dependency upgrade**, updating the project's primary `go-github` library from `v83` to **`v84.0.0`**. This **maintenance** task involves comprehensively updating import paths across all **example applications**, **integration tests**, and **internal tools** that utilize the `go-github` client. Additionally, it updates the internal `Version` constant in `github/github.go`, adjusts build and linting configurations in `.custom-gcl.yml` and `.golangci.yml`, and refreshes all relevant documentation, including `README.md` and package-level docs, to reflect the new version. This ensures the project remains current with the latest `go-github` features and improvements.

This commit performs a **dependency update**, bumping `github.com/theupdateframework/go-tuf/v2` to version `v2.4.1`. This update necessitated a **refactoring** within the **`verifyartifact` example module** to align with changes in the upstream library's API. Specifically, the return type of `getSignedEntityVerifier` and the parameter type of `runVerification` in `example/verifyartifact/main.go` were updated from `*verify.SignedEntityVerifier` to `*verify.Verifier`. This ensures the example remains functional and compatible with the latest version of the `go-tuf` library, representing a **maintenance** task for the project's examples.

This commit **updates the Go versions** utilized within the project's **CI/CD workflows**. Specifically, the **linter** workflow now uses the `stable` Go version, while the **tests** workflow matrix has been updated to run against both `stable` and `oldstable` Go releases. This **maintenance** task ensures that all automated checks and builds are performed using the most current and officially supported Go environments, improving compatibility and leveraging the latest language features and security updates. The change primarily impacts the **development and testing infrastructure**, without altering the application's runtime behavior.

This commit performs a **dependency update**, upgrading the `go-github` library from version `v82` to `v83` within the **`scrape` module**. This **maintenance chore** ensures that the `scrape` functionality, which interacts with the GitHub API, benefits from the latest features, bug fixes, and security enhancements provided by the updated library. The change specifically involves updating the import paths in `scrape/apps.go` and its corresponding test file `scrape/apps_test.go`. This keeps the project's external dependencies current, potentially improving stability and compatibility with the GitHub API.

This commit performs a **dependency update**, bumping the `go-github` library to **version `v83.0.0`**. This **maintenance** task ensures the project benefits from the latest features and bug fixes provided by the upstream library. The change propagates throughout the codebase, updating import paths in all **example applications**, **internal tools**, and **test suites** to reflect the new module version. Furthermore, **documentation** (including `README.md` and `AUTHORS`) and internal configuration files are adjusted to reflect this new version, ensuring full compatibility and up-to-date references.

This commit performs a **maintenance update** by **bumping the `golangci-lint` version** from `v2.7.0` to `v2.9.0`. It updates the **development tooling** by modifying `script/setup-custom-gcl.sh` to reflect the new version. Additionally, the **linting configuration** in `.golangci.yml` is enhanced by adding `allow-parallel-runners`, which can improve the performance of linting checks. This ensures the project utilizes the latest features and bug fixes from the linter, potentially speeding up **CI/CD pipeline** execution and improving code quality checks.

This commit **fixes** and **refactors** the **GitHub API client's cursor-based pagination mechanism** by **migrating** from a `Cursor` field to an `After` field for string-based iteration. This change impacts numerous **`github` module iterators**, including those for alerts and security advisories (e.g., `ListAlertsForOrgIter`, `ListGlobalSecurityAdvisoriesIter`), ensuring a consistent and correct pagination approach. The work involved updating the iterator generation templates, refactoring existing iterator functions, and adjusting unit and integration tests to validate the new `After` parameter. Additionally, the **documentation** in `README.md` has been updated to reflect this internal change, improving the overall reliability and maintainability of the pagination logic.

This commit introduces a **breaking change** by **refactoring** numerous `*Options` structs within the **GitHub API client** (e.g., for `enterprise_codesecurity_configurations`, `orgs_codesecurity_configurations`, `projects`, and `users`). Specifically, fields with `url` struct tags and `omitempty` are now passed by value instead of by reference to ensure correct URL parameter serialization. To enforce this new pattern, a **new `check-structfield-settings` tool** was added, and the **`structfield` linter** was updated to validate and automatically fix these struct field settings, improving overall code consistency and preventing future serialization issues.

This commit introduces a **new capability** to the **`gen-iterators.go` tool**, enabling it to correctly generate test JSON for **iterator methods** that return `[]string`. Previously, this specific return type was not supported, leading to incomplete test generation. The change involves modifying the `processMethods` function to properly handle `[]string` by introducing an `emptyReturnValue` and utilizing `fmt.Sprintf` for accurate JSON representation. This enhancement improves the robustness of the project's **test generation capabilities** by expanding the range of supported iterator method signatures.

This commit **refactors** the code generation process within the **`github` module** by standardizing the placement of "Code generated by..." comment blocks. It specifically moves these critical "DO NOT EDIT" messages to the very first line of generated files and their respective templates. This **maintenance** change affects `gen-accessors.go` and `gen-stringify-test.go` by reordering template strings, and directly adjusts `github-accessors.go`, `github-accessors_test.go`, and `github-stringify_test.go`. The primary impact is improved consistency and clarity, ensuring that all auto-generated files prominently display the warning to developers.

This commit **updates the project's contributing guidelines** by adding a new section to `CONTRIBUTING.md`. The new content provides **best practices for writing pull request titles and commit messages**, offering clear guidance for contributors. This **documentation enhancement** aims to improve the consistency and clarity of contributions, making it easier for developers to understand the project's history and changes.

This commit performs a **dependency update**, upgrading the `go-github` library from version `v81` to `v82` within the **`scrape`** module. This **maintenance** task ensures that the `scrape` module, responsible for interacting with GitHub APIs, benefits from the latest features, improvements, and bug fixes provided by the updated library. The changes involve updating the import paths in `scrape/apps.go` and its corresponding test file, `scrape/apps_test.go`, to reflect the new module version. This keeps the project's external dependencies current and potentially enhances the robustness of GitHub API interactions.

This commit performs a significant **dependency upgrade**, bumping the `go-github` library from v81 to **v82.0.0**. This **refactoring** effort updates all relevant import paths and version references across the project to align with the new library version. It impacts **all example applications**, **internal tools** such as `gen-release-notes` and `metadata`, **documentation** including `README.md`, and the entire **test suite**. Additionally, the `gen-release-notes` tool received a minor enhancement to its release comparison URL format. This ensures the project remains compatible with the latest `go-github` features and fixes, improving overall **maintenance** and stability.