Anthony Kim

This commit provides a **bug fix** for the **Terminal Shell Integration** feature, specifically correcting the migration logic for shell integration timeouts. It ensures that the `ShellIntegrationTimeoutMigrationContribution` properly inspects and updates both user and workspace configuration targets within `terminal.chatAgentTools.contribution.ts`. This **maintenance** prevents unintended overwrites of existing settings, thereby preserving user preferences and configuration stability within the **terminal chat agent tools**.

This commit **reverts recent changes** to the **terminal editor** to **fix regressions** that impacted its background appearance and behavior. It addresses issues where the terminal editor's background styling was incorrect by reverting CSS modifications in `terminal.css` and removing an erroneous check for `TerminalSettingId.EditorUseEditorBackground` in `xtermTerminal.ts`. This ensures the **terminal editor** correctly applies background settings and resolves visual inconsistencies, restoring the expected user experience for users of the integrated terminal. A related test suite for `TerminalInstanceColorProvider` was also removed as part of this rollback.

This commit introduces a **bug fix** addressing the non-functional `Ctrl+/-` zoom shortcuts within the **terminal on Windows**, specifically impacting the Copilot CLI. The core change involves updating `src/vs/workbench/contrib/terminal/common/terminal.ts` to include `workbench.action.zoomIn`, `workbench.action.zoomOut`, and `workbench.action.zoomReset` in the `DEFAULT_COMMANDS_TO_SKIP_SHELL` array. This modification ensures the **terminal's keybinding handler** correctly prevents these commands from being consumed by the shell, thereby allowing the **workbench's zoom functionality** to operate as intended. Consequently, users will now experience consistent zoom behavior in the terminal, and new test cases have been added to `src/vs/workbench/contrib/terminal/test/browser/terminalInstance.test.ts` to validate this fix.

This commit delivers a **bug fix** for the **integrated terminal**'s keybinding handling, specifically addressing issues with **Meta-modified keybindings**. It modifies the `_handleKeyEvent` in `src/vs/workbench/contrib/terminal/browser/terminalInstance.ts` to **intercept** these key events before `xterm.js` can consume them. This ensures that non-hardcoded `Alt` key combinations, which resolve to VS Code commands, function correctly when the **kitty keyboard protocol** is active, particularly benefiting users of shells like **Fish**. The change resolves a problem where custom terminal commands were not executing as expected, and a new **test case** was added to validate this improved behavior.

This commit introduces a **new feature** to the **Copilot CLI terminal link provider**, enhancing user interaction when file paths are ambiguous. It implements a **quick pick dialog** that prompts users to select the correct file when multiple potential matches are found for a terminal link. This required **refactoring the path resolution logic** within `copilotCLITerminalLinkProvider.ts` to collect all possible file candidates, rather than just the first one. Consequently, users will experience improved reliability and usability when interacting with **Copilot's terminal integration**, especially for opening files from CLI output.

This commit **fixes a bug** in the **Copilot CLI terminal link provider** by enhancing its ability to detect and resolve file links within terminal output. It refactors the link detection logic in `copilotCLITerminalLinkProvider.ts` to correctly identify files referenced by **bare filenames** and those located in **subdirectories**, alongside improving cancellation support. This **improves the accuracy** and reliability of clickable links for users interacting with Copilot CLI output, ensuring a smoother navigation experience. New test cases have been added to validate these improvements, covering various scenarios including numeric version exclusion.

This commit **fixes a regression** related to **Psreadline**, addressing issues that likely impacted interactive shell or input experiences within the application. The changes primarily affect the **Chat** and **Sessions** features, along with the **Terminal** integration, and include adjustments to platform utilities like `urlGlob` and `actionWidget`. This **bug fix** restores correct functionality and improves stability across these critical workbench components, resolving a previously introduced issue.

This commit delivers a **critical bug fix** for the **terminal shell integration** within **Windows Terminal 5**. It resolves an issue where enabling a screen reader would inadvertently trigger an infinite 'enter' loop, rendering the terminal unusable. The fix is applied to the **PowerShell shell integration script** (`shellIntegration.ps1`), preventing this disruptive behavior. This significantly enhances the **accessibility** and stability of the terminal experience for users who rely on screen readers on Windows.

This commit **enables** the `reflowCursorLine` option for the **terminal** specifically on **Windows** operating systems when the `conpty` DLL is active. This **enhancement** addresses a critical issue where the terminal prompt could be lost or misrendered, significantly **improving the visual stability and user experience** for Windows terminal users. The change ensures this setting is correctly applied within the `terminalInstance.ts` module, preventing prompt loss and enhancing the reliability of the terminal display.

This commit provides a **bug fix** for the **Copilot CLI** to correctly resolve links across **multiple terminal sessions**, addressing issues where stale or incorrect session contexts could lead to broken links. It introduces a new `resolveSessionDirsForTerminal` function within `copilotCLIChatSessionsContribution.ts` to intelligently prioritize active session directories based on terminal affinity. The `copilotCLITerminalLinkProvider.ts` is updated to leverage this new resolution logic, ensuring that `_getSessionDirs` accurately identifies the relevant session for terminal links. This significantly improves the reliability and user experience of **Copilot CLI** interactions, especially when managing several concurrent terminal contexts. New regression tests have been added to validate these complex multi-session scenarios.

This commit performs a **maintenance update** by upgrading the **Windows integrated terminal's ConPTY dependency to version 1.25**, specifically `v1.25.260303002`. This update includes a **bug fix** to address issues where `conptyNative.connect()` might defer, causing the process ID to be initially unavailable. To resolve this, the **terminal process monitoring** logic in `terminalProcess.ts` now waits for the first data event to retrieve the PID if it's initially zero, complemented by a new `setPid` method in `childProcessMonitor.ts` for dynamic updates. This ensures robust process tracking despite the deferred connection behavior, improving the stability of the **integrated terminal** on Windows.

This commit introduces a **new capability** by implementing a **terminal link provider** for **Copilot CLI output**. This feature allows users to **click on file paths** displayed in the terminal, such as those from `git diff` or `ls` commands, to directly open them in the editor. It enhances the **Copilot CLI integration** by intelligently resolving relative paths, expanding tildes, and supporting Windows backslashes, while also incorporating guards for line length and link count. The functionality is controlled by a new `chat.cli.terminalLinks.enabled` setting, significantly improving the interactive experience within Copilot-related terminal sessions.

This commit performs a **maintenance update** by **bumping the `xterm` dependency** to version `6.1.0-beta.191`. This update to the **terminal emulation component** integrates the latest features, bug fixes, and performance improvements from the `xterm` library. Consequently, users will experience a more robust and up-to-date terminal interface within the application, enhancing stability and functionality.

This commit performs **maintenance** by updating comments within the **PowerShell shell integration script** (`shellIntegration.ps1`). It specifically corrects version numbers and clarifies behavior related to **PSReadLine** and **screen reader mode** within the **terminal shell integration**. This ensures the script's internal documentation is accurate, improving clarity for maintainers and enhancing understanding of the terminal's accessibility features.

This commit delivers a crucial **accessibility fix** for **screen reader users** interacting with **PSReadline** in the **terminal**. The `shellIntegration.ps1` script is updated to correctly manage `PSReadLine` by checking for `EnableScreenReaderMode` support, removing incompatible modules, and importing a bundled version for proper functionality. Concurrently, `src/vs/platform/terminal/node/terminalEnvironment.ts` is adjusted to ensure argument mutability during shell integration injection, preventing potential errors. This work significantly enhances the **screen reader experience** within the terminal environment.

This commit **updates the `xterm` dependency** to a newer version, primarily to integrate a **critical bug fix** addressing an **IME (Input Method Editor) overflow issue**. This **dependency bump** resolves problems where IME input could lead to display or input glitches within the terminal, thereby **improving the stability and correctness of internationalized input**. This **maintenance update** directly enhances the user experience for all users relying on IME for text entry in the terminal.

This commit introduces **telemetry** to monitor the usage and loading status of the **xterm.js image addon** within the **Terminal** component. It adds a new `imageAddonLoaded` field to the terminal creation telemetry and logs individual events when the image addon is activated and when images are added to the terminal. This **new capability** provides valuable insights into the adoption and interaction with the **terminal image rendering feature**. The changes primarily affect the `terminalTelemetry.ts` and `xtermTerminal.ts` files, enhancing data collection for future development and optimization.

This commit **updates the `xterm.js` dependency** to a newer version, specifically addressing a long-standing issue. The primary purpose of this update is to **resolve a bug** affecting the **kitty keyboard protocol**, which previously caused incorrect input handling within the terminal. This **dependency bump** ensures proper functionality and significantly improves **terminal emulation compatibility** for users leveraging the `kitty` terminal's advanced input features.

This commit performs a **maintenance update** by bumping the version of the `xterm` dependency. The primary purpose of this upgrade is to gain access to the new `imageAdded` API within the **terminal component**. This change enables future enhancements related to **image handling and display** within the application's terminal interface, improving its capabilities. It ensures the project can leverage the latest features and improvements from the `xterm` library, laying groundwork for richer content presentation.

This commit introduces **support for the Ghostty terminal** as an external terminal option for users on **macOS and Linux**. It significantly enhances the `externalTerminalService` by refactoring the terminal spawning logic into a new helper function, `spawnTerminalWithEnv`, and adding dedicated error handling via `setupSpawnErrorHandling`. This **new capability** allows users to configure VS Code to launch Ghostty, improving the flexibility of external terminal integration, and is validated by new test cases in `externalTerminalService.test.ts`.