Jake Bailey

Update deps (#63296)

This commit **fixes a bug** in the **compiler** where **default library files** were not correctly identified and added to the `libFiles` set when reusing program structure. Specifically, the `createProgram` function in `src/compiler/program.ts` now ensures that all necessary standard library definitions are properly included during program reuse. This **bug fix** prevents potential compilation errors or incorrect type checking that could arise from missing library files in such scenarios. A new test case in `src/testRunner/unittests/reuseProgramStructure.ts` has been added to validate that the `isSourceFileDefaultLibrary` status is correctly preserved.

This commit **deprecates the use of `assert` in import expressions and attributes**, introducing warnings within the **TypeScript compiler's checker** (`src/compiler/checker.ts`). This is a **feature update** to align with evolving JavaScript standards for import attributes, encouraging the use of the `with` keyword instead. The compiler will now issue deprecation messages for `assert` unless warnings are explicitly ignored, guiding users towards the new syntax. This change impacts how import attributes are parsed and checked, and numerous test baselines have been updated to reflect these new warnings and the transition to `with`.

This commit primarily performs **maintenance and refactoring** across the project's linting infrastructure. It **updates the ESLint configuration** by adjusting the regexp plugin and disabling new rules like `no-useless-assignment` and `preserve-caught-error`. Concurrently, it **refactors internal custom ESLint rules** (`argument-trivia.cjs` and `jsdoc-format.cjs`) to use the more modern `context.sourceCode` property instead of the deprecated `getSourceCode()` method, improving consistency and potentially performance. Additionally, the `knip.jsonc` configuration is updated to remove `eslint-formatter-autolinkable-stylish` from ignored dependencies, streamlining **dependency analysis**.

DOM update (#63183)

This commit performs a **maintenance refactoring** across multiple **GitHub Actions workflows** to eliminate direct expression interpolation within `run` steps. Specifically, the **CI**, `close-issues.yml`, `lkg.yml`, `new-release-branch.yaml`, `pr-modified-files.yml`, and `set-version.yaml` workflows are updated. Instead of inline interpolation, critical data such as bundle/package names, repository, branch, PR details, and version information are now passed via **environment variables** to commands like `run`, `gh`, `sed`, `git`, and `grep`. This change improves the **readability and robustness** of the **CI/CD pipeline**, standardizing variable access and reducing potential parsing issues within workflow steps.

This commit primarily **updates the internal DOM type definitions**, which has a downstream effect on how the compiler processes and types JSX elements. This **maintenance update** refines the type system's understanding of **JSX constructs** and their interaction with DOM elements. The changes are reflected in numerous updated symbol counts across various `jsx` and `tsx` test baselines, ensuring the compiler's type checking for **JSX expressions** remains accurate and consistent with the latest DOM type specifications.

This commit **updates the release publishing pipeline** by introducing a new step within the `azure-pipelines.release-publish.yml` configuration. This **maintenance chore** explicitly ensures that **Node.js version 20.x** is installed before subsequent publishing tasks are executed. The change guarantees that the necessary runtime environment is consistently available, preventing potential build or publishing failures due to missing or incorrect Node.js versions. This improves the overall reliability and stability of the automated release process.

This commit introduces a **new compiler option**, `--stableTypeOrdering`, designed to ensure **deterministic type and symbol ordering** within the TypeScript compiler. This **feature** significantly modifies the **compiler's core type checking and symbol resolution logic** in `src/compiler/checker.ts` and `src/compiler/core.ts`, adding new comparison functions and adjusting existing ones to enforce consistent ordering. The primary goal is to enhance **build reproducibility and output stability**, addressing potential non-determinism in compiler outputs related to type and symbol processing, particularly for "TS7 ordering compat". The option is exposed via the command line and `tsconfig.json`, with extensive new and updated test baselines verifying its impact on various compiler and language service outputs.

This commit **optimizes the Continuous Integration (CI) workflow** by **disabling macOS builds** and **skipping older Node.js version builds** specifically for pull requests. This **maintenance chore** targets the `.github/workflows/ci.yml` configuration, aiming to provide **faster feedback on PRs** and **reduce CI resource usage**. The change streamlines the validation process, focusing resources on more critical build configurations during development.

This commit **deprecates** the `downlevelIteration` compiler option by introducing a **diagnostic warning** whenever it is enabled during compilation. The `CompilerOptions` interface within the **TypeScript compiler** is updated to formally mark this option as deprecated. This **maintenance** change aims to guide users away from an older compilation strategy for iterable constructs, impacting how iteration is handled when targeting older JavaScript environments. Extensive updates to baseline test outputs confirm that the new deprecation warning is correctly surfaced across various code patterns and compilation targets.

This commit **fixes several test cases** to correctly validate the **transpilation of ES6 features to ES5**. Specifically, it updates tests for **array literal spread**, **destructuring variable declarations**, and **downlevel generators** to explicitly include ES5 as a compilation target. This **maintenance** work ensures that the compiler's output, including necessary helper functions, deprecation warnings, and source maps, is accurately generated and tested for **ES5 environments**. The changes involve updating `.ts` test files and their corresponding `.js`, `.errors.txt`, `.sourcemap.txt`, and `.types` baselines, preventing regressions in older JavaScript runtimes.

This commit introduces a **new capability** to the **type baseline generation** process within the **testing harness**. It adds logic to `src/harness/typeWriter.ts` to prevent 'omitted expressions' from being included in the output. This **refinement** ensures that **type baselines are cleaner and more accurate**, improving the reliability and readability of type system tests by removing irrelevant internal details.

This commit **refactors** the compiler by **removing ES5-specific logic** across several core components, streamlining the codebase. It updates identifier text checks and class name collision logic within the **compiler checker** by removing or updating `ScriptTarget.ES5` references. The **emitter** no longer includes ES5-specific conditions for allowing trailing commas in object literal expressions, and the **transformer** now targets ES2015 for promoting class declarations to IIFEs instead of ES5. This **maintenance** effort simplifies the compiler by eliminating outdated target-specific code paths. Additionally, a new test case was added to verify enum members with non-identifier names.

This commit **enhances the TypeScript compiler's logic** for inferring the default `module` kind based on the specified `target` compiler option. It introduces more specific handling for modern ECMAScript targets such as `ESNext`, `ES2022`, and `ES2020` within `src/compiler/utilities.ts`. This **compiler improvement** ensures more accurate and modern default module outputs when the `module` option is not explicitly set. Consequently, the change also updates test baselines for `awaitInNonAsyncFunction.errors.txt`, reflecting adjustments in **top-level await error reporting** due to the refined inference.

This commit introduces a **new feature** by adding support for the `FORCE_COLOR` environment variable within the **TypeScript compiler**. It modifies the `defaultIsPretty` function in `src/compiler/executeCommandLine.ts` to **force colored output** from the `tsc` command-line interface, overriding default detection mechanisms. This enhancement ensures that users can explicitly enable terminal colors, while still correctly respecting the `NO_COLOR` environment variable for explicit disabling. **New test cases** and **baseline files** have been added to `src/testRunner/unittests/tsc/commandLine.ts` to thoroughly validate the interaction between `FORCE_COLOR` and `NO_COLOR` on compiler output. This provides users with greater control over the **compiler's terminal styling**.

This commit introduces a **bug fix** to resolve a **compiler crash** that occurred during **TypeScript transformation** when encountering **destructured parameter properties**. The `transformTypeScript` function in `src/compiler/transformers/ts.ts` was updated to add a specific check, ensuring these properties are correctly ignored during the transformation process. This change significantly improves the **compiler's stability** and robustness, preventing unexpected failures for projects utilizing this language feature, and is validated by new test cases covering declaration emit scenarios.

This commit performs **test maintenance** by correcting several baseline and test files related to TypeScript's parsing and code generation. It **fixes the `asiPreventsParsingAsNamespace04.ts` test case** to accurately reflect automatic semicolon insertion behavior by using `module in {}` instead of `namespace in {}`. This correction propagates to update the corresponding JavaScript, symbol, and type baselines. Furthermore, it removes obsolete error messages from `parseInvalidNames.errors.txt` and updates the `collisionCodeGenModuleWithUnicodeNames.js` baseline to correctly handle code generation for **modules with Unicode names**, preventing name collisions. This ensures more accurate and reliable validation of the compiler's handling of `module` declarations.

This commit **reverts** a previous change, **restoring the type definition** for `String.prototype.matchAll` to strictly accept only `RegExp` objects as an argument. It **removes the allowance for `string` arguments** for this method, aligning the TypeScript type definitions with the ECMAScript specification. This impacts **TypeScript users** leveraging **ES2020 features**, ensuring stricter type checking and preventing incorrect usage of `String.prototype.matchAll` with non-regex patterns.

This commit **refactors** several TypeScript files by replacing the deprecated `module` keyword with `namespace`. This **code modernization** effort affects components across the **standalone editor services** (`StandaloneServices`), **extension signature verification** (`vsceSign`), **signing services** (`vsdaWeb`, `vsda`), **remote extension host agent**, **notebook webview preloads**, and **task problem matchers** (`FileLocationKind`, `ProblemLocationKind`, `ApplyToKind`). The change is a **purely internal refactoring** that improves code maintainability and aligns with modern TypeScript practices, without introducing any functional changes or user-facing impact.