Aaron Munger

This commit introduces a **resource management improvement** within the **Notebook Multicursor** contribution. Specifically, it addresses potential memory leaks by ensuring that `text model references` are properly **disposed**. The change in `src/vs/workbench/contrib/notebook/browser/contrib/multicursor/notebookMulticursor.ts` now explicitly disposes of a reference if its associated text model is not found, or tracks it for later proper disposal otherwise. This **maintenance fix** enhances the stability and **memory efficiency** of the notebook editor, particularly when performing multicursor operations.

This commit introduces **diagnostic logging** to the **Chat Sessions contribution mechanism** within the `chat` workbench contribution. Log statements have been added to the `registerContribution`, `_evaluateAvailability`, and `_enableContribution` functions in `src/vs/workbench/contrib/chat/browser/chatSessions/chatSessions.contribution.ts`. This **maintenance** change aims to assist in **troubleshooting contribution availability** during evaluation. The added logs will provide crucial insights for developers to understand why certain chat contributions might not be active, thereby improving the debuggability of related issues.

This commit introduces a **new capability** for the **Copilot CLI extension** to support proxy configurations. It modifies the **Copilot CLI session management** to accept a `copilotUrl` option, enabling the use of a specified proxy for **HMAC authentication** during SDK sessions. The `IConfigurationService` is now integrated to retrieve this proxy URL and pass it to the session options, ensuring that the CLI can operate correctly in network environments requiring a proxy. This change significantly improves the **network compatibility** of the Copilot CLI by allowing it to authenticate and function through a proxy.

This commit implements a **bug fix** within the **Notebook Kernels API** in the extension host, specifically in `extHostNotebookKernels.ts`. It addresses a potential resource leak by introducing a disposable for the `variableProvider`'s `onDidChangeVariables` listener. This ensures the listener is properly disposed of when the provider changes or the associated kernel is removed, thereby improving the stability and resource management for **notebook extensions**.

This commit introduces a **new capability** to view exported Copilot Chat prompts as **VS Code notebooks**. It implements a `ChatReplayNotebookSerializer` to convert `.chatreplay.json` files into a structured notebook format, complete with **auto-collapsing cells** for improved readability upon opening. This feature significantly enhances the **Copilot Chat replay and logging system**, allowing developers to easily inspect and share detailed prompt interactions. The work involves new modules for defining replay types, handling export serialization, and integrating with the VS Code notebook API, alongside **refactoring** of existing log export functions in `requestLogTree.ts`.

This commit **enhances the `RequestLogger`'s debug view** by implementing **hierarchical grouping and chronological ordering** of requests. It refactors the `requestLogTree` provider to use a new `buildHierarchicalTree` method, enabling log entries to be grouped by `CapturingToken`s, which significantly improves the readability and traceability of complex operations within the **`copilot` extension**. Although an attempt to nest subagent calls within this hierarchy was reverted due to `AsyncLocalStorage` limitations with tool invocation contexts, the commit still provides a more structured view and includes **new unit tests** for `RequestLogger`'s grouping logic. Additionally, the **documentation** for the request logger architecture (`request-logger-architecture.md`) has been updated to reflect these changes and outline future improvements.

This commit **refactors** and **cleans up** the **edit processing logic** within the **Chat model**, specifically improving how text and notebook edits are managed. The internal methods, such as `_mergeOrPushTextEditGroup` and `_mergeOrPushNotebookEditGroup` in `src/vs/workbench/contrib/chat/common/model/chatModel.ts`, have been streamlined for better readability and maintainability. This **refactoring** effort enhances the stability of the **Chat feature's** core data handling. Furthermore, **new tests** have been added to `src/vs/workbench/contrib/chat/test/common/model/chatModel.test.ts` to ensure the robustness and correctness of these refined processes, reducing the likelihood of future regressions.

This commit performs **maintenance** by **stopping a focus communication cycle** and **removing redundant communications** within the **Notebook Webview Preloads** module. It specifically refactors the logic around the `focusFirstFocusableOrContainerInOutput` function in `src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts`. This **structural improvement** enhances the efficiency and stability of focus management within notebook outputs by eliminating unnecessary communication overhead. The change ensures a more robust handling of focus without introducing new features or fixing a user-facing bug.

This commit **refactors** the **inline chat functionality** to **integrate the v2 controller**, specifically enhancing its interaction with **notebook prompts**. It **fixes critical issues** in the `chatModel.ts` related to **cell edit creation** and ensures notebooks are not inadvertently re-opened during inline chat sessions. Furthermore, this update **removes deprecated context keys** and outdated logic from the `inlineChatSessionServiceImpl.ts` and `inlineChat.ts` files, streamlining the codebase. This work improves the stability and efficiency of the inline chat experience within notebooks by adopting the newer controller architecture.

This commit **fixes** an issue where **Interactive Window (IW) editors** were incorrectly suggested as implicit context within the **Chat feature**. It introduces a conditional check in `ChatImplicitContextContribution` to explicitly prevent IW editors from being considered for context, and makes a minor adjustment to the `INotebookEditor` interface. This **prevents irrelevant suggestions** from appearing in the chat context, thereby improving the accuracy and user experience of the **AI chat functionality** by ensuring only appropriate content is offered.

This commit **disables three persistently failing tests** within the **notebook smoke test suite** by applying `.skip` to them in `notebook.test.ts`. This is a **maintenance task** aimed at addressing **test instability** that was causing frequent CI failures. The change temporarily reduces the scope of **notebook tests** to ensure more reliable CI runs, allowing other checks to pass consistently while the underlying issues are investigated.

This commit **removes redundant logic** within the **Chat editing functionality**, specifically addressing how **notebook cell changes** are processed. It eliminates unnecessary mirroring of appending output items from the `handleCellChanges` method within the `ChatEditingModifiedNotebookEntry` component. This **cleanup** prevents inefficient or incorrect duplication of output data, thereby improving the **performance and correctness** of the **chat editing experience** when interacting with notebook outputs.

This commit **fixes a bug** in the **Copilot extension's chat replay session provider** that caused tool calls to be incorrectly displayed in the UI. It modifies the `resolveSession` function within `chatReplaySessionProvider.ts` to explicitly set `isComplete` and `isConfirmed` to `true` for `ChatToolInvocationPart` objects. This **bug fix** ensures that tool invocations are properly rendered and prevents the chat replay UI from showing an error or an incomplete state for these elements. As a result, users will now see accurate and complete representations of tool calls when reviewing chat replay sessions.

This commit performs a significant **refactoring** effort to **reduce `any` type usage** across the **Copilot extension**, primarily enhancing **type safety** and code robustness. It refines types from `any` to `unknown` for properties like `prompt` in `inlineFixIntentInvocation.ts` and `fixIntent.ts`, and `args` in `chatReplayResponses.ts`. More extensively, the **replay functionality** sees improvements through the introduction of new interfaces and refined type annotations in `replayParser.ts` and `replayDebugSession.ts`, ensuring better type inference and preventing potential runtime errors. This work improves the overall maintainability and reliability of the Copilot extension's codebase.

This commit performs a significant **refactoring** of the **Copilot extension's chat replay functionality**, moving from an intent-based, inline function approach to a more structured, class-based participant model. It removes the old `ChatReplayIntent` from the registered intents and introduces a new `ChatReplayParticipant` class, which now directly implements the chat participant request handler. This **maintenance** effort enhances the internal architecture and maintainability of the replay subsystem by centralizing request handling within the `handleRequest` method of the dedicated participant class.

remove langauge declaration (#2011)

This commit performs **maintenance** by enhancing the diagnostic output of tests related to the **Notebook Outline** feature within the workbench. It **improves the assert messages** in `src/vs/workbench/contrib/notebook/test/browser/contrib/notebookOutline.test.ts` to provide more detailed information when a test fails. Specifically, the `'Notebook falsely detects "empty cells"'` test now offers clearer context upon failure, making it easier for developers to understand and debug issues related to notebook cell detection. This change directly improves the developer experience by streamlining the debugging process for the notebook outline functionality.

This commit introduces a **new capability** to **recover and display full chat sessions from exported log files** within the **Copilot extension's replay functionality**. It implements a new `ChatReplaySessionProvider` to parse replay log steps and convert them into a structured chat history, correctly handling various message formats via modifications to `parsePrompt`. A new command, `registerDisplayChatFromLogCommand`, allows users to easily load and visualize these historical chat interactions, significantly enhancing the ability to **debug and review past Copilot sessions**. This **feature** provides a crucial tool for understanding and analyzing Copilot's behavior by making past interactions fully accessible.

This commit introduces a **new feature** that allows users to **save images directly from notebook cell outputs**. A new `SaveCellOutputImageAction` command, identified by `SAVE_OUTPUT_IMAGE_COMMAND_ID`, is now available within the **notebook output menu**, enabling direct file system interaction via file dialogs. This enhancement to the **Notebook output actions** also includes refactoring common logic into helper functions and adding a new `saveIcon` for the UI. The change significantly improves the usability of **notebook output management** by providing a dedicated option for image persistence.

This commit performs **maintenance** by **enabling and enhancing several smoke tests** within the **notebook editor** test suite. It specifically unskips existing tests and adds more strenuous checks for **notebook cell operations**, such as inserting, deleting, and editing code cells, as well as verifying focus management during these actions. This improves the reliability and coverage of the **notebook functionality** tests, ensuring better stability for core cell interactions and user experience.