jzaffiro

This commit **updates the performance benchmarks CI/CD pipeline** to integrate a **new version of the tenant script** for managing test resources. This **chore** modifies `tools/pipelines/templates/include-test-perf-benchmarks.yml` and `tools/pipelines/test-perf-benchmarks.yml` to update Azure subscription details and ODSP login environment variables. Crucially, it adds the `--useFic` flag to both `trips-setup` and `trips-cleanup` commands, ensuring that test resource acquisition and release leverage the latest tenant resource management capabilities. This update improves the robustness and accuracy of the **performance benchmark execution environment** by aligning resource provisioning with current infrastructure requirements.

This commit **updates the authentication method** for **real service e2e and stress test pipelines** to utilize **federated tokens** for credential management. It **refactors** the `tools/pipelines/templates/include-test-real-service.yml` template to implement this change. The update involves adding the `--useFic` flag to tenant setup and cleanup scripts, alongside introducing new environment variables required for federated token authentication within the pipeline. This ensures that test tenant acquisition for these critical pipelines uses the specified credential method, impacting how **e2e and stress tests** are authenticated and executed against real services.

This commit **sanitizes user display names** within the **dice roller example** application to prevent security vulnerabilities. It addresses a potential **injection attack** vector by changing the rendering of user display names from raw HTML to plain text. This **security fix** ensures that malicious scripts or HTML embedded in user names cannot be executed or alter the page structure, thereby improving the robustness of the example application.

This commit **removes a temporary configuration flag** that previously allowed or staged the removal of `bindHandles` operations within a **detached `directory`**. This flag was part of a staged rollout to control the behavior of **handle binding** in specific component states. By eliminating this configuration, the system's behavior regarding `bindHandles` in **detached directories** is now solidified, improving **code clarity** and simplifying **configuration management**. This is a **maintenance cleanup** that completes a previous staged change, ensuring consistent behavior for the `directory` module.

This commit **skips** a specific **end-to-end test** to prevent flakiness and timeouts observed in certain environments. Specifically, the `'snapshot was refreshed after some time'` test within `packages/test/test-end-to-end-tests/src/test/refreshSerializedStateManager.spec.ts` is now bypassed when executed against the **Tinylicious** driver. This is a **temporary maintenance adjustment** to the **test infrastructure**, addressing a known issue where the test was unreliable. The change ensures more stable CI/CD runs by avoiding intermittent failures, with a permanent fix planned for a future work item.

This commit **adds unit tests** to validate the correct behavior of segment annotation within the **`SharedString`** DDS and its underlying `merge-tree` data structure. Specifically, these tests ensure that when a **single multi-character segment is annotated**, it is not erroneously split into multiple smaller segments, thereby maintaining data integrity. New test cases in `client.walkSegments.spec.ts` and `sharedString.spec.ts` cover both local annotation operations and scenarios involving remote synchronization. This **enhances the robustness** and **correctness** of text manipulation, guaranteeing segment integrity during annotation operations for users of `SharedString`.

This commit introduces a significant **refactoring** and **performance optimization** within the **`shared-object-base`** package by rewriting the `bindHandles` utility function in `utils.ts`. The updated `bindHandles` now exclusively focuses on binding handles, eliminating its previous responsibility for encoding and, critically, avoiding the cloning of its input object. This change improves **memory efficiency** and **runtime performance** across various **Distributed Data Structures (DDSs)** and shared object operations, as demonstrated by updated calls in `directory.ts` and `sharedObject.ts`. New tests in `sharedObject.spec.ts` validate the correct behavior of the streamlined function, ensuring that handle binding occurs without unintended side effects or overhead.

This commit **updates the documentation** for the **`getkeys` tool** by modifying its `README.md` file. It clarifies that `getkeys` is **no longer used for managing ODSP tenant credentials**, reflecting a recent change in the project's tenant management strategy. This **documentation update** ensures that developers consulting `tools/getkeys/README.md` are correctly informed about the deprecation of this specific functionality. Users will now be directed to the new, authoritative documentation for tenant credential management, preventing confusion and improving the accuracy of developer guidance.

This commit performs **maintenance** on the **stress test pipeline** by **removing outdated tenant configurations**. It rectifies an oversight from a previous change (`#25437`) that mistakenly left old tenants active, ensuring a complete transition to the **new tenant system**. The change guarantees that **stress tests** are exclusively run against the intended, **new tenant configurations**, thereby improving the accuracy and relevance of performance testing results.

This commit **reverts** a previous change that prevented reading operations from the cache when a versioned document was opened. This **maintenance** action is performed because a separate commit (#25337) has now been merged, which correctly adds file version information to op cache entries. Specifically, the **ODSP driver**'s `odspDocumentService.ts` is updated within the `connectToDeltaStream` logic to always attempt retrieving operations from the cache. This ensures that the system can now safely and effectively leverage the **op cache** for all document types, including versioned ones, potentially improving performance by reducing redundant network requests.

This commit **resolves a critical data consistency bug** within the **ODSP driver's caching mechanism**. Previously, only snapshot entries contained version information, leading to operations (ops) from the main document being incorrectly applied to older document versions. To rectify this, the commit **updates both snapshot and op cache entries** to consistently include the `fileVersion`, ensuring that all cached data is correctly associated with its specific document state. This **bug fix** significantly enhances the **reliability and data integrity** of the **ODSP driver**, preventing incorrect state reconciliation and improving the overall consistency of Fluid documents by correctly versioning cached data.

This commit **refactors** the **ODSP driver caching mechanism** by unifying the `getKeyForCacheEntry` function across `odsp-driver` and `driver-web-cache`. It centralizes the implementation of `getKeyForCacheEntry` within `odsp-driver-definitions`, ensuring a single, consistent method for generating cache keys and improving code maintainability. Additionally, this work introduces a **new capability** by adding an optional `fileVersion` property to the `IFileEntry` interface in `odsp-driver-definitions`, which will enable future versioning support for cached entries. This change streamlines cache key generation logic and prepares the system for more robust cache management.

This commit **migrates the performance benchmarks pipeline** to utilize the **new tenant system**, continuing the effort to deprecate older tenant implementations. It introduces an `endpointName` parameter and conditional logic within `tools/pipelines/templates/include-test-perf-benchmarks.yml` to handle **Azure authentication** and acquire **ODSP tenant credentials**. The main `tools/pipelines/test-perf-benchmarks.yml` pipeline is updated to consume this new parameter, adjust ODSP locking mechanisms, and incorporate crucial tenant credential cleanup steps. This **pipeline infrastructure update** ensures that **performance tests** are executed against the correct and secure tenant environment, improving the reliability and consistency of benchmark results.

This commit **updates the stress test pipeline** for the **ODSP prod stage** to incorporate newly introduced tenants, leveraging infrastructure from a previous change. It modifies the `tools/pipelines/templates/include-test-real-service.yml` template to correctly handle tenant checkout, release, and environment variables within the `stress_tests_odsp` stage. This **maintenance enhancement** improves the realism and coverage of stress tests by utilizing the latest tenant configurations. The change specifically targets the **ODSP prod** environment, with updates for the ODSPDF stage planned for a subsequent commit.

This commit **enhances telemetry** within the **ODSP driver** by adding the `fileVersion` to the existing `fetchSnapshot` performance event. Specifically, the `fetchLatestSnapshotCore` function in `packages/drivers/odsp-driver/src/fetchSnapshot.ts` now includes this new data point in its `perfEvent`. This **new capability** allows for better identification of when a versioned document is loaded from telemetry, improving monitoring and analysis of document loading behavior.

This commit **reverts** a recent version bump for the **`@ff-internal/trips-setup` package** within the **CI/CD pipeline templates**. Specifically, it rolls back the package version from `0.0.6` to `0.0.5` in the `tools/pipelines/templates/include-test-real-service.yml` file. This **maintenance revert** ensures that the automated real service tests continue to use the previously stable version of the setup package, preventing potential disruptions from the newer version. The change primarily impacts the **build and test infrastructure**, ensuring pipeline stability.

This commit performs a **maintenance update** by bumping the version of the `@ff-internal/trips-setup` package from 0.0.5 to 0.0.6. This change is applied within the **e2e test pipeline configuration**, specifically in `tools/pipelines/templates/include-test-real-service.yml`. The update ensures that **end-to-end tests** utilize the latest version of the tenant setup logic, incorporating any recent improvements or fixes from that package. This helps maintain the relevance and accuracy of the test environment against current dependencies.

This commit implements a **bug fix** within the **ODSP driver** (`odsp-driver`) to resolve a data consistency issue affecting **versioned documents**. It **modifies the ops cache retrieval logic** in `odspDocumentService.ts` to prevent versioned documents from reading operational transform (op) data from the cache that is associated with the main document rather than their specific version. By temporarily disabling ops cache reads for non-main document versions, this change ensures **data integrity** and prevents potential state corruption when interacting with **versioned documents**. This targeted fix improves the reliability of document state management.

This commit introduces a **refactoring** within the **`DDS/map`** package, specifically impacting the **`SubDirectory`** component's handling of data handles. It **disables handle binding by default** when the container is in a **detached state**, opting instead to resolve handles locally to improve efficiency. A new configuration option is provided to allow re-enabling `bindHandles` if needed, serving as a **preparatory step** for its eventual removal. This change streamlines handle management in detached environments, potentially leading to **performance optimizations** and reduced resource consumption.

This commit **reverts a previous change** by reintroducing the call to `bindHandles` within the `set` method of the `SubDirectory` class in `packages/dds/map/src/directory.ts`. This **bug fix** addresses unit test failures that occurred after the initial removal of `this.bindHandles(value)`. The reintroduction ensures that **handles are correctly bound** when values are set in a `SharedDirectory`'s `SubDirectory`, preventing regressions and maintaining data integrity for this **DDS component**. An investigation into the underlying issue that prompted the original removal is ongoing.